From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007AbdCAOOH (ORCPT ); Wed, 1 Mar 2017 09:14:07 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:40987 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834AbdCAOOC (ORCPT ); Wed, 1 Mar 2017 09:14:02 -0500 Subject: Re: [PATCH 3/3] watchdog: retu: restore MFD dependency To: Arnd Bergmann References: <20170301091531.522161-1-arnd@arndb.de> <20170301091531.522161-4-arnd@arndb.de> Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Lee Jones , linux-kernel@vger.kernel.org From: Guenter Roeck Message-ID: <7ed56c44-eac1-b830-a21a-43b097f2cb5d@roeck-us.net> Date: Wed, 1 Mar 2017 06:13:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170301091531.522161-4-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/01/2017 01:15 AM, Arnd Bergmann wrote: > The retu watchdog calls into the respective mfd driver, but fails to > link if that is diabled: > > drivers/watchdog/built-in.o: In function `retu_wdt_set_timeout': > ziirave_wdt.c:(.text+0x8c88): undefined reference to `retu_write' > ziirave_wdt.c:(.text+0x8c88): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `retu_write' > drivers/watchdog/built-in.o: In function `retu_wdt_start': > ziirave_wdt.c:(.text+0x8cc8): undefined reference to `retu_write' > ziirave_wdt.c:(.text+0x8cc8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `retu_write' > > This restores the dependency as it was before > > Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") > Signed-off-by: Arnd Bergmann Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index a199e8536ce4..52a70ee6014f 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -586,7 +586,7 @@ config UX500_WATCHDOG > > config RETU_WATCHDOG > tristate "Retu watchdog" > - depends on MFD_RETU || COMPILE_TEST > + depends on MFD_RETU > select WATCHDOG_CORE > help > Retu watchdog driver for Nokia Internet Tablets (770, N800, >