From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93831C4363C for ; Wed, 7 Oct 2020 08:23:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 449DE20870 for ; Wed, 7 Oct 2020 08:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727926AbgJGIXY (ORCPT ); Wed, 7 Oct 2020 04:23:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgJGIXV (ORCPT ); Wed, 7 Oct 2020 04:23:21 -0400 Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24D22C061755; Wed, 7 Oct 2020 01:23:21 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C5nQt4mBFz1rtMh; Wed, 7 Oct 2020 10:23:17 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C5nQs42wZz1qrg7; Wed, 7 Oct 2020 10:23:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id tQTGD6EF-HpS; Wed, 7 Oct 2020 10:23:15 +0200 (CEST) X-Auth-Info: YXCZjV5dOMn4jgIRwSTJvLxhPaV22tlJrmyTW7fudiU= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 7 Oct 2020 10:23:15 +0200 (CEST) Subject: Re: PHY reset question To: Marco Felsch , Florian Fainelli Cc: Oleksij Rempel , Andrew Lunn , netdev@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, mkl@pengutronix.de, kernel@pengutronix.de, David Jander References: <20201006080424.GA6988@pengutronix.de> <2cc5ea02-707e-dbb5-c081-4c5202bd5815@gmail.com> <42d4c4b2-d3ea-9130-ef7f-3d1955116fdc@denx.de> <0687984c-5768-7c71-5796-8e16169f5192@gmail.com> <20201007081410.jk5fi6x5w3ab3726@pengutronix.de> From: Marek Vasut Message-ID: <7edb2e01-bec5-05b0-aa47-caf6e214e5a0@denx.de> Date: Wed, 7 Oct 2020 10:23:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201007081410.jk5fi6x5w3ab3726@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/20 10:14 AM, Marco Felsch wrote: > Hi Marek, Hi, [...] > On 20-10-06 14:11, Florian Fainelli wrote: >> On 10/6/2020 1:24 PM, Marek Vasut wrote: > > ... > >>> If this happens on MX6 with FEC, can you please try these two patches? >>> >>> https://patchwork.ozlabs.org/project/netdev/patch/20201006135253.97395-1-marex@denx.de/ >>> >>> https://patchwork.ozlabs.org/project/netdev/patch/20201006202029.254212-1-marex@denx.de/ >> >> Your patches are not scaling across multiple Ethernet MAC drivers >> unfortunately, so I am not sure this should be even remotely considered a >> viable solution. > > Recently I added clk support for the smcs driver [1] and dropped the > PHY_RST_AFTER_CLK_EN flag for LAN8710/20 devices because I had the same > issues. Hope this will help you too. > > [1] https://www.spinics.net/lists/netdev/msg682080.html I feel this might be starting to go a bit off-topic here, but isn't the last patch 5/5 breaking existing setups ? The LAN8710 surely does need clock enabled before the reset line is toggled.