From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E8E0C433B4 for ; Mon, 17 May 2021 12:35:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31FBB61244 for ; Mon, 17 May 2021 12:35:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235208AbhEQMhH (ORCPT ); Mon, 17 May 2021 08:37:07 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4715 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbhEQMhG (ORCPT ); Mon, 17 May 2021 08:37:06 -0400 Received: from dggems702-chm.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FkJRm4T2jzmhZW; Mon, 17 May 2021 20:32:20 +0800 (CST) Received: from dggema762-chm.china.huawei.com (10.1.198.204) by dggems702-chm.china.huawei.com (10.3.19.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 17 May 2021 20:35:48 +0800 Received: from [10.174.179.129] (10.174.179.129) by dggema762-chm.china.huawei.com (10.1.198.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 17 May 2021 20:35:47 +0800 Subject: Re: [PATCH] media: hantro: Fix PM reference leak in device_run() To: Johan Hovold CC: , , , , , , , , References: <20210517081516.1562794-1-yukuai3@huawei.com> From: "yukuai (C)" Message-ID: <7ee3a948-8249-9f07-82ba-6d347037e50f@huawei.com> Date: Mon, 17 May 2021 20:35:47 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.129] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggema762-chm.china.huawei.com (10.1.198.204) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/05/17 16:22, Johan Hovold wrote: > On Mon, May 17, 2021 at 04:15:16PM +0800, Yu Kuai wrote: >> pm_runtime_get_sync will increment pm usage counter even it failed. >> Forgetting to putting operation will result in reference leak here. >> Fix it by replacing it with pm_runtime_resume_and_get to keep usage >> counter balanced. >> >> Reported-by: Hulk Robot >> Signed-off-by: Yu Kuai >> --- >> drivers/staging/media/hantro/hantro_drv.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c >> index eea2009fa17b..7a6d3ef22096 100644 >> --- a/drivers/staging/media/hantro/hantro_drv.c >> +++ b/drivers/staging/media/hantro/hantro_drv.c >> @@ -160,7 +160,7 @@ static void device_run(void *priv) >> src = hantro_get_src_buf(ctx); >> dst = hantro_get_dst_buf(ctx); >> >> - ret = pm_runtime_get_sync(ctx->dev->dev); >> + ret = pm_runtime_resume_and_get(ctx->dev->dev); >> if (ret < 0) { >> pm_runtime_put_noidle(ctx->dev->dev); > > This is clearly broken as there is no PM usage count leak here. > > Please try to understand the code you're changing before submitting any > more patches based on "robot" feedback. Hi, Sorry about the mistake, and thank you very much for your explanation Yu Kuai > >> goto err_cancel_job; > > Johan > . >