From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9DEBC77B7C for ; Tue, 25 Apr 2023 13:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234097AbjDYNPX (ORCPT ); Tue, 25 Apr 2023 09:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234024AbjDYNPS (ORCPT ); Tue, 25 Apr 2023 09:15:18 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F412913FB6 for ; Tue, 25 Apr 2023 06:15:11 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-94f109b1808so1079251666b.1 for ; Tue, 25 Apr 2023 06:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682428510; x=1685020510; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=S3BikuggXhWs1OPUQPTsPuMkYRDNlCEeDeec0U2qCGU=; b=npeWsqFvrxdDEjHJ40Ljy4HgJG2I6Qag8a8pP//WROOGC4bMMXJXG3NUbeC2rI+Agm zM9WBSRzLcIEKfcvxacDUawYlNSrP0XYjoBLYQGI6uUElAthC5524feJDJUWQ+PehVdc 22poIpMVGBO5EQJrClH4W5BuJtjELXcdAgYPtFQAD9z5BOd9XCCXF+MvEBJ3A6ef5SXB 4pHezttks4lY4jLY79TrMulHjKlLvwIpKISxTo7x1l5cUonXCI4y1LUOAyfSiS0LeiIT jQ83HGi1AWY3Utj5K0L0cnNQlqX/oqhs2cOYsjyRCbRG/N4b7Tw9S7bca+7qjcYjynjM fDlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682428510; x=1685020510; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S3BikuggXhWs1OPUQPTsPuMkYRDNlCEeDeec0U2qCGU=; b=heKJ+XhO0iRZuXj/vmqfDWUYLqX1qxloA4G8ks5XHrE/eaFmW+RhpebhO4dRtkdk5T 1XGXnBmyx3iabNrH88n2teBLAwxnHfDnhj47Cyn8+WuMH5c0uoteJtgm64wkAxBtWGsc 5IJXgozlwt2ebBw2eb68mDVj+qPO+bGt9cB6W5B1lVc4PwgZMYfudzqCjIx+M28SOYEE J3vHKTLkvLhJoWbFrd/IOjf+TtiSf2ESod2rPvf511vqhezbGAdM7miQAknCw3ZEDRUY +gW5hc45LYBNDOb+UrBVAM/V+vvBsEN15wY9RDjLuTw30/1EYNqoElp/PeBNXp+s6owa /whg== X-Gm-Message-State: AAQBX9eZNK+Vo/NtoVZupa9Kh5ohfWXH01NuaChsId0G8/l2erIw1bgT TkcjtSTLcprgfOWFeF272XJNdw== X-Google-Smtp-Source: AKy350Ykr4gtdZ1ZSW54CjRQJltXgFAHvYw5B1VZUVrxe/v1FVbbmrQbyexNMdoBYd1tjbR3rUIt/w== X-Received: by 2002:a17:906:40f:b0:94f:a8fd:b69f with SMTP id d15-20020a170906040f00b0094fa8fdb69fmr14098617eja.18.1682428510422; Tue, 25 Apr 2023 06:15:10 -0700 (PDT) Received: from [192.168.9.102] ([195.167.132.10]) by smtp.gmail.com with ESMTPSA id ox6-20020a170907100600b008f89953b761sm6753105ejb.3.2023.04.25.06.15.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Apr 2023 06:15:09 -0700 (PDT) Message-ID: <7ee3eec8-b5b4-2591-adcd-1831bf7de02b@linaro.org> Date: Tue, 25 Apr 2023 15:15:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/4] ARM: dts: aspeed: mtmitchell: Add I2C Fan To: Chanh Nguyen , OpenBMC Maillist , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230425065715.21871-1-chanh@os.amperecomputing.com> <20230425065715.21871-3-chanh@os.amperecomputing.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230425065715.21871-3-chanh@os.amperecomputing.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/04/2023 08:57, Chanh Nguyen wrote: > Add the MAX31790 node as a Fan I2C controller. It controls the > TACH and PWM for Fan Mt.Mitchell system. > > Signed-off-by: Chanh Nguyen > --- > arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts > index e79f56208b89..6455cf80da0e 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts > @@ -477,6 +477,18 @@ > line-name = "bmc-ocp0-en-n"; > }; > }; > + > + max31790@20 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "maxim,max31790"; Unfortunately the compatible is undocumented. Please run scripts/checkpatch.pl and fix reported warnings. Best regards, Krzysztof