From: duoming@zju.edu.cn
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: linux-hams@vger.kernel.org, ralf@linux-mips.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] netrom: fix sleep in atomic context bugs in timer handlers
Date: Thu, 28 Jul 2022 10:07:55 +0800 (GMT+08:00) [thread overview]
Message-ID: <7ee70f8a.625d3.182428f792f.Coremail.duoming@zju.edu.cn> (raw)
In-Reply-To: <20220727183647.23ae46f8@kernel.org>
Hello,
On Wed, 27 Jul 2022 18:36:47 -0700 Jakub Kicinski wrote:
> On Tue, 26 Jul 2022 11:24:20 +0800 Duoming Zhou wrote:
> > nr_heartbeat_expiry
> > nr_write_internal
> > nr_transmit_buffer
>
> void nr_transmit_buffer(struct sock *sk, struct sk_buff *skb)
> {
> [...]
> if (!nr_route_frame(skb, NULL)) {
>
> > nr_route_frame
>
> int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25)
> {
> [...]
> if (ax25 != NULL) {
> ret = nr_add_node(nr_src, "", &ax25->dest_addr, ax25->digipeat,
>
> ax25 must be NULL on this path AFAICT.
>
> > nr_add_node
> > kmemdup(..,GFP_KERNEL) //may sleep
Thank you for your time and suggestions, I understand.
Best regards,
Duoming Zhou
prev parent reply other threads:[~2022-07-28 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 3:24 Duoming Zhou
2022-07-28 1:36 ` Jakub Kicinski
2022-07-28 2:07 ` duoming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee70f8a.625d3.182428f792f.Coremail.duoming@zju.edu.cn \
--to=duoming@zju.edu.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®