From: Christoph Fritz <chf.fritz@googlemail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: fan53880: Add initial support
Date: Thu, 02 Jul 2020 23:09:41 +0200 [thread overview]
Message-ID: <7ee7829c08f45f5b6907877e0f3b11320c178867.camel@googlemail.com> (raw)
In-Reply-To: <20200701180913.GA22871@sirena.org.uk>
On Wed, 2020-07-01 at 19:09 +0100, Mark Brown wrote:
> /mnt/kernel/drivers/regulator/fan53880.c:63:2: note: in expansion of
> macro 'FAN53880_LDO'
> FAN53880_LDO(1, "VIN12", 2800000),
> ^~~~~~~~~~~~
> /mnt/kernel/include/linux/regulator/driver.h:47:2: error: field name
> not in record or union initializer
> .min_sel = _min_sel, \
> ^
>
> most likely due to the conversion introduced in 60ab7f4153b6af46
> (regulator: use linear_ranges helper). Please rebase against current
> code.
Thanks for the hint, yeah that's it. After picking up a recent linux-
next and adapting it works on current too.
Please let me respin the patches in a v2.
next prev parent reply other threads:[~2020-07-02 21:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 18:52 [PATCH 0/2] regulator: Add FAN53880 support Christoph Fritz
2020-06-30 18:52 ` [PATCH 1/2] regulator: fan53880: Add initial support Christoph Fritz
2020-07-01 18:09 ` Mark Brown
2020-07-02 21:09 ` Christoph Fritz [this message]
2020-06-30 18:52 ` [PATCH 2/2] dt-bindings: regulator: Document bindings for fan53880 Christoph Fritz
2020-07-03 17:04 ` [PATCH 0/2] regulator: Add FAN53880 support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee7829c08f45f5b6907877e0f3b11320c178867.camel@googlemail.com \
--to=chf.fritz@googlemail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®