From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755198AbcFTPOe (ORCPT ); Mon, 20 Jun 2016 11:14:34 -0400 Received: from mail-by2on0068.outbound.protection.outlook.com ([207.46.100.68]:60067 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754144AbcFTPON (ORCPT ); Mon, 20 Jun 2016 11:14:13 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-353ff70000000bcf-a4-576803543bb4 Subject: Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation To: Arnd Bergmann References: <20160617154737.633440-1-arnd@arndb.de> <76a47d73-26e2-5a9f-7a03-21c72ca613ca@sandisk.com> <3671744.A3ustGCdmM@wuerfel> CC: Vasu Dev , "James E.J. Bottomley" , "Martin K. Petersen" , "y2038@lists.linaro.org" , "fcoe-devel@open-fcoe.org" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Bart Van Assche Message-ID: <7eea4ce5-8cc4-d982-57ac-ec6e8d8ba323@sandisk.com> Date: Mon, 20 Jun 2016 16:58:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <3671744.A3ustGCdmM@wuerfel> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsWyRoxnkW44c0a4wZYLMhZ/Jx1jt7ixaBmT xaqJeRaXd81hs+i+voPNYvnxf0wWW1f9Ybe40rWSyYHD4/evSYwei/e8ZPJ4cGgzi8ftf4+Z PTqfrGf2+Pj0FovH501yAexRXDYpqTmZZalF+nYJXBkvWhayFSxjrWifsJe5gXEVSxcjJ4eE gInEnpk72LoYuTiEBOYySfSsf8YI4exglPh7ax4bTNWDZauhqpYySnQ+XccKkhAW8JI43HEH rEhEQFFi6otnzCC2kEA7o8SNJ2UgDcwCX5gkHmz7wg6SYBMwkvj2fibYbl4BO4nHt7eANbAI qErc+HWfEcQWFYiQ6P21BKpGUOLkzCdgNqeApsSa7jawGmYBC4mZ889D2fIS29/OYYa49C6r xOkeBYgj1CVOLpnPNIFReBaSUbOQtM9C0r6AkXkVo1huZk5xbnpqgaGpXnFiXkpmcbZecn7u JkZIRGXuYLz7xPsQowAHoxIPr8XZtHAh1sSy4srcQ4wSHMxKIrwz/qeHC/GmJFZWpRblxxeV 5qQWH2KU5mBREud1u/clTEggPbEkNTs1tSC1CCbLxMEp1cAYU3fMWXiJS95Ktb8HJ33wnXNj n9lk7bUxHLclDdY8v2vnfdmx6T6z5iO9/5XeAvnLW08dfnmk1fv2Trl7h5UrFs897/SVRf6e 4pSGGbJXV4T4s650fyNvH1p/7ewOEb3db4tnnDtzg2te3q4rGhoRvcUibH+bN++TPL3mfXWN qKNZj9uVLY9nKLEUZyQaajEXFScCAFagJzukAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnluLIzCtJLcpLzFFi42Lh2siRotvOkhFucO+3ucXfScfYLW4sWsZk sWpinsXlXXPYLLqv72CzWH78H5PF1lV/2C2udK1kcuDw+P1rEqPH4j0vmTweHNrM4nH732Nm j84n65k9Pj69xeLxeZNcAHsUl01Kak5mWWqRvl0CV8aLloVsBctYK9on7GVuYFzF0sXIySEh YCLxYNlqti5GLg4hgcWMEpdedLCDJIQFvCQOd9xhA7FFBBQlpr54xgxiCwm0M0rceFIG0sAs 8I1JYs/ZDrBJbAJGEt/ezwSzeQXsJB7f3gLWwCKgKnHj131GEFtUIEKi99cSqBpBiZMzn4DZ nAKaEmu628BqmAXMJOZtfsgMYctLbH87h3kCI98sJC2zkJTNQlK2gJF5FaNYbmZOcW56ZoGh kV5xYl5KZnG2XnJ+7iZGcFBzRu1gvD7R/BAjEwenVAPjii32N8uPOAfLq6xVWPK3Xvv6Rr63 1x7o/VjpF/XtftB0z3tOuXcWd+bcrEifrl4ScfLAKY4J2kx2iy4tPHhC9Yi3okmp67LyXjMG Q1Xuzw4eclpWSsXCz9wM/RnXzfznHfo3xPdr51yRU5y96QfLesoKLm08vJf9XYNYmcBW/0NO ttVbrj5SYinOSDTUYi4qTgQAG0ogTBoCAAA= X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(377454003)(24454002)(189998001)(47776003)(110136002)(65806001)(65956001)(5003600100002)(31686004)(356003)(87936001)(86362001)(23676002)(8936002)(8676002)(4001350100001)(7846002)(81166006)(81156014)(2270400002)(586003)(6806005)(76176999)(64126003)(106466001)(36756003)(50986999)(54356999)(68736007)(11100500001)(69596002)(92566002)(4326007)(230700001)(77096005)(83506001)(50466002)(2906002)(19580395003)(31696002)(97736004)(19580405001)(2950100001)(33646002)(53416004)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR02MB495;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC003;1:VfjkvqDXEOxRG642cH4R6Xts3+ehJr8W4KOXtbDOmvw0XilhICfX/Qm36I493p2JhbR7grmhFyXgSXjpcAMMNnDTgWWn4TaJUC1QUNlRI38nsM4CzRdweeHPdCnLrcJO58Ar/1h3p8j4XxIA4Hpftq9GDlMr0IG35oVZGCSwQQHoP4ym8p4diXQBhtPHkKm92ejGCPMZ9vU4C6NW2WXX3wmmu5vEWG9wJ7Ogbn0UsWIK4ed2ozRqV8GNpzSf0OopmYFro4XSVjEVPbt+aLx8zQrlHgWhgEjy8dhPENTqu71baV3Ks5Fpp7fo7il9uNxSTs08hP/XgcW45LVFOaOmGRF//pMBZZpdASMvLBOD7o/0l6COoy0owEBURSdrox/YiYz+IXkY/O3iF/JCkQ4s2JM9uoPcBcn9jVZia/c0yVjPT1r1jvUkA2hRPloPOr2DdJ27gtBQguovkHT6tUyZHZPghD8OLg0ai7cWmWhoxBqtDh/Px/vqfsi9aOUX9o41 X-MS-Office365-Filtering-Correlation-Id: 95426376-3293-4523-c2de-08d3991b517e X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB495;2:vzaUd2f8nzSp2MO4ARqILaQ3CBiOL4+6vJVHOONL/LLXoJhQUntCGkw/pEmIKjn/Op1Mb68K9LBofS6baBLXirItk6KGt1n8LVNgWGn+9theWl580PfrFHBI0bVWBKaOaNwfq0EFtmOWfNNevglQ5LMqEZFJb+W1RfJFiX+I0bH/EG/o8Nz0q+9rABbGG8X+;3:hnXAap6PBzV8e2CJdcq8Ribd/ltnKddNzv1bQw02/oH1IbD/gWLC/CpI5HJq+MNR6jvR93A1tdGH0GKm/lze8z/jX+FyHHY2B/hYw7H9EMluZuTUPZNT9uHDRv2Y7/xDd9L8KugbDs4TSPT3HxYEMWGNcptZeqfRntcLqfeaI+nAmzLoAH1d3gskZGPnAt9agKg63Iqe5tztXFw6cv5od2q898R+m867nnZuOP/tESs7C0uqjMU+ET+Rm2B2sw0id6VZ/jKtma5l1UjH3shhzQ==;25:QCFCxs3yTMnUkERmg9PQpLm1+77lcDZpCN7LGL3g6R4u8jrfq7J791b5rP1SMms3h/kT3u/33EAmEUNjd5w3WDMvnFdd/bu6b9EXtBigtbQqwn5iwiId0m6N9Bah9tfWH7anm/4HPwJUgYWu3TLK9Xvy2C0CQbAUKdqvw3aCh3rLum5rSgED68DMslAlyDx373zXa79M26/OxydYnBuhmNk8UQpasqNAw88W1iwvXwr0s8UGNocrcjHp33FuZfNP0xJC6aYAZ9JrG5I/RbX0AZGBPs3zWzR5kiF++Om/9Mn6v2t3/H9C/vU+QMmo7vAAubkHSCZSIHDI34VYEhLd57NUezLkdmXF4iMvgfAOSrhh+UCW5TzG8DO2m/LAJh1iXaMGuWGV9Yp7gK8auCwtLLfvjO8B7ZLicDhVe7N537Q= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DM2PR02MB495; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB495;20:r1FFnAVN37X0yohqauQrUdkbLptdph+sNeiQHehmaNccCZ971n3rtvTqcQsEL7Vqpllfu7671lrXwGtrjkyxC46MNmglo1hU7YxQBgjB/8ihmp6NJVDtWS8OLSDADIa+SmjDcLFt0Mw5k2wgCbNlrO5tyBe2sUL3uG4J3qaoPbQi1IvCeO24CgXbIZtYSU3b253MYzzrWrJtqNzn5K41WgAhvFLRfaRlWm57a5jtKe7zu2cAYfRGvMF0tjUrBIXLwAH7TK9gimBYQ2PDj2ASxJZppkV6g77BE+PhQojxps4Ul81btfN8qKaiodECdc0d8guGizjejcHohqAqDL+5K2vWHJEWq74Z2imGKbryDuene07Lmo17tsBKde7eqpaXU9LWom8qP+/VLAv4PVlDspTlZUw+P1WQdRluJci5dFwbYOndgoTaNzBSnl37JT3AuKos8JWqKNqmcAX1TsbSY0J7VfpzYpFzEyyHKjPiRSt1esim7yOZUz5Ap7iOStLs X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(13018025)(13016025)(10201501046)(3002001)(6055026);SRVR:DM2PR02MB495;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB495; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB495;4:nfdtnKlnXWid6NPIYF3pfRAOG2IcTThuWCqpnq6zb9vKP7qE6Mq5+Tih3zhINbrJFrWrUgFqv9uoH55a99b1VTnxDDwBZwdYrFa5x8nNzf1z9W4LV90/3EKnTFTrpz5v8pSwO3qPSOgquTkSH9vQKkaaquV0U3seCnBQoT/fpiF/mYNa0MmiKuWdWbVGp8x6JAodYoMVtyMxVJjApeFnsitxPI8kMCr1PBu2u0DlisB6QjKpnW5MVUclLe29rYqe3tI5KQQf3N8sLmeLzqwpm9ANoRSdwkN1FQBLadAk+FUOzTRBXa+RuoILER48XpezF5txpuCEjFJNitLz+CuRfaj3Ic+jkJ6M+aEAlMn4/XNW4E+/vG7DqccD+10rGpb8f3yf50m2iXzpdaZsVcBVv4aB8bGqf4wTwF9mVucO7+GNZacCanIE2Dq8ogMd1ANtJQBphqHTWtE2a2noQEgWbg== X-Forefront-PRVS: 09796A1B83 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAyTUI0OTU7MjM6d3cvS2ZJSmxuV0xvNExpdWRRWXVzSExlYzhN?= =?utf-8?B?cHlBbmVKUldZam5TaVVhUDhMOFVURHNnVEhTbG9jUHBsdU9ab0V3OFFHWWor?= =?utf-8?B?UXpLOXk3ZkJSTXpLdUNVK0VRdFZTKzhSMlBWbjdWZmFxK2NFbU8wWGc4WGFu?= =?utf-8?B?RFpFOTZwaHdTRjdSTlUvLzMrUFZHc0hLb0tPUC9MV2FZWmJDUEl1YWhYM1My?= =?utf-8?B?aFYrMkRmSTdPY3Y0alFiNndBQWZKeWVWYnNibVpwZ0JMUmszVmZJRWZYMkw2?= =?utf-8?B?Z0xpUmZ2MElDbGF5bHIvZi8ySzFsbWpMOEFiTXdKVkh1cHR5OTlyMFRBN29X?= =?utf-8?B?cTV6SWNxOXNpZzlxV0dHdWsrMTlUZnprR0tOTHRFa3M1UjhEZ085bFMxSm16?= =?utf-8?B?OHpjT1VaRG9WOGRHUHphb1RzdUFGQVNHdUR5UTBEL0ErRkY0SGZDZlpUY3Fp?= =?utf-8?B?di9FUjVXTjk5Y1hKL2o1U3NqQlVNVGZrMmQzdk0va3hJb2ptcmN0cmVWN205?= =?utf-8?B?bUdJQlBsYkhWQVFJek1xWlVvMkR5OGxjMjFnUHp2R0llSno1ZkxUcTVvTStX?= =?utf-8?B?SjlGK2hiclFwVGJTdm5LZ2d4UVdpeHVLbTM5K29NZGxmMDdmWVg0U3dMdWhy?= =?utf-8?B?M1ZkZkdpakc5TGsvSDhYVkxpb2taaTZ0ZjlhSVBxaTNqK3JLUyt0ZitRSy91?= =?utf-8?B?Z0RVRStWTHlJaGVSOGxzVEpDc2JrZ0lQc2ZNM25vSUhVSSttb3p0akh2eUo4?= =?utf-8?B?dER0bVhHRzVQVDB2VUVJUVVGVzl1V2JETTlkRktWMVZva08yekZOV1lYb2xv?= =?utf-8?B?WUxrWThMakZJQVh2TXQrekZkRGh1SW10dmltcEhVZ04ycUpmc2tEUXNGYUxZ?= =?utf-8?B?UnFPR2QvTUlyczVDRStReFlLN01OODBEQnFDZkVmdWh0Q3pnMjBwcmtrUDU3?= =?utf-8?B?bzZ0Sy8zbkRTZUIwQ1Mza0FyWlVSejBtaTB1ZlB5bDRIdTNlL0w4cGFtNnRy?= =?utf-8?B?b0xON1JwZTNiZ1UyYk5mOGNoZ2FMaHA0aVAyS1d1SllPMm9zc054dnpqRFdo?= =?utf-8?B?bUhwcXF0VEFvVWJRd3VXb2RYak11VTRzRjhaTVkzUmdxcVBCVk1yRTBjZ2hE?= =?utf-8?B?ck9ETjRyOUw2dHkvekRUb3dYamdtcVA4UmJ4MmZxTmZ2TUkwT0M3OVVraDJs?= =?utf-8?B?Z0J3RUdqTVlvWTBNYmNYNUxSY0l4OVJCY21rUE5yYXcySnBxdWpralI0WHJ2?= =?utf-8?B?YnNuYmFIaHY3R1dVcmwybVEyNk91Mm5qYjh1Yk1RRXIrWEpoR2NvWWJudE5Z?= =?utf-8?B?OXFSS1FZSEZGeXB0MTVxRmR5QXFDOGo3SmZZcURXc29oQWRFMC9JMktGZXVu?= =?utf-8?B?b3BJUzRjdUdNQ09vWTNVRkcrN20zMGNIdEdvWXhONVE5WUxVVDFZMzlrdVVZ?= =?utf-8?B?OTNvV3JtdFVjNXd1L1dOMjZPMGEyc1hKa0xQWngyR0FlNjEwZ1FRR0V6eDdh?= =?utf-8?B?b1NJUTYza3hEM2xJcXQ4engyUHUrbEJXeDFNankyVjNUS3V3TlduQWhZZHNp?= =?utf-8?B?bFZDZlJrbC9FRkF0aHV4THFUNjBqczEwSHZ3QkN4TXJIQ3NiVHN1QWtmK3Zs?= =?utf-8?B?R2UwYi9VbkJ6RUt5M3IwWW9IVUhCSWxyenFSMnNzc0JCSmlyUG5QZDVoU3lR?= =?utf-8?Q?CoXWC2CqfTi2zmA/8=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB495;6:spqnf+IN8LOEfnbyUQBbXnuUMH05PhgZP+4xLGmXvq9Qku2N88AtiwxEEPok5kkWZrWUzwemumvv29qur8tdytOofKFwIjCgYpfu9bIDHuluLG2ml0rqk0Bo/M4d7ovnOeHMvCV0MEgdmXgRnSEex8j6ByogV+B3LTG0tU/edhP9pTTguBvwfBcOxvZHPb8VBImGcK5lCB1F3I7gIgbjyh/PKOiDx+VLYwPTu5oUMh840sVNPzjTHBcNu+cMFYR4k2s4ZQvI266qWKlBRDQHz/D0kqB4PuYFWAwj7IK2jT91ByOtmDJ2NOKmhkYbZwsWvMfnGTlVoqDhYTV5POb0vw==;5:NKgPiJtAXo5+BBF+IqEdk8IRn0WJHEyabu3S1MXtITajMaG/EP2xEHkKW+a6zyqE2sCg9BZGHU+8XjvQjEEduhvwW3IJfZ6VszBQmYawSg9vLcjin7GIaRDM7TApXTKbcYmCNsUgH9vOuaExAG0hWQ==;24:KywFQgWs2oi+glowXprSUa0CTICII3N86iBh+p1vIwoNmWKdFOw/gi/Z1trqaBHb8KkP9DuVCFQFIPJI3amwfju8SYyp5kwk+7HTWA7/uls=;7:sNxYmp6azhXgWUaVY0nQ6yrU/Iq7/OucQVFStIoro1mm9A0Be3zKPghUGsQLVCtrdNFlhvIU98nmJfqWeDxrxXZ3MuSlVDQIxCPcHTYYMltE8eKYzEfqJdj8esEHejBbvpTUAPqFPBRWDvpKo9wg8zDBjk6+TPTQmR9NcNYqsQw1K8r51Dw8l7CF6UlBbtsS7YQajamUseDNZwONtfdTpleBlM3uYLydsdcu7WVXb75CGErQsIvzhi6nivmMO9oP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB495;20:Tl/Tj+GqgYsuvAZLmwCaRsXBaHN+E1WCA0X9tYW0r9vjr5mbiV3wMk1C9Jm2BBRs23X3ewVHL2r370Eob9V72EKymr4ZV/JjLcgWqCZkDR+MA3EMzsz6s03VyVcvy10Rw9hlRRGVr2WrKuAS1jvbymCnfag2/HwPEwnDcxqmJPqOh1KEy81SL8CuWgGuxA/KiWgVrnKLdLc5uy2dAE2ljmWHXNQ8Uoyk05w94PSUxnoMWUCkekoKCybZYr6XzYAV X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2016 14:58:19.9020 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB495 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/20/2016 04:48 PM, Arnd Bergmann wrote: > On Monday, June 20, 2016 3:54:06 PM CEST Bart Van Assche wrote: >> On 06/17/2016 05:47 PM, Arnd Bergmann wrote: >>> - jiffies_to_timespec(jiffies, &v0); >>> - jiffies_to_timespec(lport->boot_time, &v1); >>> - fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec); >>> + fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ; >> >> Does this patch introduce a 64-bit division? There might still be 32-bit >> users of this code. > > No, both lport->boot_time and jiffies are 'unsigned long'. Ah, you're right. Hence: Reviewed-by: Bart Van Assche