From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,
Steve Longerbeam <slongerbeam@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@puri.sm,
phone-devel@vger.kernel.org
Subject: Re: [PATCHv2 3/4] media: imx: Forward type of hardware implementation
Date: Mon, 18 Oct 2021 12:20:40 +0200 [thread overview]
Message-ID: <7eed841351748709ec9a173532cd3db99139d69e.camel@pengutronix.de> (raw)
In-Reply-To: <20211017102904.756408-3-dorota.czaplejewicz@puri.sm>
On Sun, 2021-10-17 at 13:08 +0200, Dorota Czaplejewicz wrote:
> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> ---
> drivers/staging/media/imx/imx-media-capture.c | 14 ++++++++------
> drivers/staging/media/imx/imx-media-utils.c | 3 ++-
> drivers/staging/media/imx/imx-media.h | 3 ++-
> 3 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-capture.c b/drivers/staging/media/imx/imx-media-capture.c
> index fdf0f3a8f253..22208b7ce825 100644
> --- a/drivers/staging/media/imx/imx-media-capture.c
> +++ b/drivers/staging/media/imx/imx-media-capture.c
[...]
> @@ -184,7 +185,8 @@ __capture_try_fmt(struct v4l2_pix_format *pixfmt, struct v4l2_rect *compose)
> static int capture_try_fmt_vid_cap(struct file *file, void *fh,
> struct v4l2_format *f)
> {
> - __capture_try_fmt(&f->fmt.pix, NULL);
> + struct capture_priv *priv = video_drvdata(file);
Missing blank line.
> + __capture_try_fmt(&f->fmt.pix, NULL, priv->type);
> return 0;
> }
>
With that fixed,
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2021-10-18 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 11:08 [PATCHv2 1/4] media: imx: Remove unused functions Dorota Czaplejewicz
2021-10-17 11:08 ` [PATCHv2 2/4] media: imx: Store the type of hardware implementation Dorota Czaplejewicz
2021-10-18 10:20 ` Philipp Zabel
2021-10-17 11:08 ` [PATCHv2 3/4] media: imx: Forward " Dorota Czaplejewicz
2021-10-18 10:20 ` Philipp Zabel [this message]
2021-10-17 11:08 ` [PATCHv2 4/4] media: imx: Use dedicated format handler for i.MX7/8 Dorota Czaplejewicz
2021-10-18 10:20 ` Philipp Zabel
2021-11-03 10:41 ` Dan Carpenter
2021-11-04 11:45 ` Dorota Czaplejewicz
2021-10-18 10:20 ` [PATCHv2 1/4] media: imx: Remove unused functions Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eed841351748709ec9a173532cd3db99139d69e.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=dorota.czaplejewicz@puri.sm \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®