From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77768311C1F for ; Wed, 10 Sep 2025 09:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757494812; cv=none; b=ax/b1x1QTa0bV7UFV6bWsE2QXHaRfhCH9RvT2LWmUbjm/mxt8cT/psLVi3SjWJSbkZOrVVBC5UDCoL5dm9Jmm0UkBeNdlUeDYsUi6h+CcR+x1PwMFJ/8q/2BGfUrVIfxHdlRdHk2jn9cFquEG9klG4BG2Q9IIKAWBakSvyG3HBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757494812; c=relaxed/simple; bh=ZT7WA+GxL/eYdw/CKZHbVX03mClPDYPGVscP/E9NLIA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=fhJ3Mo84FXtAvQoGIYJPdn1xBE9R604cgylaDtW6wBtSbOGyG4oWsygKqHPdTuxB1Lyof2MtyLcPyhqHBFw/02d9UcosKLfySxeg4t+kI1Nu4/Xfgt2rNfN+l3Tkd+EokBuSbmiMCgRcLaM0HkN8Jqx7PprTfYqetj4Ujtrwxt8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=T7zDR1dS; arc=none smtp.client-ip=198.47.19.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="T7zDR1dS" Received: from lelvem-sh02.itg.ti.com ([10.180.78.226]) by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 58A8xRrg481262; Wed, 10 Sep 2025 03:59:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1757494767; bh=SZEwj2uiM3w7JTw8M+i8LSuxV8lRv85UX6fHmzJwKDs=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=T7zDR1dSStBgc/bVeGhNjupJA1V1tveROzhEd8s/g8jwQkPuaFfuiboUAuacVwffM zV5PRD5nf+UCVA8sdpQXYggqhfjWAgytjx1lspnnZB/78lBnj8SBOR6ZxPH/XmEURs D/PqyUX+MFaGYeh75N+MGsvOHTTLD5S9klx/IPV0= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelvem-sh02.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 58A8xR07168290 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Wed, 10 Sep 2025 03:59:27 -0500 Received: from DFLE215.ent.ti.com (10.64.6.73) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Wed, 10 Sep 2025 03:59:27 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE215.ent.ti.com (10.64.6.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Wed, 10 Sep 2025 03:59:26 -0500 Received: from [172.24.235.208] (hkshenoy.dhcp.ti.com [172.24.235.208]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 58A8xIdY233349; Wed, 10 Sep 2025 03:59:19 -0500 Message-ID: <7ef2071a-0c57-4ca8-af67-ed254d5d2faf@ti.com> Date: Wed, 10 Sep 2025 14:29:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20250909090824.1655537-1-h-shenoy@ti.com> <20250909090824.1655537-2-h-shenoy@ti.com> Content-Language: en-US From: Harikrishna Shenoy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea On 9/9/25 19:39, Dmitry Baryshkov wrote: > On Tue, Sep 09, 2025 at 02:38:19PM +0530, Harikrishna Shenoy wrote: >> From: Jayesh Choudhary >> >> Now that we have DBANC framework, remove the connector initialisation code >> as that piece of code is not called if DRM_BRIDGE_ATTACH_NO_CONNECTOR flag >> is used. Only TI K3 platforms consume this driver and tidss (their display >> controller) has this flag set. So this legacy support can be dropped. >> >> Fixes: c932ced6b585 ("drm/tidss: Update encoder/bridge chain connect model") > I'm not sure, why do you have this Fixes tag. Other than that: > > > Reviewed-by: Dmitry Baryshkov > > Hi Dmitry, Have explained about fixes tag in cover letter, that these 4 commits fix the bug of null pointer de-refernce (logs and bug described in cover letter). also have given the rationale of sequencing of commits in cover letter. Warm Regards, Hari >> Signed-off-by: Jayesh Choudhary >> --- >> .../drm/bridge/cadence/cdns-mhdp8546-core.c | 187 +----------------- >> 1 file changed, 10 insertions(+), 177 deletions(-) >>