From: Joe Perches <joe@perches.com>
To: David Laight <David.Laight@ACULAB.COM>,
John Ogness <john.ogness@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 1/5] printk: implement pr_cont_t
Date: Thu, 20 Aug 2020 09:03:21 -0700 [thread overview]
Message-ID: <7ef3bf5553285840fcf082d0a616ca1e3edd0cd3.camel@perches.com> (raw)
In-Reply-To: <b17fc8afc8984fedb852921366190104@AcuMS.aculab.com>
On Thu, 2020-08-20 at 07:44 +0000, David Laight wrote:
> From: Joe Perches
> > Sent: 20 August 2020 01:34
> >
> > On Thu, 2020-08-20 at 01:32 +0206, John Ogness wrote:
> > > Implement a new buffering mechanism for pr_cont messages.
> > >
> > > Old mechanism syntax:
> > >
> > > printk(KERN_INFO "text");
> > > printk(KERN_CONT " continued");
> > > printk(KERN_CONT "\n");
> > >
> > > New mechanism syntax:
> > >
> > > pr_cont_t c;
> > >
> > > pr_cont_begin(&c, KERN_INFO "text");
> >
> > bikeshed:
> >
> > I suggest:
> >
> > printk_begin(&printk_context, fmt, ...)
> > printk_continue(&printk_context, fmt, ...) (maybe printk_next())
> > printk_end(&printk_context, fmt, ...)
>
> I see some very long source lines looming ...
Macros make that pretty short.
pr_<level>_start
pr_next
pr_end
Doesn't seem too bad.
next prev parent reply other threads:[~2020-08-20 16:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 23:26 [RFC PATCH 0/5] printk: new log_cont implementation John Ogness
2020-08-19 23:26 ` [RFC PATCH 1/5] printk: implement pr_cont_t John Ogness
2020-08-20 0:33 ` Joe Perches
2020-08-20 7:44 ` David Laight
2020-08-20 7:59 ` Joe Perches
2020-08-20 8:49 ` David Laight
2020-08-20 9:18 ` John Ogness
2020-08-20 16:03 ` Joe Perches [this message]
2020-08-20 10:16 ` Petr Mladek
2020-08-20 12:33 ` David Laight
2020-08-25 13:10 ` Petr Mladek
2020-08-25 13:38 ` David Laight
2020-08-25 15:32 ` Petr Mladek
2020-08-24 2:08 ` Sergey Senozhatsky
2020-08-24 5:37 ` Sergey Senozhatsky
2020-08-19 23:26 ` [RFC PATCH 2/5] sysrq: use pr_cont_t for cont messages John Ogness
2020-08-20 1:03 ` Linus Torvalds
2020-08-20 17:48 ` Joe Perches
2020-08-20 17:53 ` Linus Torvalds
2020-08-20 22:11 ` John Ogness
2020-08-20 22:36 ` Joe Perches
2020-08-19 23:26 ` [RFC PATCH 3/5] workqueue: " John Ogness
2020-08-19 23:26 ` [RFC PATCH 4/5] locking/selftest: " John Ogness
2020-08-19 23:26 ` [RFC PATCH 5/5] lockdep: " John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef3bf5553285840fcf082d0a616ca1e3edd0cd3.camel@perches.com \
--to=joe@perches.com \
--cc=David.Laight@ACULAB.COM \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome