Re: [v3 3/3] arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device

[Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>]

On 5/9/2022 8:50 AM, Pavan Kondeti wrote:
> Hi Krishna,
>
> On Sun, May 08, 2022 at 05:42:27PM +0530, Krishna Kurapati wrote:
>> Overriding the SNPS Phy tuning parameters for SC7280 IDP device.
>>
>> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
>> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> index 5eb6689..ad85ffb 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
>> @@ -325,6 +325,12 @@
>>   	vdda-pll-supply = <&vreg_l10c_0p8>;
>>   	vdda33-supply = <&vreg_l2b_3p0>;
>>   	vdda18-supply = <&vreg_l1c_1p8>;
>> +	qcom,hs-rise-fall-time-bps = <0>;
>> +	qcom,squelch-detector-bps = <(-2090)>;
>> +	qcom,hs-disconnect-bps = <1743>;
>> +	qcom,hs-amplitude-bps = <1780>;
>> +	qcom,hs-crossover-voltage = <(-31)>;
>> +	qcom,hs-output-impedance = <2600>;
>>   };
> Is this an example change or do we see any HS electrical compliance failures
> on SC7280 IDP that will get fixed with these override sequence?
>
> Thanks,
> Pavan

Hi Pavan,

These results were based on compliance testing results.