From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "Markus.Elfring@web.de" <Markus.Elfring@web.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "jic23@kernel.org" <jic23@kernel.org>,
"Tachici, Alexandru" <Alexandru.Tachici@analog.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: ad7192: fix null de-ref crash during probe
Date: Tue, 7 Apr 2020 04:59:01 +0000 [thread overview]
Message-ID: <7ef930850988a24ce0d24cf2fd7f22a0b08b59af.camel@analog.com> (raw)
In-Reply-To: <4ff0776f-b5de-536a-ccf9-7516f1a65d87@web.de>
On Mon, 2020-04-06 at 21:46 +0200, Markus Elfring wrote:
> > After that patch 'spi_get_device_id(spi)' returns NULL, so this crashes
> > during probe with null de-ref.
>
> How do you think about to use the term “null pointer dereference”
> in the commit message?
depends how long the commit title with be
will take a look
>
>
> > Fixes 66614ab2be38: ("staging: iio: adc: ad7192: removed spi_device_id")
>
> Please correct this tag.
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=7e63420847ae5f1036e4f7c42f0b3282e73efbc2*n183__;Iw!!A3Ni8CS0y2Y!uk9bOaD_449N0PxwtQ_WikWYY5KnpykeZTp-rbrRTju7FZM6fPd48zCD1pe7rTSYypKYkg$
>
> Why was a colon misplaced here?
will fix
thanks
>
> Regards,
> Markus
next prev parent reply other threads:[~2020-04-07 4:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 19:46 Markus Elfring
2020-04-07 4:59 ` Ardelean, Alexandru [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-06 12:31 Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef930850988a24ce0d24cf2fd7f22a0b08b59af.camel@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Alexandru.Tachici@analog.com \
--cc=Markus.Elfring@web.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®