From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbcFFIKX (ORCPT ); Mon, 6 Jun 2016 04:10:23 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35906 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbcFFIKT (ORCPT ); Mon, 6 Jun 2016 04:10:19 -0400 Subject: Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI To: Wanpeng Li References: <1464784501-13710-1-git-send-email-pbonzini@redhat.com> <1464784501-13710-2-git-send-email-pbonzini@redhat.com> <20160601164024.GF30721@potion> <7ba8c545-d0d3-945b-a145-019d3ef6a209@redhat.com> Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , "linux-kernel@vger.kernel.org" , kvm , stable@vger.kernel.org, "J. Kiszka" From: Paolo Bonzini Message-ID: <7f0438c4-f293-7b3b-3ec1-ebe5d55a7f57@redhat.com> Date: Mon, 6 Jun 2016 10:10:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 05:28, Wanpeng Li wrote: >> > No, I don't think so, the existing req_immediate_exit case is only after >> > a VMLAUNCH/VMRESUME vmexit, in which case we already have a >> > >> > if (vmx->nested.nested_run_pending) >> > kvm_make_request(KVM_REQ_EVENT, vcpu); >> > >> > in vmx_vcpu_run. > Do you think this can be removed since it blindly request a > KVM_REQ_EVENT even if there is no still-pending event to L1 which > blocked by nested_run_pending, however, req_immediate_exit can > indicate there is a pending event blocked by nested_run_pending and > the request KVM_REQUEST_EVENT added in your patch can guarantee inject > this pending event in the next nested vmexit. Yes, I think so. Thanks, Paolo