mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jiaxun Yang" <jiaxun.yang@flygoat.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Serge Semin" <fancer.lancer@gmail.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if 64BIT
Date: Tue, 04 Jun 2024 15:51:31 +0100	[thread overview]
Message-ID: <7f0681ea-cd4c-441c-9ac5-0259d0965734@app.fastmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2406012326580.23854@angie.orcam.me.uk>



在2024年6月1日六月 下午11:30，Maciej W. Rozycki写道：
> On Sat, 11 May 2024, Jiaxun Yang wrote:
>
>> csrc-r4k suffers from SMP synchronization overhead.
> [...]
>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
>> index f1aa1bf11166..fa8ca0287568 100644
>> --- a/arch/mips/Kconfig
>> +++ b/arch/mips/Kconfig
>> @@ -1083,6 +1083,7 @@ config CSRC_IOASIC
>>  
>>  config CSRC_R4K
>>  	select CLOCKSOURCE_WATCHDOG if CPU_FREQ
>> +	select HAVE_UNSTABLE_SCHED_CLOCK if 64BIT
>
>  Shouldn't it be:
>
> 	select HAVE_UNSTABLE_SCHED_CLOCK if 64BIT && SMP

This option is not depending on SMP on x86 and PARISC, so I followed
the same approach.

But yes, it makes sense to depend on SMP.

Thanks
>
> then?
>
>   Maciej

-- 
- Jiaxun

  reply	other threads:[~2024-06-04 14:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-11 16:00 [PATCH 0/7] MIPS: clocksource cumulative enhancements Jiaxun Yang
2024-05-11 16:00 ` [PATCH 1/7] MIPS: csrc-r4k: Refine rating computation Jiaxun Yang
2024-06-01 22:23   ` Maciej W. Rozycki
2024-05-11 16:00 ` [PATCH 2/7] MIPS: csrc-r4k: Apply verification clocksource flags Jiaxun Yang
2024-05-11 16:00 ` [PATCH 3/7] MIPS: csrc-r4k: Select HAVE_UNSTABLE_SCHED_CLOCK if 64BIT Jiaxun Yang
2024-06-01 22:30   ` Maciej W. Rozycki
2024-06-04 14:51     ` Jiaxun Yang [this message]
2024-05-11 16:00 ` [PATCH 4/7] MIPS: csrc-r4k: Don't register as sched_clock if unfit Jiaxun Yang
2024-05-11 16:00 ` [PATCH 5/7] MIPS: sync-r4k: Rework based on x86 tsc_sync Jiaxun Yang
2024-05-11 16:00 ` [PATCH 6/7] clocksource: mips-gic-timer: Refine rating computation Jiaxun Yang
2024-05-11 16:00 ` [PATCH 7/7] clocksource: mips-gic-timer: Correct sched_clock width Jiaxun Yang
2024-05-27 12:24   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f0681ea-cd4c-441c-9ac5-0259d0965734@app.fastmail.com \
    --to=jiaxun.yang@flygoat.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=fancer.lancer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®