From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbdJBUlE (ORCPT ); Mon, 2 Oct 2017 16:41:04 -0400 Received: from mout.web.de ([212.227.17.11]:61518 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbdJBUlB (ORCPT ); Mon, 2 Oct 2017 16:41:01 -0400 Subject: [PATCH 1/2] ARM: s3c64xx: Delete two error messages for a failed memory allocation in samsung_bl_set() From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Kukjin Kim , Russell King Cc: LKML , kernel-janitors@vger.kernel.org References: <0b695686-2e07-910d-6278-91d54a1b0b2f@users.sourceforge.net> Message-ID: <7f06d074-231b-85b9-3649-304edce6bc2c@users.sourceforge.net> Date: Mon, 2 Oct 2017 22:39:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <0b695686-2e07-910d-6278-91d54a1b0b2f@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:12YbhmuWHBsR/zwiJseAFwBZmcr8mxBljESvIT+Jp1xz802YgN8 v9Ho+CcNwEmlTYPU26GMEYrFYJ5UPB/XgwrXuWbscQMSW81+S3Uslmca/d840AO7/vYP5fW 1ESgPHRpCPcsq3sl23OHLzPlbuYYvOtTSU8Isn6VE846fSl/58SisUSBRmTH3Pc3Lkn7aiQ nD51iLXtN7YEojySYZsyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:IDncdB4RKnU=:4dIu9o75AjfBE/m18dVZri 5x88CwOA1vrwzdZ37HYzvmJ2kDdFOZoFOltzgryO9L9675EY6LUHWAkzA6+XaM9OrEOk8eCoR 8bXanAf+eEOttFL9y+VtK6XThG28hdhtWIsvUqlR6IRMdDOTzaLLT3RtbUFB0axR9pBMba6NG LGMloxOYyXc08wbTZyRkQibDFLf6cQzQly5UGkzd28urvqAbGsWQ7/IIXgyWUK1MP2ixzL33j yladwUdWxn9ALLJo9lnpHb5NpPooNYquQJThvJ2i8rJT2lTUAw9cdtsulHr1gENVyzDGg3HAr UivkcGBUg+/u1UvaARf+W0XjPI2urCZPjjg1E5lRmrTs3RT2YSxDB+bmi5bYKpkqSNyOal36U ujkUJoP4RgQ4zNYePzi+0YQeicM4eeZf/aq95RnlVPZ3CpU0QFOUae3+AUj8v7FUujbcQSR1M ICr1sDiGnl4WeDHiY+I3tPMltCBf+HHzhsrG8Y4NO8tNgaIL1aFGd2afVn5rM2F1lN6jpKlMm k2HbSXmOObLyGhleH9tapXzeR6CZ0eIu444MgVerpkYH9TRG+zIltLZRZa5qp6YliJ4SLEyRo sO4qRO0awP8ZohhEQZh+ISSH/GQcTyJhbETcT0qeZbqxABMzLXxm+u4oSshixljIOyKiik0Nq /NDrrLFLRNTq24zjsw9o6WwMJaG8o+pzAdDOUL9yesCCF8+25QCylhb5Syj9XMdAh1ohx5Wnf WNhZ3bQ1NyPU76FDiPaCOpR/M7BtUwYS4STUkesmXdBQviEL0NpsIfgnvF+XZh1/zNV5TpDRN lavJlnbo5ZYV/XxmhPOC8tCDie3Dv011fq75SfZ83PqfRBW+3k= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 2 Oct 2017 22:20:39 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/mach-s3c64xx/dev-backlight.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-s3c64xx/dev-backlight.c b/arch/arm/mach-s3c64xx/dev-backlight.c index e62e789f9aee..7e2db762c442 100644 --- a/arch/arm/mach-s3c64xx/dev-backlight.c +++ b/arch/arm/mach-s3c64xx/dev-backlight.c @@ -94,17 +94,14 @@ void __init samsung_bl_set(struct samsung_bl_gpio_info *gpio_info, samsung_bl_device = kmemdup(&samsung_dfl_bl_device, sizeof(struct platform_device), GFP_KERNEL); - if (!samsung_bl_device) { - printk(KERN_ERR "%s: no memory for platform dev\n", __func__); + if (!samsung_bl_device) return; - } samsung_bl_drvdata = kmemdup(&samsung_dfl_bl_data, sizeof(samsung_dfl_bl_data), GFP_KERNEL); - if (!samsung_bl_drvdata) { - printk(KERN_ERR "%s: no memory for platform dev\n", __func__); + if (!samsung_bl_drvdata) goto err_data; - } + samsung_bl_device->dev.platform_data = &samsung_bl_drvdata->plat_data; samsung_bl_drvdata->gpio_info = gpio_info; samsung_bl_data = &samsung_bl_drvdata->plat_data; -- 2.14.2