From: "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
To: Julia Lawall <Julia.Lawall@inria.fr>, Hauke Mehrtens <hauke@hauke-m.de>
Cc: kernel-janitors@vger.kernel.org,
"Rafał Miłecki" <zajec5@gmail.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: BCM47XX: drop unneeded semicolon
Date: Sun, 2 Aug 2026 17:17:19 +0200 [thread overview]
Message-ID: <7f0c699e-a530-490e-bfed-21840ec07861@oss.qualcomm.com> (raw)
In-Reply-To: <20260801191002.1383835-16-Julia.Lawall@inria.fr>
On 1/8/26 21:10, Julia Lawall wrote:
> When a function-like macro expands to an expression, that expression
> doesn't need a semicolon after it. All uses have been verified to
> have their own semicolons.
>
> This was found using the following Coccinelle semantic patch:
>
> @r@
> identifier i : script:ocaml() { String.lowercase_ascii i = i };
> expression e;
> @@
>
> *#define i(...) e;
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
>
> ---
> arch/mips/bcm47xx/buttons.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
next prev parent reply other threads:[~2026-08-02 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 19:10 Julia Lawall
2026-08-02 15:17 ` Philippe Mathieu-Daudé [this message]
2026-08-03 13:10 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f0c699e-a530-490e-bfed-21840ec07861@oss.qualcomm.com \
--to=philmd@oss.qualcomm.com \
--cc=Julia.Lawall@inria.fr \
--cc=hauke@hauke-m.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®