From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C94926B75C for ; Fri, 14 Nov 2025 08:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107227; cv=none; b=csTtX4HlPtlW6s3xMNGUSedEAZSY85BDHUjN7S2AloqhJT58PPc+mNWE/LIVolOqyKap03/3LxSYch7iF4xm47jALj6xl5zA9F8Vw8kELG9dZ4pFm+DFdZvm0e6mV3vW+ParXlTI8IkcaAz8FjNyFW/DcMkYjycszn1iEUo08vY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763107227; c=relaxed/simple; bh=2rEmDzBPvVbBzaVsfHSeKCxSJRV3hxIlDk5T0Pey/9o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m8595prfTo+C5ZvlD7HBsLmaCO6nnWIk3TjpHzIloSsuXcp5m7OEOTRO/yGk75DTKI6dPf2NuM99dDJlrCEHCd3LTyEBnDl4LosODEeX0coLxrlZYalFAV0r/j/XJbFbXwDnGE9TQtNra8Q//JwRGuIE+LtHV9I9Uah+FIugISI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i9lkW645; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i9lkW645" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 247E2C4CEF5; Fri, 14 Nov 2025 08:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763107226; bh=2rEmDzBPvVbBzaVsfHSeKCxSJRV3hxIlDk5T0Pey/9o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=i9lkW645XNOm791Lb7QNFSwRub+ky9+FU9QGDU3xmd1KuKg1qd5rwXZipQDGxbgIe SpPvGKgA/aA/rA9BHDyV9MlaT8ar3sEQ/zRN4nEJCvbb2Kw/QMC3k54BGpusFTuJXo hAD5vSpW1sI8t4RSlsP8PlpLcYHXP5HZ13RkSvrJ09f5szELAVJKcS/V4Jd3o+zXHV v18OJZYML5Nepf4fr2Vjxol6XBvxvzwkLflO6D23DBQM40VHVgl3TwtMswfdE7FgVi kYrV03WEneGteHBsuPADJzUm3i1LUlJWgcYmYadwwvESBSd5Y0JSbBnq5SgLMyYBtY VOPp7P+Ps19AA== Message-ID: <7f0c742a-3799-42cd-86cf-93ebbc9a3897@kernel.org> Date: Fri, 14 Nov 2025 09:00:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fix gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to_ram() To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Cc: kernel test robot , Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20251113051322.1753532-1-balbirs@nvidia.com> <5bdd8b10-171e-4171-a1f2-43c029dfd8e4@kernel.org> <7d5ff6bf-9e44-41da-a9b9-c5424c569e98@nvidia.com> <48265d08-df2b-48df-959b-d2ed1407ceca@kernel.org> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.11.25 21:51, Balbir Singh wrote: > On 11/13/25 22:50, David Hildenbrand (Red Hat) wrote: >> On 13.11.25 11:31, Balbir Singh wrote: >>> On 11/13/25 20:09, David Hildenbrand (Red Hat) wrote: >>>> On 13.11.25 06:13, Balbir Singh wrote: >>>>> ret of type vm_fault_t is reused to capture the return value of >>>>> nouveau_dmem_copy_folio(), which returns an int. Use a new copy_ret >>>>> to fix the issue. The issue is not new, prior to this the function >>>>> called was called nouveau_dmem_copy_one() and ret was used to capture >>>>> it's value. >>>>> >>>>> Reported-by: kernel test robot >>>>> Closes: https://lore.kernel.org/oe-kbuild-all/202511121922.oP20Lzb8-lkp@intel.com/ >>>> >>>> It's a sparse warning, is there any runtime effect? >>>> >>> >>> No impact really, it's just a sparse warning >> >> Okay, then please >> >> 1) Make that clear in the patch description >> >> 2) Make that clear in the patch subject. >> >> In particular, the current subject is weird. Should probably be >> >> "nouveau/dmem: fix sparse warning in nouveau_dmem_migrate_to_ram()" >> > > I did have "sparse warning" in the subject and checkpatch complained that > tools should not be mentioned in the subject, but I'll give it a shot with that. The important part is to be careful with the term "fix" when all we're fixing is some output of a static code analysis tool that does otherwise not result in any actual issues (build time, runtime). -- Cheers David