From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C35733A71C for ; Thu, 20 Nov 2025 14:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763648531; cv=none; b=rMvvhHshLSY5w4pGMDPsWfQjLXXl0Adg+uDy0yeePdKpdusFJ2kbDZVBkjRFvAmQnduzdXEFWXqMM8qwDQdmMTm4ZJz2ued4lv6FdGl+3zV2Yx3P7fAe38hKG38fGsQb4vrlKNqc+8c+6tG+h9CIfBqTmBzCyMoW4zO3JiO7Gek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763648531; c=relaxed/simple; bh=YRVeBBMj7ef056SPY/EQlwP1RflC2jv6harh/WizL7c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o/roRBMz3c3+4ELBs9B3CQrk87+/VpjHe8TcG/Gyhs5fIyKl5lTROEwzRDwr4TEw1m8FINqxGM9E212YNq3p3Cx22Kfbj2338LZQl8yxiCx/8rYJtcq154TX7jmP1dWs9Hikg+yitWwDsbc5UA1e1qIOr7sCWA6zMdo4jfKBdls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TSum62jL; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TSum62jL" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47118259fd8so7963335e9.3 for ; Thu, 20 Nov 2025 06:22:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763648527; x=1764253327; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6r7fI0WPBuZgy0AO/PTqbLex+cwYpycr4cGAYLGeSOY=; b=TSum62jLfRoXkVxdIFpH/dAQgLcP1sbfH3+aSELBdZp5S77VxaH/8oszxlzS+WfKId 5LM/18KSZtZ2KUymcItaOC+pzr1unYOia+buBTv12VLtlPfts6KwSqEcxB5ZNHIL0x2V rh4aT0+SiYzJLSkfXXD1HcNFCj2HkK7nkBRBjhuyrG9iT/rXsbli2mn6D3cNZhmrMxzJ 7n/DvYt0rSPjEWTZtdeuSae4rGbZmyTMgjl2hAVWTlHxdvpN8ryPP81QSUNC38fuR0bL Q/95oFsG49RtfmxlsaTP/1Y15xo4x9dgbgPzUoEUWNSa6yMpxBCHV82Z2+//1kO5vxYJ sykA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763648527; x=1764253327; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6r7fI0WPBuZgy0AO/PTqbLex+cwYpycr4cGAYLGeSOY=; b=ezKbwOJyDZwo8vSrfwNCnJaXZG50qdHlNN92HqxKTFki0cimqtcTv7k9mu6yi60P7C EON2ii+LPvzGoxT1Hc2qI4jCPiBp5RGFbQVRKoPwef+Cbkcpiav3X3lXhv4yOS+QLoSX nPRuDhFQztXsOUbnJK/RX64tnDM3z2TC3aA3kTJaKEzTaBIsdEbW1XmJgP1r1Jn3BNXw sY4sCRpf6KgE/7fKYhwS0tr7X6PewBixoYDfWwJhvw6/TIt1FHTWfpAqeJeIPHDG6nh+ SnmXMe0uiOX03+hfCHOqknJY7Bix1eAtCYnF2Ux61S0XLOQEU06Wj9uA8OgzbyzyIk14 sjag== X-Gm-Message-State: AOJu0YxcwYtn6GV1jh/9WmpkpEhAmD0i90QhwvLeuMSdPRMzICjoycqV 81zbMOue9DEThEFYj4zycDsBRSNLp753fK9av+BVoKW2aNz05qA7UaAT X-Gm-Gg: ASbGnctzbi4hp30gqp4FfRy5UzAEaVUJ7DG0R/d17tBmAYVo6x/diLBX7ZUqpA1ZRLU nbs1AbZU/o1pBSAUnT81PWvfGoLCMGAo3qKWp4d0YKt9k1j5w64LaHiOr7gtgeuZBztT0rKv3pt TpxEvIZDZE/ZtQq8BDmKSQ2k/tyVknGMl8o8Q8vegk6i1zvkanzRyUb31i+5gTQOrk9RJGI6ERv WTXOntetYMsgqTYeEC736zbY7iBK6ICGlELCoB29jX6TDquOZxCZYN0m/0hAvsK8GO+63+VGsvc e/lUIAindFoLbjOg9N+vpUXB/2r6R4O+nJQe4X0cdVs1BLbJHlvBio1IaaaABb9oZd8brI+jFDW trkazDSPRVKL/fIRU0yBqP/TZEG8djegaCuow77TaeBLXhObGlpndLQ9i2/cNSartx4iC0CDKj1 gzb1eR/FIGLb2r5t2+IWDpoFTljhSeKslceg== X-Google-Smtp-Source: AGHT+IG5vqkGiu0GvlQgoxCMGD0CADTUMG278xB+EOd9IXf28tm4i8blPZUxFfIazh/0hI0Gyggy9w== X-Received: by 2002:a05:600c:1f86:b0:477:73e9:dc17 with SMTP id 5b1f17b1804b1-477b8c935d2mr39449735e9.35.1763648527306; Thu, 20 Nov 2025 06:22:07 -0800 (PST) Received: from [192.168.1.121] ([176.206.93.222]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e454sm5944605f8f.2.2025.11.20.06.22.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 06:22:06 -0800 (PST) Message-ID: <7f10404f-de61-4284-b70a-5f0c839896d1@gmail.com> Date: Thu, 20 Nov 2025 15:22:06 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 11/11] HID: asus: add support for the asus-wmi brightness handler To: Antheas Kapenekakis , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Corentin Chary , "Luke D . Jones" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= References: <20251120094617.11672-1-lkml@antheas.dev> <20251120094617.11672-12-lkml@antheas.dev> Content-Language: en-US, it-IT, en-US-large From: Denis Benato In-Reply-To: <20251120094617.11672-12-lkml@antheas.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/20/25 10:46, Antheas Kapenekakis wrote: > If the asus-wmi brightness handler is available, send the > keyboard brightness events to it instead of passing them > to userspace. If it is not, fall back to sending them to it. > > Reviewed-by: Luke D. Jones > Tested-by: Luke D. Jones > Signed-off-by: Antheas Kapenekakis > --- > drivers/hid/hid-asus.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > index 6a355c174f29..ff5aaebc38e3 100644 > --- a/drivers/hid/hid-asus.c > +++ b/drivers/hid/hid-asus.c > @@ -324,6 +324,17 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field, > usage->hid & HID_USAGE); > } > > + if (usage->type == EV_KEY && value) { > + switch (usage->code) { > + case KEY_KBDILLUMUP: > + return !asus_hid_event(ASUS_EV_BRTUP); > + case KEY_KBDILLUMDOWN: > + return !asus_hid_event(ASUS_EV_BRTDOWN); > + case KEY_KBDILLUMTOGGLE: > + return !asus_hid_event(ASUS_EV_BRTTOGGLE); > + } > + } > + > return 0; > } > Reviewed-by: Denis Benato