From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274E522839A for ; Fri, 1 Aug 2025 09:35:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754040942; cv=none; b=Uu0ITiGX5UCCmHL8ByUjemvV/O9mLxO13t3nyZF5iyuEiP49J9O8yl/9MOs4ZKTf9Rpvgg9ZN2drXiw7DAVbx0lRhYjBKkw3juY2tSlrZgNLAOjergODwF+wPvcZon7ClIsw3IJPCm3y/amx0Deu494HrFjrQvjjm0kD5N5SACE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754040942; c=relaxed/simple; bh=RereaYefPMJ+AN1G/WR2ZPJ7Q/9VsGyrmIOo6U3bInI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TnMTRm6JjW9ocX2y/iEN+SCUDUXyk2LzB+Y9qna/r8NaMqTUr2yZA9BTLljvNa1Po0yT8acOE0w6REY3DoZOmmrWcP8LiCQqI/l9l25Wlo2uueYxQYYrOrCeP9SxyQEP9BxXEBfLXZp5CK/22HV2XYRHcu0Vwn5zhq/k42L1JaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HlpmpxAX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HlpmpxAX" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5718lRI6024687 for ; Fri, 1 Aug 2025 09:35:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FTE8Tu8b1amkpQAae9PG0gDF8STmsmRt79+CR3F5UKg=; b=HlpmpxAXKwE/hM1u Vvr45SBbJSsOe208L9fPmhGEtdQ7zzm59J2Sp07WRhzO7rBeZaXdlrIwqqYH+6nn 7a5yeh6hOwgvw1qKBjhmTekG2uiDf9OrPOetBdNKvf2aD5X31PAR031EJXZ0ftte RiHFgnWyPtj6oI0O0dA6yOLjurfsNDi3LOe4jvlHCjpbLkit+g29lMYwNoEyNZXK JxPPajHIsUlwQCMSX0jrcQBeYKhG4BUrfNO/UATglbrCWS3fYvM6/SrPhUahdauM Mno8z7oA/gKNWhCB1NsYffFz4V/47S2lWdD69jVy4nlMbhIrJMCgjQXRuJGCMWPx 4l/vfQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48887g3ree-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 01 Aug 2025 09:35:40 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b423dcff27aso666461a12.0 for ; Fri, 01 Aug 2025 02:35:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754040939; x=1754645739; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FTE8Tu8b1amkpQAae9PG0gDF8STmsmRt79+CR3F5UKg=; b=EdqvhmblPW+uUhMuu8gTD8gJzpq07EMzX3KgN62P6HwjifnAfNW1FuLCAXJwT7YTSy qD3LDoEt/WO0nbha5pUARCIok5fBIae0h/XSAFp4XjW/4E6N3dr0pXCn749QDfrIClFG iHtzRADPklrhV9ka78NsiepxcDyHMDillZYvO6dBhseI+puaN3fNwDL6JN7i3foHj2tu 0LPHWpTl1RsHty9GwyeYogwZRBEIAJEsv1M16tAq/TlflbUI2yHC3OZfa4gSf+22q/F+ DH9U6ECs2ULfHI/1YeX26yJwgqt6uBnyjbmIOWaDc9i9ysx7pjARi12+EweGXiWSPfNE dvOQ== X-Forwarded-Encrypted: i=1; AJvYcCUl0lD+3LkWjoczyPLgLSWmr2X0kI89WuBOpEIlNJLCr+oziTUswm1sl/AZ0TzkBlTjoERbUyUat2uB2Vk=@vger.kernel.org X-Gm-Message-State: AOJu0YzvVx8T4rNlKmBmUMotVLo5dUs+sxYJ9rPz9MRu5/W1ytLWdEZw 4vynVqg8g/nS68h9FZq94hv8V3dxWlFWCQV/qHVImKjSenTFnMlMDN5VI2NfUern0uEUCLHJoin wzXNNEhAWkwGuGCNrCozQOElPQ4/PRuaJtm3VgZSOxUaOekxbGBt6F12qUyQXhhDD83E= X-Gm-Gg: ASbGncvcz3X0J3iq44lYSfEpQ2dNdoRGnkSvev3jdEPzVNilKpM2rcf7yNbxxhf9W6o dwIR2f1SusvH5bD1temARjo3fxb1sRNeIUXvq3guFCtR/RbuqCjIFcwJju+esGdLvaH30/M6q8q XT2j6cxxaHLYREPJrzVp8oS+pWY7iFWPV77/5K8jyO6z+P7/7EYDw/PVI0WaZsOCVZrjySeorUG XzjrsLi8ZW7O9Otmb531CmeXjtuCfuc8gHXAXjqeTQjRYT2DHICYaT8HyeiADdeIlGP4yXof0fL c4yPSVpgdiPkQyURp+noTFQI0NxUnwPfUBoX8g9w+GX/SyIbg7ZzB/43OM+UagB/XPjzeTK7Mg= = X-Received: by 2002:a17:903:22d0:b0:240:1850:cb18 with SMTP id d9443c01a7336-24096bcc7a9mr150191705ad.53.1754040939353; Fri, 01 Aug 2025 02:35:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbZdxiptvpigi7eLXKhWCFOZQbYGfK+h+OEAOD3ELNf+6iC45wP9TbESkBH3N8d372w+JIbg== X-Received: by 2002:a17:903:22d0:b0:240:1850:cb18 with SMTP id d9443c01a7336-24096bcc7a9mr150191225ad.53.1754040938913; Fri, 01 Aug 2025 02:35:38 -0700 (PDT) Received: from [10.218.42.132] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3207ebc3266sm4196042a91.13.2025.08.01.02.35.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Aug 2025 02:35:38 -0700 (PDT) Message-ID: <7f1393ab-5ae2-428a-92f8-3c8a5df02058@oss.qualcomm.com> Date: Fri, 1 Aug 2025 15:05:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] opp: Add bw_factor support to adjust bandwidth dynamically To: Viresh Kumar Cc: Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20250717-opp_pcie-v1-0-dde6f452571b@oss.qualcomm.com> <0dfe9025-de00-4ec2-b6ca-5ef8d9414301@oss.qualcomm.com> <20250801072845.ppxka4ry4dtn6j3m@vireshk-i7> <7bac637b-9483-4341-91c0-e31d5c2f0ea3@oss.qualcomm.com> <20250801085628.7gdqycsggnqxdr67@vireshk-i7> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: <20250801085628.7gdqycsggnqxdr67@vireshk-i7> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vdn3PEp9 c=1 sm=1 tr=0 ts=688c8a6c cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=lAXUmMm_w8SOBygwRYEA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: UFIfhKGPFZ16eH3fzA8gMpSF5JVwUHzh X-Proofpoint-GUID: UFIfhKGPFZ16eH3fzA8gMpSF5JVwUHzh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODAxMDA2OSBTYWx0ZWRfXzvV+zwGK9cWp rxg1KH34phk8AiP6CyXi3XJ3olOWAWjYCIWE6XmX4oAEhyjPmj45BlWiLL5J8+PhYYrY3eQZQ4f eX5eSKmLM0/XvxoNmMYImkIOakWl3YTL6S4lOuXDf75OLFJL65Z04V8Lv044f841RUOjtezgbXF IHnoa1ATJ8C28yDswD9QeMdla0c9OaSB2pAScKGnzdcW+S05tDrNjtgmfa48tJUIzPFljWHRCq1 SrDh+sbCFDUMcuvxbfsAqeg8BG/8p8yKLp5if9Zjtv2SDjZq1vfO/KwzMzJNx0u0cO9aa6s7QNS 1rPDMj67qW7kAo9yFzlJr2FBDMfUXogT6KjRMTN/4X3wJslwUHuHi8zU9HE2JqusAaVjT+KYn8d sHzoqC9yY7mtgzL8tA9Z3cBrt1pCFrFlErzL2Vk1cBXPej9LpuOsdK1mvIr2lLlYyKONCKtl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-01_03,2025-07-31_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 mlxlogscore=999 spamscore=0 phishscore=0 bulkscore=0 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2508010069 On 8/1/2025 2:26 PM, Viresh Kumar wrote: > On 01-08-25, 13:58, Krishna Chaitanya Chundru wrote: >> When ever PCIe link speed/width changes we need to update the OPP votes, >> If we use named properties approach we might not be able to change it >> dynamically without removing the OPP table first. For that reason only >> we haven't used that approach. > > I am not sure I understand it fully. I thought this was a one time configuration > you were required to do at boot time based on platform's configuration. > I am not fully familiar with OPP here. > If you need to change the performance at runtime, won't you switch to a > different OPP ? > yes we do set different OPP when we change it. Currently we are fetching the OPP based on the frequency and setting that OPP using dev_pm_opp_set_opp(). As you are suggesting to use dev_pm_opp_set_prop_name() here. This what I understood First set prop name using dev_pm_opp_set_prop_name then set opp dev_pm_opp_set_opp() if you want to change above one we need to first clear using dev_pm_opp_put_prop_name() then again call dev_pm_opp_set_prop_name & dev_pm_opp_set_opp() I was in a impression that once you call dev_pm_opp_put_prop_name() the previous votes will be removed. we don't want that to happen. if this is not correct we can use this approach. If this is not correct assumption can you point me any reference to this I was not able to find any reference on this. - Krishna Chaitanya. > I don't have much knowledge of how PCIe works, maybe that's why the confusion. >