From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F3C34AAEA for ; Mon, 16 Mar 2026 06:22:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773642133; cv=none; b=UTc0FLxsuEcOKvcKLLJS8U/tYN9f46gIfTKZZOjONdrvrgEeCG/eMWSaR7JGDfLwn3scX3NXyytaxT+BGen7+R3yRresQ9wkoPMOaZgkq9g9c+x20OnC8LKIcE408lFbgcpPXyDL5PGwNvnLn4k7vTq6xjaWRFGoZQ2/5agerkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773642133; c=relaxed/simple; bh=CkQoYU/3FLq5DhFAEBY9fWpZoWx/jSQ2m/aJQfoJn9w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MYaDvt6UOo/VbLAfiSLcqT3qrtjKqKQiNCIfCPsCX8E0AnFw9WaMF8sAaf+5AwJELDqPrQy4P4t1GMmqDvmL1zKO4CLmMeLnB0a/c4ymWU40yOyIfoUM8bBg81iabcpVf3RIBqwQcUw0iNtWuQ+jKYFMaD8SXrxnmf3e2JY4PhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ldxslXR0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SAUnADRI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ldxslXR0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SAUnADRI" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G64k4t538960 for ; Mon, 16 Mar 2026 06:22:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I3VMQi4qVPweJ+FZbd9d/UOKcE9j5sX+9lxTGG+iwKs=; b=ldxslXR04sKoDz5C OaDPXYFfdh+JK/57bOMG3yJ8rnd4slqvBh/MDDYenpdQEO6GpQoj+umQibEOA101 ZWbB4ECpv4KWW/utuPBMRAnf+0zcOw6HSCjKiFSGfL9Cqp6IdnWgvMoVwQm0pnIZ PxuDeJjFLhtzzRg6Umi8tI5WGr9y3pWunE9dxIz1JsEflgnY2s2I7a4oOobYUgBp 1ZIH6pKoDbyj0Lt+Nfrt1/oN1yF00j2DozdFQBCdDC+VKtt+daw1EzP4wOihFZtC jy25STlu2JjHkrqyVIJZAnn7sYyYugr5UwX2K+cE/zDcOOxZwwic8PSbqoGkzuoa 0tER/g== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvyy5mbq8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 06:22:10 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b62da7602a0so2962831a12.2 for ; Sun, 15 Mar 2026 23:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773642129; x=1774246929; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I3VMQi4qVPweJ+FZbd9d/UOKcE9j5sX+9lxTGG+iwKs=; b=SAUnADRIIKYN+6ei8+JmHUM+Dy0+Glibgb17W4m8QlImd0WPGtnWiuK3VAa0O/EoIi s/6IcHOQ/BuzMPdfNIjhMNVg6C2qLt72R/OivK0WYd/btCwf+vHnswhlTaT6JCORwLzv 6ZUDkpEqWPKgBS8AvZfiByZRYp82ij20RJDMe7oLxj88vWfieOu/uikj8LsqMrKdlWxN 1YSZ3Jkw3rUqBwxZyD498io1lXmJ5yokdh7/ZdI7cck0JziEGRI/s3GC+etZ8/7CpR0Y kqzI8K9Jhgjr75+zvx1zIKrFTbdTTDSCKN4LpILjAvyp/GJwpbE8UHvPAZtd3ui3aNcy qSzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773642129; x=1774246929; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I3VMQi4qVPweJ+FZbd9d/UOKcE9j5sX+9lxTGG+iwKs=; b=JsthjsI5g/BtTPVh0RNTsa0v054cm+Yi4VV/FdNgPFfu5Q8oeobqDBL0wF9VCZNg50 ce4iMHzZSGrEujp6A/J8LaCu0ltI9D/sAZJn3ZjjnOSb0l9POUuRUne/cXbEnggximG6 SflefIR+/Gm1RRCplj3uZFJiNVHMgXXCtLaMQ2b8EXc35RI4Aos7XRzKegUIYOmmoy4d 6mifdAlIOx4E7YVmw1IWsYRLjXhoTpJ1oUK+ISvdqJGk2UL4JfN+KtavLjc5VWYYt7qU MVDCH3JSBZrSOuLpphA3acqKzAotLTBQ6Yk75Q071fGRUn76VKuQjH7aKe+k0EKWjt8x cw7A== X-Forwarded-Encrypted: i=1; AJvYcCX32rJQBb+I8ntAyo04I1HzZzvOUigfOPBvqaXcTxY0rXr5IuaWaHxAd38zpbkWftBy8BLkr2LAO33kTj8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx58Va0fkbf/EDrwBUT5uJ7YNbCVtiutpBlCwvNxbrXqju6p5J4 r/Wr5WTwiITL8w8Hy/Pi2AbmXRB/vpB2TryBAiq2cMb12B/sMN84WnKR7gurwV5a5hQEJXcFTWh T+oj2ZCn14nr6zcEBzFgxAtUQrLKGTO4I5HZ8J5vvJFyAsG0x24nBCwASceTIoFCiB+E= X-Gm-Gg: ATEYQzyI8pGmzLnpnvZtr4V0xp3URKITVG+ONPGOyVJ1hGWO/AJKCUwNpSbcBhXIyUy K8vJjfwgltSgiWkW7tgeUiwWTLUxmWYAQnYuQn70qba4xRzx1L6XE0lD+15klsqSjyqQrO3TQ2L rfbs/b5bMC/+8jPMJkzM9mzTPBiDgJGXIV2ZR1qiJwijg6OXUKv2iGeosy/4doI6Npr01QBg1FG Ckr3LdQ/M7dn9e6ZQCescOIwU7ueA2jvJAyNHMTSvE0qZrfGQ9+BuCZ1RfJm5MsNZtyhuJkUuQU oMA7D9yztTzZ6Wh8EEXNtdzYoLOeoyBPMOncd/TVNym1fBy4cueYTk+jIxvYHc99JO3bJFIfZTH /zpvCn+C5YQv6uZNFBNrMrij4gyj/g9FP8XiTXj8EVD50T8WR X-Received: by 2002:a05:6a20:9189:b0:398:9ae9:70dd with SMTP id adf61e73a8af0-398ece25b27mr11086918637.68.1773642129480; Sun, 15 Mar 2026 23:22:09 -0700 (PDT) X-Received: by 2002:a05:6a20:9189:b0:398:9ae9:70dd with SMTP id adf61e73a8af0-398ece25b27mr11086892637.68.1773642129008; Sun, 15 Mar 2026 23:22:09 -0700 (PDT) Received: from [10.218.25.31] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73eb9966d9sm7860787a12.11.2026.03.15.23.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Mar 2026 23:22:08 -0700 (PDT) Message-ID: <7f165169-427b-4f5b-9bee-bb227be23d82@oss.qualcomm.com> Date: Mon, 16 Mar 2026 11:52:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: iris: add new rate control type MBR for encoder To: Konrad Dybcio , Mauro Carvalho Chehab , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260213-b4-add_sc7280_mbr-v1-0-e8d95b4e4809@oss.qualcomm.com> <20260213-b4-add_sc7280_mbr-v1-2-e8d95b4e4809@oss.qualcomm.com> <84895cad-9f1a-4e51-8e43-faf30b4bdabb@oss.qualcomm.com> Content-Language: en-US From: Sachin Kumar Garg In-Reply-To: <84895cad-9f1a-4e51-8e43-faf30b4bdabb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: rLDlsnX8UX0eb1yjayWJB1-qRqt0dnP1 X-Authority-Analysis: v=2.4 cv=QOxlhwLL c=1 sm=1 tr=0 ts=69b7a192 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=mOGHD44pklf7LAQ1MEsA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-ORIG-GUID: rLDlsnX8UX0eb1yjayWJB1-qRqt0dnP1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA0NiBTYWx0ZWRfXzrvOqLtgvPD0 epX5UCDHwB3RZRUGzvzQ3q9QrtTq/5SS8Gt/lC+7Ziffl6Itmm0SXEg8ukh0Pcm6jp9I8S8j07a AvqobxT0dJNE9ojn1hW5T041Vk5b+g68s9h1rf9yZuIm3VEpNCilhsUNA97sjasKolQ3xrxTpyJ 3fU6o9W2nyLr7rqSnU+DlvZjptB03sg+tJu7pub8ky/paRVc/ihmi+iHnaQknMTkOUW2Y+yJKp5 mQ5Pr3C829+41m6LMxeGziJYs5ay2a/ULUu5Ht5SvHVXC0DKkcDXLGJ0GIzpofZTTkHbr5fs1H6 +ErWZCr25qeexNhUzcoYPZUUT4OLpdAzAL1rjMyHClhcQ7x1kgvyuDqHKmOdtC9ms30kdPBcZQG iyJCc/giMRQmhhYnrq9Zw6TLFteogM373z1TlaTkwXQy30Re2FJRqKpKn2hVvOCU3BsqBZHAkZF YYbEoV+ViBK6GeEQ56Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160046 On 2/13/2026 3:24 PM, Konrad Dybcio wrote: > On 2/13/26 7:04 AM, Sachin Kumar Garg wrote: >> Introduce V4L2_MPEG_VIDEO_BITRATE_MODE_MBR rate control to Encoder. >> Encoder will choose appropriate quantization parameter and >> do the smart bit allocation to set the frame maximum bitrate >> level as per the Bitrate value configured. >> --- >> drivers/media/platform/qcom/iris/iris_ctrls.c | 2 + >> .../platform/qcom/iris/iris_hfi_gen1_defines.h | 1 + >> .../media/platform/qcom/iris/iris_platform_gen1.c | 9 +- >> .../platform/qcom/iris/iris_platform_sc7280.h | 202 +++++++++++++++++++++ > > Is this really only available on 7280? > > Konrad Yes Konrad, in this series we enable V4L2_MPEG_VIDEO_BITRATE_MODE_MBR only for SC7280 because currently, we have added the support only for low tier chipset. MBR rate control aims to improve the compression efficiency of encoder for static and low motion scenes for extremely low bitrate use-case. Thanks, Sachin