From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DB9A3290C2 for ; Fri, 12 Jun 2026 13:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781272385; cv=none; b=BbAPDgBjs8bE6/Wo1MUqJ38ksV49VKX1FYFnrJzy3W0Ov5xijUbXtce6agwU/agi+oCz+MPYiJ5IRM/6yokI2ScCuln+0+xhtgwIrdvrz9fg16F5qoD5rn8We1LXE5ijEDHRcqlVHBgAxgkX/y7P6OuFSrz+9NUDoECEbw/6iGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781272385; c=relaxed/simple; bh=rXCM27CI+q3bTwAWRJkzblUZ2cY/BDik2t113jUneK8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GWhzg+L6WX3GMa+bmagHV4yXMvgOEISRbH/luequ9o+h5VREzIG994nUCnyWnYCrI0QVXDGCUgrka40/hahMovrmGU0tnUBj23OBKm6bocmILLcFZLIu3a4zikuVY5AYy+4aJAjOnPGHcYvImlJtC+NKtoMaIyydqgHG/NdkT1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QkYtDQQw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K/M5Br+P; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QkYtDQQw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K/M5Br+P" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65CCjHnA3760870 for ; Fri, 12 Jun 2026 13:53:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xTnfVI4gotUQ2bkxP6pmXcdIqm6lxSQhArEpxlHE3ZI=; b=QkYtDQQw/ZsdVWqT HYHVx7VdGUQKUBiI6+HBXseYRkL7tJXUPoHCYhGUDJC6RFYsokkh8F+TCMzNYSN1 kXFu58eDSMCL6mILiFp1jQ2+hzZ0fP2Jh3H0Tl/QDoeDpjvC0ZM7ewPlF7P429Fp G7t2Z+lyDbJHPLf12tH42slt2ijXFFuc/mEkB3G9FhnSzKOjx/yWNijTvqxbRr9Z sEOtP7Jtwa6Ot9LJMpqhGARPg/6kkloYY/ODKRKtJ+Q0cka2hvTiNPWdcYmwcnrp Dac9R8Pju8OL2nMyyK0A15fX6y1pRMMjpqY0mBHmP/IMZ27LnI6S+pnakTkTf+x5 l5U0LA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4er29uu5cb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Jun 2026 13:53:03 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2c2b64850easo19813435ad.1 for ; Fri, 12 Jun 2026 06:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781272382; x=1781877182; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xTnfVI4gotUQ2bkxP6pmXcdIqm6lxSQhArEpxlHE3ZI=; b=K/M5Br+PbxxDAQeSR2ELdnqVdHLnevS34SufeQTDpB1rB5c28E+iXbQ2WO7NwdVTwA 2rEla8Wjk4GnXILyaUFz3O/e2GrwV7itcZjBXOcqd64tU4jVwEFFVoah1EcA8tp3lIjS asL9cr0rxASsjZnpx9um/Lzp4hGDAryV5Z6DGQ3Amwk+IVgDD/XctyW87CNaW+65AY7W BYbSCgX6/yR22Jk2MVD20dWt+SDYSrlvSREPBRVtwEe6i9J7oELCBqaDTlqzY5tivAib m1gnB+GxyJkQsq4ULASXOVZqeHrd+Lh5w8/x63tSgPaxPhqEehnNFhVIz+RMWsMUxLVP qf7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781272382; x=1781877182; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xTnfVI4gotUQ2bkxP6pmXcdIqm6lxSQhArEpxlHE3ZI=; b=NjvB0ByPw0boPyzTzsP4ygL3y6+ZOo3O0x/zVM1s0xhkgwmg6L3RoRcRlN9dCbfDrV 5fidKJu8YPiwcXGe8w4i3V8IN7poSEg3JpkdZe5hWHO8fDU/r6UCwefnm39YQZPcUcpA YHc6TkwCYT3e5Xc/A3EcnBw2BO4eLvSjlxgimItNCJ0vibYi7lrQO4BT6485oJYol+k6 ic8QsewQtpNYriOYZKsGjSpR0xL06ZVOJG4YaWVGFa6M4ukrNnzjsz3daiYngyhATD35 l8IZkRLFDzaywjyax7sJHLzqxWOzCjWsq48/gF0mVCASltzUXzrG3HyGDfwDjbXfMfvA OVYg== X-Forwarded-Encrypted: i=1; AFNElJ/iZ0RqnkEJDuCd9fzSeHirRa2tBG/sGtfsc3LcBzHpHDHv6+kdoWoZ3M2E3sroUqieGTqW5o+cTmmtEW0=@vger.kernel.org X-Gm-Message-State: AOJu0YygwCnxdlt182SRU5I9lKcebwd5gbiOYyfgIQxHWx55Jl23OyCs eNv8t9gaJF/tByvYOXGCrp0U61BwHrHyd7hTdLnNP4mW7AkiqXgFGf7EsQr1OHbEf6EGnp7l3GF on9bXOOskSQDlM7vBsg2PriK1M78aiHqA2GJnurQ44joAou3xkX7BLs7UAqjAuQlOkaM= X-Gm-Gg: Acq92OH42KtwjfXBFUhTJ6hxjCbysgms6IUOTw8npZbIiHFBUV9j3xvHdo7jdeoJn9Q Gpef7JMLsa1y7y1jjdqfEAehksCIiBXPzf5Xn2nDMupNprQPNHDuukERUGq0JKRbeQ6GMYFP+Hw ssoRsjPXyGCglXbwK04JGgAyCtYPRdGmi8IczqfS94QhA0QzQl+tpTxCpNtxMMD3y/QBo8Qk7aO wxRglDk8btHHLnfNkUlG2s53oMTpeu+7jQKQGiZDW4i48fefDeTSvaXyF7JRcIgQubd1IuJByjA PSBu+gACOLsjKXTyjgQsnfVCmsi01X8jkWAwt4scfVA1lic+pejKtkVCk2CtIH9WLadCgEfUeOV ugHO+3jsrgINrsIC3rdtV4ibTZOtf+0hmTAlNwvBPB8Z2XebYxYmw X-Received: by 2002:a17:902:fc8e:b0:2c2:be43:39bc with SMTP id d9443c01a7336-2c41198107bmr34271435ad.22.1781272382183; Fri, 12 Jun 2026 06:53:02 -0700 (PDT) X-Received: by 2002:a17:902:fc8e:b0:2c2:be43:39bc with SMTP id d9443c01a7336-2c41198107bmr34270905ad.22.1781272381504; Fri, 12 Jun 2026 06:53:01 -0700 (PDT) Received: from [192.168.1.13] ([106.222.231.34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c42fbb4134sm19641415ad.30.2026.06.12.06.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 06:53:00 -0700 (PDT) Message-ID: <7f1e46fb-15e3-4638-9930-8abc1dd5a778@oss.qualcomm.com> Date: Fri, 12 Jun 2026 19:22:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties To: Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260609-qmi-tmd-v3-0-291a2ff4c634@oss.qualcomm.com> <20260609-qmi-tmd-v3-1-291a2ff4c634@oss.qualcomm.com> <20260610-ocelot-of-stimulating-excellence-bcb0fe@quoll> <03d863ee-2caa-41f2-94b5-7332fc930b42@oss.qualcomm.com> Content-Language: en-US From: Gaurav Kohli In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjEyMDEyNyBTYWx0ZWRfX14H/HmGJ6kfD LBuOhsW6OSWyOklbkCnHYLPT635gHaye51bU+ylKhPNxyh3uZyaKdsvmyq89cUACccqt0ZZY2Nf 2dNTy57i7crLPn6YYGQwaj7pLjGwPHA= X-Proofpoint-GUID: 87EGxoYmdmew5TVt8EUMxQKOOuf6odYq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjEyMDEyNyBTYWx0ZWRfXzQSTHhM5Qghw ZW5XFTqjqKYHlJDzBj5iDsjqktAKiDqAgk1TChWMHKb1UfvXYTlANV8TTiPAXkZzt7SNtRzXgOj nDVoGvJBlkAlUjHbYMYBZ+LJmT6MmuurmChoMvAKtxUlfTsEWGHfFIW2eQc/pKNy7O6U7oQacOk kJ8xxhlEbA2moVULMGuJzFOg2h6Zyy8UbyadORKMAQOFmi2a4zNpOy0EbFCfASAnMBRkEZyD3Yo 0ZD576MO+bt3s9zSuilLZu5+f8c3WIUztQvK9m2n4Q2RRtfmSeqSHMuNg+K4AxZWbQaHQbDPWaM pVc28L+ullxTXAhYKaqscKWb5gGZPEo5hnO69xfrehZAQjRIyOB1HVawW7tD/BDpqK3xR9CzCiU STrJOj04gpn1K5RddxR+SfU0VFCQU4SGyNNfzc6F6NVUsSkfD5O+UW4B3PlTYnROmWqndQsWfQ5 5IG7gFDk9TJZS5PocdQ== X-Authority-Analysis: v=2.4 cv=DppmPm/+ c=1 sm=1 tr=0 ts=6a2c0f3f cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=JaHktJlP2QtFIg7UHuVw+g==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=mCNVnkFJZU-R2xYHr1YA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: 87EGxoYmdmew5TVt8EUMxQKOOuf6odYq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-12_01,2026-06-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606120127 On 6/11/2026 5:53 PM, Krzysztof Kozlowski wrote: > On 11/06/2026 13:12, Gaurav Kohli wrote: >>> Why? And where is this generic property defined? You cannot just >>> sprinkle generic properties in random bindings. >>> >> >> Ack, will add why part. >> These names are matched with the thermal mitigation device identifiers >> populated by remote firmware over QMI and define mitigation devices are >> exposed as cooling devices. > > No, -names correspond to values passed via DT, not some remote firmware. > The remote firmware should give you interface which is explicit and does > not need such properties. thanks Krzysztof for review, We need tmd-names because of following reasons: Following Daniel's series [1], the thermal framework supports mapping multiple cooling devices per remoteproc/device via indexed cooling-cells. 1) The thermal framework's cooling-maps reference cooling devices by index (for #cooling-cells = <3>). Without tmd-names, there's no way to know which index corresponds to which TMD, as firmware may return tmd-names in any order. below are the changes post new thermal mapping changes: DT: tmd-names = "cdsp_sw", "xyz"; Firmware: ["cdsp_sw", "xyz1", "xyz2",] Driver registers: Only "cdsp_sw" (index 0) and "xyz" (index 1) This allows cooling-maps like below: cooling-device = <&remoteproc 0 ...> // "cdsp_sw" cooling-device = <&remoteproc 1 ...> // "xyz" 2) Not all firmware-provided TMDs should be exposed as cooling devices. The tmd-names property acts as a filter, allowing board-specific DT to select only the relevant TMDs for that platform. [1] https://lore.kernel.org/all/20260526140802.1059293-12-daniel.lezcano@oss.qualcomm.com/ > >> >> Without tmd-names in DT, it is unclear which index corresponds to which >> binding. With #cooling-cells, tmd-names in DT provides an explicit >> name-to-index mapping. Please suggest. > > I don't get what is the index here. Index of what? > > > Best regards, > Krzysztof