From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758448AbdJMP2L (ORCPT ); Fri, 13 Oct 2017 11:28:11 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:54962 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756659AbdJMP2I (ORCPT ); Fri, 13 Oct 2017 11:28:08 -0400 X-Google-Smtp-Source: ABhQp+Tq4TI+uZRVaJ5qx+ERc/VKqlaFADM97e8WWxJqY5rcrvbxQbHi4ZjVkmDA/LlAjgFt6YtKiw== Reply-To: christian.koenig@amd.com Subject: Re: tracing, dma-buf: Remove unused trace event dma_fence_annotate_wait_on To: Steven Rostedt , LKML Cc: Daniel Vetter , Andrew Morton , dri-devel@lists.freedesktop.org References: <20171013100625.6c820059@gandalf.local.home> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <7f210dc3-735e-c57e-d55a-995f950a7659@gmail.com> Date: Fri, 13 Oct 2017 17:27:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171013100625.6c820059@gandalf.local.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 13.10.2017 um 16:06 schrieb Steven Rostedt: > From: Steven Rostedt (VMware) > > Commit e941759c74 ("fence: dma-buf cross-device synchronization") added > trace event fence_annotate_wait_on, but never used it. It was renamed > to dma_fence_annotate_wait_on by commit f54d186700 ("dma-buf: Rename > struct fence to dma_fence") but still not used. As defined trace events > have data structures and functions created for them, it is a waste of > memory if they are not used. Remove the unused trace event. > > Signed-off-by: Steven Rostedt (VMware) Reviewed-by: Christian König > --- > Index: linux-trace.git/drivers/dma-buf/dma-fence.c > =================================================================== > --- linux-trace.git.orig/drivers/dma-buf/dma-fence.c > +++ linux-trace.git/drivers/dma-buf/dma-fence.c > @@ -27,7 +27,6 @@ > #define CREATE_TRACE_POINTS > #include > > -EXPORT_TRACEPOINT_SYMBOL(dma_fence_annotate_wait_on); > EXPORT_TRACEPOINT_SYMBOL(dma_fence_emit); > EXPORT_TRACEPOINT_SYMBOL(dma_fence_enable_signal); > > Index: linux-trace.git/include/trace/events/dma_fence.h > =================================================================== > --- linux-trace.git.orig/include/trace/events/dma_fence.h > +++ linux-trace.git/include/trace/events/dma_fence.h > @@ -8,46 +8,6 @@ > > struct dma_fence; > > -TRACE_EVENT(dma_fence_annotate_wait_on, > - > - /* fence: the fence waiting on f1, f1: the fence to be waited on. */ > - TP_PROTO(struct dma_fence *fence, struct dma_fence *f1), > - > - TP_ARGS(fence, f1), > - > - TP_STRUCT__entry( > - __string(driver, fence->ops->get_driver_name(fence)) > - __string(timeline, fence->ops->get_timeline_name(fence)) > - __field(unsigned int, context) > - __field(unsigned int, seqno) > - > - __string(waiting_driver, f1->ops->get_driver_name(f1)) > - __string(waiting_timeline, f1->ops->get_timeline_name(f1)) > - __field(unsigned int, waiting_context) > - __field(unsigned int, waiting_seqno) > - ), > - > - TP_fast_assign( > - __assign_str(driver, fence->ops->get_driver_name(fence)) > - __assign_str(timeline, fence->ops->get_timeline_name(fence)) > - __entry->context = fence->context; > - __entry->seqno = fence->seqno; > - > - __assign_str(waiting_driver, f1->ops->get_driver_name(f1)) > - __assign_str(waiting_timeline, f1->ops->get_timeline_name(f1)) > - __entry->waiting_context = f1->context; > - __entry->waiting_seqno = f1->seqno; > - > - ), > - > - TP_printk("driver=%s timeline=%s context=%u seqno=%u " \ > - "waits on driver=%s timeline=%s context=%u seqno=%u", > - __get_str(driver), __get_str(timeline), __entry->context, > - __entry->seqno, > - __get_str(waiting_driver), __get_str(waiting_timeline), > - __entry->waiting_context, __entry->waiting_seqno) > -); > - > DECLARE_EVENT_CLASS(dma_fence, > > TP_PROTO(struct dma_fence *fence), > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel