From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935078AbdCVRaO (ORCPT ); Wed, 22 Mar 2017 13:30:14 -0400 Received: from mail-dm3nam03on0043.outbound.protection.outlook.com ([104.47.41.43]:41247 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934790AbdCVRaI (ORCPT ); Wed, 22 Mar 2017 13:30:08 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; From: Leonard Crestez To: Mark Brown , Liam Girdwood , Viresh Kumar , "Rafael J. Wysocki" , Shawn Guo , Sascha Hauer CC: Leonard Crestez , Robin Gong , Anson Huang , Irina Tirdea , Rob Herring , Mark Rutland , Fabio Estevam , Octavian Purdila , , , , Subject: [RFC 2/8] cpufreq: imx6q: Fix handling EPROBE_DEFER from regulator Date: Wed, 22 Mar 2017 18:53:04 +0200 Message-ID: <7f2618363d43b30db29f5f8ae822df413392f99d.1490199005.git.leonard.crestez@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: X-EOPAttributedMessage: 0 X-Matching-Connectors: 131346752150825864;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39400400002)(39410400002)(39380400002)(39850400002)(39450400003)(39860400002)(39840400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(9170700003)(104016004)(48376002)(4326008)(36756003)(38730400002)(7416002)(8656002)(118296001)(50226002)(39060400002)(2950100002)(5003940100001)(86362001)(305945005)(6666003)(356003)(5660300001)(53936002)(8936002)(50466002)(85426001)(54906002)(33646002)(105606002)(189998001)(2906002)(106466001)(8676002)(81166006)(50986999)(76176999)(77096006)(47776003)(32563001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB553;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;MX:1;A:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD035;1:C3vMj0cMBZJqJHy/aPnwyb95QjBjWY3FeU7ZP+CfyACSmygS1xxg5grm04HCsvBu0mQZ/gqPgWwZnWf2mkjBsKndEPJ0+3KMouVdi75yWM9ZTi6peX0ZrABwPxD8GQdtrjfwVZzgjdqK7eLtMq7FaGggHKS9GY7RQvzzhECxLqrAtOHKmAN4u6zRu9cgYGiP9HW7GUI1OyGI2DxJfcLGqnuJXslOVqiN8yd1nWQdsSF7QaQydG81iocg0/GmeFPScYSuoSRaihHIWt3FNvG11TDi8xNPx3OS6CvYDJVbqO8q71XfBkCZ86V8aI865NZFaFLfpp6UHxSxf1m1Tkcm/cb4ejmXwp7OevpExKJrNHunCS3YkHS9+J/1EMvYF5RMRGpzZbcMCdlTkQIuF3O2QfouBEGBWMIzlq5B5EmHF5/cL3dwj7MxRA/aHsi3nM5Kybxuzerk53hV86uu3EO6CKtQbddgkQq9cTbJEd214CyAerdd+Xb7FT2GAe63JMJgOBPXyFq28Lde3gsxrzepM37CLRmfKVPUenEOtFdwc5x/NDt4qCmBw4V6YGVDYOO3LDHER9iIlWse8t1l3TUtNiIwGpKXfeHuHDtZepz2xk2TaUajbGDz54fBVZfY27SC MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: c5c02e80-da64-4b7f-8a27-08d47143face X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BY2PR03MB553; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB553;3:MMes8jyC4ud6cZWttT7XPxf1bIuyY4f9A+AZ4NAmiOW3wQQMxKKz/UiVzlWLGnRjGIPj5c/O0iR1FmYuD6gBez5VbubEaqRQaCdX8d+JyQJmk8VQEAFnO4i1O9OgKkT08qZ/aFtC2iqIDD3mbFx6bePY6jKtYe/3zbg0R/zIwytmimhoBoPk8ZLIGBWNQx+cZSi95oMe4c3cbXA3+9O5UNz9yfJLSHKOEReHPV0yyISdD560smHWECgEM1dwfX1R4mxWjmc/MrkXWikwxAs8BugHMPXFts8ODFHRv8iUBFbZLYnr2PaC3D0BsFSqyXxLXbD1BONKqsplEmfRUF1U1rxmDwQwCLLTMfGGhJ11ikFwzXrwpMoAIMjV+2RoAPid;25:oRgU9tDPgmIxNVX2eDkhSb4lFGetOIr0i8yE0+zKg60tMHcV/AsC7tNDbTnwHM6kIR2vbX7N/WLKUvR7WS6KB4Hm9T2VEJlVc7Eldlw5WT83l3w8b7Ay90jUNcsiqyH0R3JN5IvPq817E2L3ZsEs0SKVenqe2ENAlxULiPbNsQpkND0n+pXRCKl3yTAaf1lFB2JS747YgfTDwvAZLEfDOY4IxVez00eGORvNIItlEv0AYAN5n9yozVQ8SOdKPGUWwcGFR6ZFtIvZacH7n0TwHRHkaPYJ44mkKxDVvqkwiRX1Qh9gms0pov8Ot0+7S2Yc4IRliHZV6tO7FOWCih7bxCC8dmgJRDRY74S6Jr0h9Wjipr1kkyx3t5E+Pm9S6TN2Ak2MCfLIY3E5rXPpmyX2dvxa30pMC3WdCKHliJzsighHrzsyQc7UUV9B5Xmm72EKG1zFgo+8yBQoToaahmYnOw== X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB553;31:MfpgFORQmZA7LBN/X1GIGcw7c1RAmSHo9qxuwOw74g/Af4o69XPXy9s0R/hB0Yc2N2Cu4cZcSIsdm6lP0tf1TPNx+c8RnCnVH9VU/lvTY+596UMTW3SeV6Db/uS+61QsjS57Va7XOWP1Aea2o9Rkoggf97GLABUuHuh1k7j7UeAmiVmC4AqbIU0+dzqm9hpFBAB4xfW89i+Frni7JBDX0AuSIti6yTj28yqU8xLcwWWiTOE8+xOK2766Lpf9BDCg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095060)(601004)(2401047)(13017025)(13018025)(13024025)(13023025)(8121501046)(5005006)(13015025)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123563025)(20161123565025)(20161123556025)(20161123559025);SRVR:BY2PR03MB553;BCL:0;PCL:0;RULEID:(400006);SRVR:BY2PR03MB553; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB553;4:6wWWTr/A7WV4UTAjbKkGGs6DVFcTxKAt2yxSzIGFl3z/AEst4PTM2joaQuXg6P0smaaXWsFqz7M3EbtOkSU6BUuvbdHhG/sk6FUtgXFGntBJW0jW3INO5jJikuT6H2tgkp+OzC68emQablBJNFO0nCa54rEZVk6/WJ9dNjyLT2mR9Zp2zoJHp4K4wKWC2ITPbOC6y+i4ieudheCBho/AdQJF1VjLLCzntgX6MHz9gbw8CD8vL6CfETURuZ6nQn1oeJ/Kv7x7ekMuifz6hvqyfFmttVtua7duHZPrZi8Ml6oBeGxP6cltwWNbQPr5/B77LEYgCXz7v6SRgWkx3wwQtbFeyIyAXYJzr7cM2ylgxKo7PxTteu/bqvs367HxPqh2hj2GrgMMVqTmQFVd226fp/E4DlOERqBXerqknIdPjSub1Jt5Of589S7M1PgAB8OwpGhwTBfm9V/X9/Zxc2yw+4WROH5FQuCasl98xTYmIuhxalAmRuIxmZ0gckfqWLXHMJ5DcX4muWfXb05p4vNxJmGh9pZ7qMbTR7LtwjWpHXcnLIKjq7x1i2pHuspkPZYuLBdAHpyPtMSKGvIPpYqUXaUpcmemTM3xCYOpwGRDeCRIg2cDSlJ+Ugr+6N9KoN1p4NSDy0uxmDGidWW0w4769Y5cnyuE0dNIvoYqVRdYKMyLVgnUrcrd/Bd+CZE8iViz+hb/bBzACSC0KEOPe16s4pXCWZ+rhsF28ByBhZ1VjvU= X-Forefront-PRVS: 02543CD7CD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR03MB553;23:YsYbVpX82+ZtQ0TiX+K2btuLTX4AfZZifeFsnm6y2e?= =?us-ascii?Q?Hz3rYmL8L2u6FQOQleC2f2N9s/gWau00ef8AmD/AXjt/xJMnLKFr3/A+H6Tv?= =?us-ascii?Q?STXUNbBT+ag3w/LRgkZeJa36CpP7Xh5LP3EiJdD9QOQXjTe1s7W47PoegxH4?= =?us-ascii?Q?zZBGMiDe/Z0h9SyThpcgkKjQdM+a+iiXL11Cw1UJYxMAjvQ7WEt5WfGN2dV4?= =?us-ascii?Q?reC0Vgtz/o+7jXTeXu6D/si0hzR+SfjxK7vMNOaomQkhZWJ1NZoCEe0okh9W?= =?us-ascii?Q?fkGl9ZWqmy3Al+QPGOWg9SHxpIgkMOV4UGcr3rlGjJ8pk1gGklgJBuIuXTCa?= =?us-ascii?Q?DMb+EKEoam0VG6UmgWWZzep2GO52ReqJBAjeN3NKG7CS0O8p8o+PQa4dxopN?= =?us-ascii?Q?tx3DTjrKl4UtdMMiOMZyS8p8GW3WpzdaCLuXKhe7UEcEiTIBgd/gpRoW/NVw?= =?us-ascii?Q?sy5IUzv06pSX/B2y8/zV0KKPc1GjgKMlCfA4bIWxG/xo2YPr2LRokRTj+8yf?= =?us-ascii?Q?KC7Ouee7365Uo0phD+9i+13LPh6/92FUHvcEPDEGW0zgOa4xz+5Cz+Uc+Kfa?= =?us-ascii?Q?Zy0dRmGMICkjEgIAfSnIY6l4K1F3L8Z2GuqY3JynIiIXMjiM3mLp3tlFfYFd?= =?us-ascii?Q?ah/tnSHjbjTOwJqY1PhtB/fJdwEMkW/u5ZNHPN/eD4hif17Yh+y+gujY5Ees?= =?us-ascii?Q?uRuPlRyd2WBaccfNMDydbcICS7aAXWpy4KQMTZ62+Fs7QqJq95PhFiGsVE7F?= =?us-ascii?Q?yqJPT/b6dvmfmX8XP7eXbOxCOSiEfJ1WWMCYLI+2D+fh9msMr/d4n2LSlcKQ?= =?us-ascii?Q?q3DDB0TZIDgxfGKBhCMGWvxtNgnne8X4P9JB/LRKpnz62se/x34kbImkdaOe?= =?us-ascii?Q?4P5RzmVokaJ0AILjfzyg5p05GHRzD/TSNIAhv4mZX1x1I9UZMzwbkkQSOkjT?= =?us-ascii?Q?c0FLsNzF6+Um/hf6HWUbi/LEZyr4AnDGFhlyscQGMol60mttlUZnEEh7ftfG?= =?us-ascii?Q?MB9BnvWwaOSm8Bu+DiFbAqf0NlGt63IkcVTiJl4LkCB/pr0Rc2sbkFvUV1V4?= =?us-ascii?Q?9kCOe3j1Pw4KxzN3UcjryvKmvFazdLYYEYafgkN6H63BFIL2FMVsCV2BzGd1?= =?us-ascii?Q?cya2Ek35H7TzkScyoVgIzKqFKgFKwLxmilYyKXawF2CGeOszqSFDcIlECeJR?= =?us-ascii?Q?C2H956rsrFKp4Je8+5345zIZkcSMqHJAJLd+EvkGwmMn1j0eEa4HGSUqpULJ?= =?us-ascii?Q?EFr+LBJT7CN2HB2UU=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB553;6:cwcmpwxjlklp3uQi4IlwPMYXadea2PKAvZdYWWGS7DFacd+ppaqFziCIvXsvaBTOVmpKTOlBlgOy2dAnwwKXYWZNs4VOnj9696m/DT/dz1REQinKht8KXcWsmksXcQNix2lUz9SLxA7jL8jG0NHlMgfotACv3404MV/piZFk6OApXl5Dz6P6yJ1djMY8zD3cs4G1P2E6D0TKakWYmTqFJLWnYoY52W0/hh/Wrh+za8fYr9Dd+UCn4j0doLLybBErcHyViLI11rYhEWawGNo+V58NtqogPZpNfKN8ztgmYPaT30bqB0NrRJiyffFbg9HwCzsar2d+rxDGC7sCWnia3/30d0iHL4mP3OkxxZJMYSvuCXJMsEZ6cUM/e2LZbeCJ5+toPMhcFk5u8shpryOyY0T+plC2Zgu4xDdaS3Y3nQs=;5:v+M3yyUGHXHCY90qjkLY6CXbO2z+JUn1P2vRDU+YYzyEGs4mP6jKxM33he+wz0kT1pQtdJshRoucXRScVHS+XMDe104hYI0mVy3xH49xd3wbl75N3azB9ox2n+EwqSTLVaj/uo6qFn2/QyuD5hniD+FvQSldBCosB8Dynh2jdfmLal/m8WKu7AwO/i5B2f2L;24:BNGPfBRHv0ZvT6qwy/JL0op9k6TDYZ8cObFyQLFEO73nubFrD8OKFDFxiLQtmgYYxPyhIbYNCeBH13guB9UE2f0DaiYp8yOuIinPzgfAzp0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB553;7:45ocuhrlOSvxpsHObPoiuNfZ1muWoCGIHD19hKZULFUXuOcg0TQI1STItXwz/Iy1QlH85z+ceNQl67rTQWHH/JrjUu7iXr4VzgRTDPPgxCWqQt2EnG/xDvjWxd+dAetxbw+o42e2wDbZZi2X9rJwGaVeyLSO0vUodA9oxC4SwAm/SNxI9bzmxBjYf1CK/U1rxK9Fo7D+iwSe7Bh0aBI8iJ19Ef0N1Hzxr167tI4QhI6k8RfnDtpzEBZwSS8W1WDj8qYZBNZFLFuhFLA87A43qYW1QaBOBiUbnhZnwUWGcG5vUx8sAX7jSXqpWl9jWBnLUdjINvlTUN3DWl9e5EhIFA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 16:53:34.8485 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB553 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Irina Tirdea If there are any errors in getting the cpu0 regulators, the driver returns -ENOENT. In case the regulators are not yet available, the devm_regulator_get calls will return -EPROBE_DEFER, so that the driver can be probed later. If we return -ENOENT, the driver will fail its initialization and will not try to probe again (when the regulators become available). Return the actual error received from regulator_get in probe. Print a differentiated message in case we need to probe the device later and in case we actually failed. Also add a message to inform when the driver has been successfully registered. Signed-off-by: Irina Tirdea Signed-off-by: Leonard Crestez --- drivers/cpufreq/imx6q-cpufreq.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c index 7719b02..be90ee3 100644 --- a/drivers/cpufreq/imx6q-cpufreq.c +++ b/drivers/cpufreq/imx6q-cpufreq.c @@ -222,6 +222,13 @@ static int imx6q_cpufreq_probe(struct platform_device *pdev) arm_reg = regulator_get(cpu_dev, "arm"); pu_reg = regulator_get_optional(cpu_dev, "pu"); soc_reg = regulator_get(cpu_dev, "soc"); + if (PTR_ERR(arm_reg) == -EPROBE_DEFER || + PTR_ERR(soc_reg) == -EPROBE_DEFER || + PTR_ERR(pu_reg) == -EPROBE_DEFER) { + ret = -EPROBE_DEFER; + dev_dbg(cpu_dev, "regulators not ready, defer\n"); + goto put_reg; + } if (IS_ERR(arm_reg) || IS_ERR(soc_reg)) { dev_err(cpu_dev, "failed to get regulators\n"); ret = -ENOENT; -- 2.7.4