From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D41743CE5B for ; Tue, 28 Jul 2026 15:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785250966; cv=none; b=RKY1/2sDshLjUslhEFjnQU6zF34otU5YOE0d4A3PzdDtl5ZHwm5+fcFdmClZ1SBAwVAXcqSZ0x6xXDBy1wLwX6Vv7eAyvYy2zAPC/33Y/kc2X8Z6Vapw+nPSLSMRcfCAP1Y9gC6xf36huz1X++4Ifl6An/YMMahN+BWST4eyAM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785250966; c=relaxed/simple; bh=ceGz+/JSzikXUw/9wJimnGn4R70MAZ9jq4KEN5hCYJQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NeFLj9YKZ5E526PCgoqX8REwEc/HTnVjuSKPt3ukqn/DnJ260P2/aPcbFXdlgW0PKHN+mzeRWOQvnx5pYWCMrRnYSIoSvLHDVESHRDgwIzpSiS7D7ohazbHs8ZiBrkRYhxuBHj0iWCFi4CZ3CxyOUrCDJ44t24INOCS9a3rbE1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=TOaukOZv; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="TOaukOZv" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 601FA3F9D1 for ; Tue, 28 Jul 2026 15:02:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1785250961; bh=/qUIIiNCkSh3g2ZufG12eN/sApuRNfi0iscRqao1qCw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TOaukOZvn9i+STT05qyHV3z8nySpdh0cyiuNDWZcOnFoCM/UknbLV1swkKTHI89Iw LFGYBd9AoI6CLuljDq1n9d0Ir/QMKCmSP6JpYXfoFZRvuVuEJ6NG2MNcXpfwU44TnS aJHveu9Ivm22tiTN6NaqVRCoPSNxymDWCtKtgtdhlXNe8hJXy2J7NcZR6KLDWFc6tP HfEyNFBq4PSbhD4b0GT1zAOAjD45hr4LLH1CXKKo+RJpueirH0wkuwRus4jSJMFQpR eQoWYDOEs97fcLQPCisVJabv6seefrvU9KPdR3VLrlBbD2zTNXyzYJaUlQ5DIA2Otz 7ZYtqY0waH5xTbDTkNUFlv0Q98nYzzZfy/SEAAAAdFZOVrQg/dhQXduPkzazaKlBe9 BdZzgmua3qd0D9Gu4OXIPF5sbJZz85l0f8MBYEEW7MxCDi53UtcEytvB7afII70yc9 ysmoUz+GnmNhFbdx2j5QSOW7LjKmQT288UOup3why8qH5w93PF3jeqP0S0eItJL6Ts q90h9tFQM1eEILlnd+e/4wfBtkvyW+geORg5OPsPEBKkeUmolp6bgejJYy0JjYm1d7 Wimk/f3DGFIKg1i4oyShzSgfmBXOFw3cFKqGX6e5nHbonOlPs9crdyezt3sJTHFz8R 4Zo147RC+ycDvfqrLb/Af9pA= Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-473ac08a6a4so3102215f8f.0 for ; Tue, 28 Jul 2026 08:02:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785250961; x=1785855761; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/qUIIiNCkSh3g2ZufG12eN/sApuRNfi0iscRqao1qCw=; b=B7e9SxiXcFO/agWKiG3IFa99ybZAnSitYQtuheJYX8YmsG0o6pjU/fsTkAFSzcrdfJ rNzt2gg59Z/68t8F6CIWDdy/W7vBpYkZjZ1+wWf3gXn1zWppxyllud+HJacZAKWRNKbz 9re5MSS42z6iVLaYMtDT3ApG0EP03zB+8cm9SkjDWT78vH4/HuKJB6HMdbYW3vwWjNfM 2RaeADI3Awmk/5ad1voUH3h+aUsvAP0PgwjPEMRbp8FQ2bmxOnn/2YQVOzPf7/imsly6 1IHHAk4htkYkFneHRqLmHsjpCx5PiqNOdH0KmFPZcKDbfTxCy97mvv1vMi71YDFmYBrg XTSg== X-Forwarded-Encrypted: i=1; AHgh+Rple2KabwD1ADdQfojjjdlYAbS2NjLjsp3xNa76rZERZMtxd0J/Q7UIPTo948eY7yz2XQw0hSUbx7U6edw=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ/fAMt21OQ36iD5InVGeKuC3AovDVieE0k/SW+ywCGPYjuhdv +eY+G5XPEAsaKyjIzLuovCtaREKwp1A0w+PphdIciJ+wxVIg4ggPojKX0IUA4xUwNQV6NxKWML8 f7ovPwJLCWbbfV9ZC4Pd/rBCgBYDZwcz1WOWixvV17lVT+yl7V5yAELtLA1K8TOPYnnHrQG7B1G 74duLm9w== X-Gm-Gg: AR+sD10JnR6GcBGZABHMB+AWMOd3eWKm5qtfgCJSR2BKmaMuhP+umkY4x2appcqXhpz raBg1J38rHQdwD4qEIbrX2Q4WFqxLdyNx4VVPoGdfEZZhWa5AL5Fz8d/j4Kqe9FdiRGrAIGdRSL YLxcPWlX2EcdjTuDg7NVD/lrdf7UY0CKPFgIKQXdO8/MsXZeKBb8Xp3IQPxbibrLoSWARuLko6q sPz1QXZVeeVTXaBsGANXxA0LnR1gqFUqApat6t9IoW/RcZ90h28/ScaTxz91SUn9kJ8OXoT/+kK gN/cWNpxnsKAWLstSQslCOHXSWxvc8R6WyYI/RAe5fgi4Wt8W0V12B1i9/vee89gcoa0wPXgZV5 mmTjOIRZ78MM= X-Received: by 2002:a05:6000:2583:b0:47f:8fb6:c32e with SMTP id ffacd0b85a97d-47fb1edc07cmr3123017f8f.46.1785250960734; Tue, 28 Jul 2026 08:02:40 -0700 (PDT) X-Received: by 2002:a05:6000:2583:b0:47f:8fb6:c32e with SMTP id ffacd0b85a97d-47fb1edc07cmr3122975f8f.46.1785250960302; Tue, 28 Jul 2026 08:02:40 -0700 (PDT) Received: from [192.168.1.12] ([176.43.219.221]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f85b9a596sm57899813f8f.4.2026.07.28.08.02.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jul 2026 08:02:39 -0700 (PDT) Message-ID: <7f31351f-43ef-41f7-b30a-2a9a008d4f3d@canonical.com> Date: Tue, 28 Jul 2026 18:02:38 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gpio: sloppy-logic-analyzer: fix use-after-free via debugfs trigger on unbind To: Wolfram Sang Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260727231026.470146-1-cengiz.can@canonical.com> Content-Language: en-US From: Cengiz Can In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/28/26 12:47, Wolfram Sang wrote: > >> debugfs_create_file_unsafe("buf_size", 0600, priv->debug_dir, priv, &fops_buf_size); >> debugfs_create_file_unsafe("capture", 0200, priv->debug_dir, priv, &fops_capture); >> - debugfs_create_file_unsafe("trigger", 0200, priv->debug_dir, priv, &fops_trigger); >> + debugfs_create_file("trigger", 0200, priv->debug_dir, priv, &fops_trigger); > > What about removing the other _unsafe calls as well? TBH, I can't recall > why I used them. Doesn't make sense from today's perspective. I checked those too, but buf_size and capture are fine as they are. They use DEFINE_DEBUGFS_ATTRIBUTE(), whose read/write paths take a debugfs reference (debugfs_file_get()/put()) around the access. So they already hold a reference and removal waits for them. Switching them to debugfs_create_file() would just add a second get/put around the one they already do, so I would leave them. Happy to send a follow-up if you'd prefer them consistent. Thanks!