From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E98C433DB for ; Fri, 29 Jan 2021 22:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DAD661492 for ; Fri, 29 Jan 2021 22:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232633AbhA2WmI (ORCPT ); Fri, 29 Jan 2021 17:42:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232420AbhA2Wl5 (ORCPT ); Fri, 29 Jan 2021 17:41:57 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40710C061756 for ; Fri, 29 Jan 2021 14:41:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=aAYh3DP2zUjQJpT017dM88kX0zMM6n0co2EoHcZKDkE=; b=iB/D4YZabpcr/vEeQT0kZDHmDu jrh+Ns4evZ6+mhr5VKjDlIZEGffecW08Q4ntrkFNm5mfWHwPTjI2j3A6gbtt8Elj6v/As1BnhumSW NkcUJhjU4sziN3ibf/cY1VVxoXLSHdSjK9YnqA+wgQe4YXYvBjRVrWgVg7S+R1xv+cju0xft2PWk4 8XZP+gfBaJzD8xGt10uQOLJWmYQLsnDSrXPnzVZLYls+WGuOVmm5ZqEaISn8LElm/OVsAr3PHmVlt qPX/Dg7qK0rPQRy7TY0BrbzMV+Q7RIhyIUOufQwyUd1QoWR5MxhY+VhwMDZdywNe43mPSLWUYu76U /PPusSSg==; Received: from [2601:1c0:6280:3f0::7650] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5cRz-0004WG-JB; Fri, 29 Jan 2021 22:41:11 +0000 Subject: Re: [PATCH v2] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set To: Scott Branden , Arnd Bergmann , Greg Kroah-Hartman Cc: Kees Cook , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Olof Johansson , Desmond Yan References: <20210129220627.22641-1-scott.branden@broadcom.com> From: Randy Dunlap Message-ID: <7f47f2cc-dcea-0734-6d58-fb38d120eed3@infradead.org> Date: Fri, 29 Jan 2021 14:41:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210129220627.22641-1-scott.branden@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/29/21 2:06 PM, Scott Branden wrote: > Correct compile issue if CONFIG_TTY is not set by > only adding ttyVK devices if CONFIG_TTY is set. > > Reported-by: Randy Dunlap > Signed-off-by: Scott Branden > > --- > Changes since v1: > Add function stubs rather than compiling out code > --- > drivers/misc/bcm-vk/Makefile | 4 ++-- > drivers/misc/bcm-vk/bcm_vk.h | 35 +++++++++++++++++++++++++++++--- > drivers/misc/bcm-vk/bcm_vk_dev.c | 3 +-- > drivers/misc/bcm-vk/bcm_vk_tty.c | 6 ++++++ > 4 files changed, 41 insertions(+), 7 deletions(-) Looks good. Thanks. Acked-by: Randy Dunlap # build-tested -- ~Randy