Re: [PATCH v0 1/3] media: chips-media: wave5: Add Support for Background Detection

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 1972 bytes --]

Hi,

Le vendredi 20 mars 2026 à 06:37 +0000, jackson.lee a écrit :
> Hi Nicolas
> 
> I got the message below from the CI robot.
> But in v4l2-controls.h, none of the defined strings include spaces around "+".
> Can I ignore this warning?
> 
> 
> # Test checkpatch:./0001-media-chips-media-wave5-Add-Support-for-Background-D.patch checkpatch
> CHECK: spaces preferred around that '+' (ctx:VxV)
> #134: FILE: include/uapi/linux/v4l2-controls.h:467:
> +#define 
> +V4L2_CID_MPEG_VIDEO_BACKGROUND_DETECTION(V4L2_CID_CODEC_BASE+238)
>                                                                      ^
> 

Actually, the older definitions don't, the newer definitions do. Please adopt
the CI suggestion, I'll add to my todo to fix them all in separate thread.

regards,
Nicolas

> total: 0 errors, 0 warnings, 1 checks, 81 lines checked
> 
> 
> 
> Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded.
> 
> For more details, check the full report at:
> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/95650311/artifacts/report.htm .
> 
> 
> 
> Best regards, and Happy Hacking!
> Media CI robot on behalf of the linux-media community.
> 
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> 
> If you believe that the CI is wrong, kindly open an issue at https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all to this message.
> 
> > +#define V4L2_CID_MPEG_VIDEO_BACKGROUND_DETECTION
> > 	(V4L2_CID_CODEC_BASE+238)
> > +
> 
> Thanks
> Jackson
> 
> >  /* CIDs for the MPEG-2 Part 2 (H.262) codec */
> >  #define V4L2_CID_MPEG_VIDEO_MPEG2_LEVEL
> > 	(V4L2_CID_CODEC_BASE+270)
> >  enum v4l2_mpeg_video_mpeg2_level {
> > --
> > 2.43.0

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]