From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 661E9C433EF for ; Fri, 8 Jul 2022 11:14:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237381AbiGHLOq (ORCPT ); Fri, 8 Jul 2022 07:14:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237346AbiGHLOo (ORCPT ); Fri, 8 Jul 2022 07:14:44 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A82E88F35 for ; Fri, 8 Jul 2022 04:14:40 -0700 (PDT) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LfVwp4ZBlz1L9Fg; Fri, 8 Jul 2022 19:12:10 +0800 (CST) Received: from kwepemm600013.china.huawei.com (7.193.23.68) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Jul 2022 19:14:38 +0800 Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Jul 2022 19:14:37 +0800 Subject: Re: [PATCH -next] ubifs: Fix some kernel-doc comments From: Zhihao Cheng To: Yang Li , CC: , , "Abaci Robot" References: <20220602055233.26161-1-yang.lee@linux.alibaba.com> <2df4d326-c59a-52d2-c5aa-02954ddca97a@huawei.com> Message-ID: <7f4a0b5d-373f-0cb4-f1ea-5712d08a6bdb@huawei.com> Date: Fri, 8 Jul 2022 19:14:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <2df4d326-c59a-52d2-c5aa-02954ddca97a@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/7/8 17:17, Zhihao Cheng 写道: > 在 2022/6/2 13:52, Yang Li 写道: >> Remove warnings found by running scripts/kernel-doc, >> which is caused by using 'make W=1'. >> fs/ubifs/journal.c:1221: warning: Function parameter or member >> 'old_inode' not described in 'ubifs_jnl_rename' >> fs/ubifs/journal.c:1221: warning: Function parameter or member 'old_nm' >> not described in 'ubifs_jnl_rename' >> fs/ubifs/journal.c:1221: warning: Function parameter or member >> 'new_inode' not described in 'ubifs_jnl_rename' >> fs/ubifs/journal.c:1221: warning: Function parameter or member 'new_nm' >> not described in 'ubifs_jnl_rename' >> fs/ubifs/journal.c:1221: warning: Function parameter or member >> 'whiteout' not described in 'ubifs_jnl_rename' >> fs/ubifs/journal.c:1221: warning: Excess function parameter 'old_dentry' >> description in 'ubifs_jnl_rename' >> fs/ubifs/journal.c:1221: warning: Excess function parameter 'new_dentry' >> description in 'ubifs_jnl_rename' >> >> Reported-by: Abaci Robot >> Signed-off-by: Yang Li >> --- >>   fs/ubifs/journal.c | 7 +++++-- >>   1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c >> index 75dab0ae3939..16857d4e9aa8 100644 >> --- a/fs/ubifs/journal.c >> +++ b/fs/ubifs/journal.c >> @@ -1201,9 +1201,12 @@ int ubifs_jnl_xrename(struct ubifs_info *c, >> const struct inode *fst_dir, >>    * ubifs_jnl_rename - rename a directory entry. >>    * @c: UBIFS file-system description object >>    * @old_dir: parent inode of directory entry to rename >> - * @old_dentry: directory entry to rename >> + * @old_inode: parent inode to rename >> + * @old_nm: name of old inode to rename >>    * @new_dir: parent inode of directory entry to rename >> - * @new_dentry: new directory entry (or directory entry to replace) >> + * @new_inode: new inode to rename >> + * @new_nm: name of new inode to rename >> + * @whiteout: whiteout inode >>    * @sync: non-zero if the write-buffer has to be synchronized >>    * >>    * This function implements the re-name operation which may involve >> writing up >> > Reviewed-by: Zhihao Cheng Please ignore this review tag, sorry for this mistaken reply, the review tag is for v2. > > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/