From: Zhihao Cheng <chengzhihao1@huawei.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: <richard@nod.at>, <miquel.raynal@bootlin.com>, <vigneshr@ti.com>,
<mcoquelin.stm32@gmail.com>, <kirill.shutemov@linux.intel.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 04/12] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout
Date: Mon, 15 Nov 2021 17:20:44 +0800 [thread overview]
Message-ID: <7f521d7d-e269-6668-3e71-fd8ad1f3c080@huawei.com> (raw)
In-Reply-To: <20211115082446.GC25697@pengutronix.de>
在 2021/11/15 16:24, Sascha Hauer 写道:
Hi Sascha,
>> diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
>> index 2735ad1affed..6503e6857f6e 100644
>> --- a/fs/ubifs/dir.c
>> +++ b/fs/ubifs/dir.c
>> @@ -1334,6 +1334,8 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,
>>
>> err = do_tmpfile(old_dir, old_dentry, S_IFCHR | WHITEOUT_MODE, &whiteout);
>> if (err) {
>> + if (whiteout)
>> + iput(whiteout);
>
> Should this rather be done in do_tmpfile() directly?
Yes, I should have done it. Although next patch reconstructs do_rename()
which makes this ugly judgement disappered. I will fix it along with
other suggestions from other patches in next iteration. Thanks.
> Sascha
>
next prev parent reply other threads:[~2021-11-15 9:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 12:17 [PATCH v3 00/12] Some bugfixs for ubi/ubifs Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 01/12] ubifs: rename_whiteout: Fix double free for whiteout_ui->data Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 02/12] ubifs: Fix deadlock in concurrent rename whiteout and inode writeback Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 03/12] ubifs: Fix wrong number of inodes locked by ui_mutex in ubifs_inode comment Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 04/12] ubifs: Add missing iput if do_tmpfile() failed in rename whiteout Zhihao Cheng
2021-11-15 8:24 ` Sascha Hauer
2021-11-15 9:03 ` Zhihao Cheng
2021-11-15 9:20 ` Zhihao Cheng [this message]
2021-11-12 12:17 ` [PATCH v3 05/12] ubifs: Rename whiteout atomically Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 06/12] ubifs: Fix 'ui->dirty' race between do_tmpfile() and writeback work Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 07/12] ubifs: Rectify space amount budget for mkdir/tmpfile operations Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 08/12] ubifs: setflags: Make dirtied_ino_d 8 bytes aligned Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 09/12] ubifs: Fix read out-of-bounds in ubifs_wbuf_write_nolock() Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 10/12] ubifs: Fix to add refcount once page is set private Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 11/12] ubi: fastmap: Return error code if memory allocation fails in add_aeb() Zhihao Cheng
2021-11-12 12:17 ` [PATCH v3 12/12] ubi: fastmap: Add all fastmap pebs into 'ai->fastmap' when fm->used_blocks>=2 Zhihao Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f521d7d-e269-6668-3e71-fd8ad1f3c080@huawei.com \
--to=chengzhihao1@huawei.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=s.hauer@pengutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®