From: Randy Dunlap <rdunlap@infradead.org>
To: Alexandra Winter <wintera@linux.ibm.com>,
Simon Horman <simon.horman@corigine.com>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
linux-s390@vger.kernel.org, netdev@vger.kernel.org,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] s390/net: lcs: fix build errors when FDDI is a loadable module
Date: Tue, 27 Jun 2023 19:53:08 -0700 [thread overview]
Message-ID: <7f585168-7296-58aa-7fdb-c2aa08f346f4@infradead.org> (raw)
In-Reply-To: <3da03251-21ac-b41f-593d-cbc9ac9f86f6@linux.ibm.com>
Hi,
Sorry for the delay.
On 6/22/23 05:16, Alexandra Winter wrote:
>
>
> On 22.06.23 09:53, Simon Horman wrote:
>> On Thu, Jun 22, 2023 at 09:15:24AM +0200, Alexandra Winter wrote:
>>>
>>>
>>> On 21.06.23 23:37, Randy Dunlap wrote:
>>>> Require FDDI to be built-in if it is used. LCS needs FDDI to be
>>>> built-in to build without errors.
>>>>
>>>> Prevents these build errors:
>>>> s390-linux-ld: drivers/s390/net/lcs.o: in function `lcs_new_device':
>>>> drivers/s390/net/lcs.c:2150: undefined reference to `fddi_type_trans'
>>>> s390-linux-ld: drivers/s390/net/lcs.c:2151: undefined reference to `alloc_fddidev'
>>>>
>>>> This FDDI requirement effectively restores the previous condition
>>>> before the blamed patch, when #ifdef CONFIG_FDDI was used, without
>>>> testing for CONFIG_FDDI_MODULE.
>>>>
>>>> Fixes: 128272336120 ("s390/net: lcs: use IS_ENABLED() for kconfig detection")
> [...]
>>
>>> 2) I wonder whether
>>>
>>> depends on CCW && NETDEVICES && (ETHERNET || FDDI)
>>> + depends on FDDI || FDDI=n
>>>
>>> would do what we want here:
>>> When FDDI is a loadable module, LCS mustn't be built-in.
>>>
>>> I will do some experiments and let you know.
>>
>> It does seem to on my side.
>> But checking would be much appreciated.
>
>
> Here are my experiments:
>
> Current net-next:
> -----------------
> if !IS_ENABLED(CONFIG_ETHERNET) && !IS_ENABLED(CONFIG_FDDI)
>
> drivers/s390/net/KConfig:
> config LCS
> def_tristate m
> depends on CCW && NETDEVICES && (ETHERNET || FDDI)
>
> .config:
> ETHERNET | FDDI | LCS choices | LCS | compile
> --------------------------------------------------------
> n m m,n m success (failed before Randy's fix)
> y m y,m,n m success (failed before Randy's fix)
> y m y fails: undefined reference to `fddi_type_trans'
>
>
> Simon's proposal:
> -----------------
> depends on CCW && NETDEVICES && (ETHERNET || FDDI)
> + depends on FDDI=y || FDDI=n
>
> ETHERNET | FDDI | LCS choices | LCS | compile
> --------------------------------------------------------
> n m -
> y m -
> y m -
> y n y,m,n y success
> y n y,m,n m success
> y y y,m,n m success
>
>
> Alexandra's proposal:
> ---------------------
> depends on CCW && NETDEVICES && (ETHERNET || FDDI)
> + depends on FDDI || FDDI=n
>
> ETHERNET | FDDI | LCS choices | LCS | compile
> --------------------------------------------------------
> n m m,n m success
> y m m,n m success
> y n y,m,n y success
> y n y,m,n m success
> y y y,m,n m success
>
> -----------------------------------------------------------
>
> Seems that
> A[tristate] depends on B[tristate]
> means that A cannot be 'higher' than B.
> Meaning, if B=n -> A= must be n
> if B=m -> A can be m or n
> if B=y -> A can be y or m or n
Looks correct.
> Although I did not find documentation confirming that.
I think that it's in Documentation/kbuild/kconfig-language.rst,
under "Menu dependencies", but not quite in that format. :)
>
> @Randy, do you want give a v2 a try with that?
Sure, I'll try that.
> I guess then it is safe to delete from drivers/s390/net/lcs.c
> -#if !IS_ENABLED(CONFIG_ETHERNET) && !IS_ENABLED(CONFIG_FDDI)
> -#error Cannot compile lcs.c without some net devices switched on.
> -#endif
Yes, I was planning to do that as well.
Thanks for the time that you have spent on this.
--
~Randy
next prev parent reply other threads:[~2023-06-28 2:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 21:37 Randy Dunlap
2023-06-22 7:15 ` Alexandra Winter
2023-06-22 7:53 ` Simon Horman
2023-06-22 12:16 ` Alexandra Winter
2023-06-22 12:33 ` Christian Borntraeger
2023-06-28 2:53 ` Randy Dunlap [this message]
2023-06-28 5:06 ` Randy Dunlap
2023-06-28 13:41 ` Alexandra Winter
2023-06-28 15:29 ` Randy Dunlap
2023-06-22 15:36 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f585168-7296-58aa-7fdb-c2aa08f346f4@infradead.org \
--to=rdunlap@infradead.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=svens@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
--cc=wintera@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®