From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A9DB3B0AFD for ; Fri, 13 Mar 2026 15:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773415672; cv=none; b=Rpv3WYvIVjvKSBiCn5m2Fvh9QrGJHHKm1ASgzjbWI8IQ4zwY0IH5mwr7PwphgdH/ALyLK5tpp7uYmQOTStGrUZBFOkVuWczmkcblkiJSMcFpSe6FNuQuOyuY6mtKU48USnHancPgMB4aHHvr8V7djcTLVNlxQ+I0Xfqc+OtyW9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773415672; c=relaxed/simple; bh=r732MH4eUyZFj0cG1H0vXTxFnuY4XK0oCax8NJCzLZk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=brosjIrSvA+6edb9ApeUML/OJEyqsAFNrq8ChVWVBhg29sCA+QQflZuzgnj6f/iWaZQUP8NUVxrD8Yx3VCcyB80z+yGAkUEsIhX2iidSm64Wud+8lrUJqJKHelVN2hbbWeXxZlBRgGDbnP6+04ZtslXsU9hDG22F8TB/xiAG+W8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JIK4oR8f; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JIK4oR8f" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48541edecf9so24357205e9.1 for ; Fri, 13 Mar 2026 08:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773415669; x=1774020469; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=MMNm0gL3Me4TtMRtXwPRJioaCzWcm1bgO59kj5/wfh4=; b=JIK4oR8faDg1s//Z10u09I3vKcunVZj7Enu18xNpQLdQonpUPSyrxITWzNxHw0qZGn +gYTi4FTbM/A3LvPp/Ysts3AU1kvcoQHXkwMHKKqmUVAGkx8RmThPmaSpOPGlp3vp3vw YdpNWVOFvV/qVvkzpoANSAarTKK4/QvqmoOkfuM+COkOAcIpwU75RmpE7eGP1XqCxspr JExro/0MEo9rd4oVvu1Q8z1CvwqpePU1u7nbHpUYaH5h33aO0p43RCdN/F9a6T4KHEVA yIHmxC4gbAE9LW4qiwrv3lxbNZhORitNjE+3YYSNWU34VT7lmhOpfeo7nshaxe1U6dxk UjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773415669; x=1774020469; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MMNm0gL3Me4TtMRtXwPRJioaCzWcm1bgO59kj5/wfh4=; b=JY3tlmEJ1a31NByRjyUsRA5ubppMaiDNIrwKWwi5GunzzlTcchQIAvRER9tUpdQanb wxr29Kd69ZvAhHubc26+Bazdbf0pn/ogHJJFDaiANfYWAmjO3VAWhdUOv5OUA5oeEcsx st0KsagZUr3vKgiP9z3OAR2NqbPfYw3qinFrtsH6r7gK1asLmavcWy7znwHNtT6hddct MqsVqBNDZvCBkKhHFiFJj5di2vsFNOiIfUlGy97MHkQAE2TticrUiW3kDnO7JaXkV0eL f5Ny8ieo6JvwzVIQ2lnIo5iU5sYHDC/zj4PmNp2Z1My3SY7aFzLcVLlxmnd9Y7DoplYQ 3uLg== X-Forwarded-Encrypted: i=1; AJvYcCWTB3GcUqJBl8tX32Cth3uDj6BDKPDGb0aio0rpsipyTaG3BVorZ4PcOZIuSxhsw1jbijBICCyVabV6edY=@vger.kernel.org X-Gm-Message-State: AOJu0YwYReTv07bfs6VvPk2kz1fQQibbJbxD9xvM58/e6TtO2xgW8B5L JJA8+VjcHjy5ZOjdE3v/SV233bKo6v2x34ReB72tlzGo8COGvExqKHNI X-Gm-Gg: ATEYQzzwv9yuj0i2HMkp7FnMYzVOM7k9f7D6CFjnzghS0+k/m2gUgLfaQPjZWircmoI IL1ia/KOvaPtNuTmZ/hKEEr1bfUdVl6VdYgBhjiKTRdQJ5KMykaYCbNrKS9roum64U8SyHnoirZ 4+IsMSUfOQn/nQoZ7WlBaVl9vNpbsCmYL0FMqAuQ+M+UVfczvxL6MoG+acCOQyaAYS/60RfP/zX PQxcSZlRAJ0jYfY4OWOmlF4mVXVi5NdWopNRLtKhi1DvLJylYEhjXCW0vNR/G8E25JfWzzpBI02 f61yvkTT84no9TgoJMpMRtPW2YVF9d05/2r3Z2fWJUOai0LHpsbNmK3fCZyxLs/F+GVZGchhyhK rkM92K1w0JIhHQK0Edn4Ka5fjHyU6hwcCc+RbeKwA5N8UrwbC4KE22zWGCnjTqsvWModFBRqAzq ECNpwNCCH5jUm0fVaSsb5XUWFTiO5l8tYLFUxp7A4Wk35Oplm2etfM8BjG7hshD5o= X-Received: by 2002:a05:600c:c049:b0:483:7903:c3b1 with SMTP id 5b1f17b1804b1-485566f7a35mr46270265e9.20.1773415669234; Fri, 13 Mar 2026 08:27:49 -0700 (PDT) Received: from [192.168.8.102] (89-24-59-99.nat.epc.tmcz.cz. [89.24.59.99]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439fdf09abesm18409700f8f.0.2026.03.13.08.27.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 08:27:48 -0700 (PDT) Message-ID: <7f613001-fc2b-44e3-ac14-7e661cf52fdd@gmail.com> Date: Fri, 13 Mar 2026 16:27:46 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] dm-inlinecrypt: add target for inline block device encryption To: Mikulas Patocka , Eric Biggers Cc: Linlin Zhang , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, adrianvovk@gmail.com, dm-devel@lists.linux.dev, quic_mdalam@quicinc.com, israelr@nvidia.com References: <20260304121729.1532469-1-linlin.zhang@oss.qualcomm.com> <20260304121729.1532469-3-linlin.zhang@oss.qualcomm.com> <20260312070110.GD2359@sol> <5a310122-bd7e-d10e-653e-bc7e09681478@redhat.com> Content-Language: en-US From: Milan Broz Autocrypt: addr=gmazyland@gmail.com; keydata= xsFNBE94p38BEADZRET8y1gVxlfDk44/XwBbFjC7eM6EanyCuivUPMmPwYDo9qRey0JdOGhW hAZeutGGxsKliozmeTL25Z6wWICu2oeY+ZfbgJQYHFeQ01NVwoYy57hhytZw/6IMLFRcIaWS Hd7oNdneQg6mVJcGdA/BOX68uo3RKSHj6Q8GoQ54F/NpCotzVcP1ORpVJ5ptyG0x6OZm5Esn 61pKE979wcHsz7EzcDYl+3MS63gZm+O3D1u80bUMmBUlxyEiC5jo5ksTFheA8m/5CAPQtxzY vgezYlLLS3nkxaq2ERK5DhvMv0NktXSutfWQsOI5WLjG7UWStwAnO2W+CVZLcnZV0K6OKDaF bCj4ovg5HV0FyQZknN2O5QbxesNlNWkMOJAnnX6c/zowO7jq8GCpa3oJl3xxmwFbCZtH4z3f EVw0wAFc2JlnufR4dhaax9fhNoUJ4OSVTi9zqstxhEyywkazakEvAYwOlC5+1FKoc9UIvApA GvgcTJGTOp7MuHptHGwWvGZEaJqcsqoy7rsYPxtDQ7bJuJJblzGIUxWAl8qsUsF8M4ISxBkf fcUYiR0wh1luUhXFo2rRTKT+Ic/nJDE66Ee4Ecn9+BPlNODhlEG1vk62rhiYSnyzy5MAUhUl stDxuEjYK+NGd2aYH0VANZalqlUZFTEdOdA6NYROxkYZVsVtXQARAQABzSBNaWxhbiBCcm96 IDxnbWF6eWxhbmRAZ21haWwuY29tPsLBlQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AWIQQqKRgkP95GZI0GhvnZsFd72T6Y/AUCYaUUZgUJJPhv5wAKCRDZsFd72T6Y/D5N D/438pkYd5NyycQ2Gu8YAjF57Od2GfeiftCDBOMXzh1XxIx7gLosLHvzCZ0SaRYPVF/Nr/X9 sreJVrMkwd1ILNdCQB1rLBhhKzwYFztmOYvdCG9LRrBVJPgtaYqO/0493CzXwQ7FfkEc4OVB uhBs4YwFu+kmhh0NngcP4jaaaIziHw/rQ9vLiAi28p1WeVTzOjtBt8QisTidS2VkZ+/iAgqB 9zz2UPkE1UXBAPU4iEsGCVXGWRz99IULsTNjP4K3p8ZpdZ6ovy7X6EN3lYhbpmXYLzZ3RXst PEojSvqpkSQsjUksR5VBE0GnaY4B8ZlM3Ng2o7vcxbToQOsOkbVGn+59rpBKgiRadRFuT+2D x80VrwWBccaph+VOfll9/4FVv+SBQ1wSPOUHl11TWVpdMFKtQgA5/HHldVqrcEssWJb9/tew 9pqxTDn6RHV/pfzKCspiiLVkI66BF802cpyboLBBSvcDuLHbOBHrpC+IXCZ7mgkCrgMlZMql wFWBjAu8Zlc5tQJPgE9eeQAQrfZRcLgux88PtxhVihA1OsMNoqYapgMzMTubLUMYCCsjrHZe nzw5uTcjig0RHz9ilMJlvVbhwVVLmmmf4p/R37QYaqm1RycLpvkUZUzSz2NCyTcZp9nM6ooR GhpDQWmUdH1Jz9T6E9//KIhI6xt4//P15ZfiIs7BTQRPeKd/ARAA3oR1fJ/D3GvnoInVqydD U9LGnMQaVSwQe+fjBy5/ILwo3pUZSVHdaKeVoa84gLO9g6JLToTo+ooMSBtsCkGHb//oiGTU 7KdLTLiFh6kmL6my11eiK53o1BI1CVwWMJ8jxbMBPet6exUubBzceBFbmqq3lVz4RZ2D1zKV njxB0/KjdbI53anIv7Ko1k+MwaKMTzO/O6vBmI71oGQkKO6WpcyzVjLIip9PEpDUYJRCrhKg hBeMPwe+AntP9Om4N/3AWF6icarGImnFvTYswR2Q+C6AoiAbqI4WmXOuzJLKiImwZrSYnSfQ 7qtdDGXWYr/N1+C+bgI8O6NuAg2cjFHE96xwJVhyaMzyROUZgm4qngaBvBvCQIhKzit61oBe I/drZ/d5JolzlKdZZrcmofmiCQRa+57OM3Fbl8ykFazN1ASyCex2UrftX5oHmhaeeRlGVaTV iEbAvU4PP4RnNKwaWQivsFhqQrfFFhvFV9CRSvsR6qu5eiFI6c8CjB49gBcKKAJ9a8gkyWs8 sg4PYY7L15XdRn8kOf/tg98UCM1vSBV2moEJA0f98/Z48LQXNb7dgvVRtH6owARspsV6nJyD vktsLTyMW5BW9q4NC1rgQC8GQXjrQ+iyQLNwy5ESe2MzGKkHogxKg4Pvi1wZh9Snr+RyB0Rq rIrzbXhyi47+7wcAEQEAAcLBfAQYAQgAJgIbDBYhBCopGCQ/3kZkjQaG+dmwV3vZPpj8BQJh pRSXBQkk+HAYAAoJENmwV3vZPpj8BPMP/iZV+XROOhs/MsKd7ngQeFgETkmt8YVhb2Rg3Vgp AQe9cn6aw9jk3CnB0ecNBdoyyt33t3vGNau6iCwlRfaTdXg9qtIyctuCQSewY2YMk5AS8Mmb XoGvjH1Z/irrVsoSz+N7HFPKIlAy8D/aRwS1CHm9saPQiGoeR/zThciVYncRG/U9J6sV8XH9 OEPnQQR4w/V1bYI9Sk+suGcSFN7pMRMsSslOma429A3bEbZ7Ikt9WTJnUY9XfL5ZqQnjLeRl 8243OTfuHSth26upjZIQ2esccZMYpQg0/MOlHvuFuFu6MFL/gZDNzH8jAcBrNd/6ABKsecYT nBInKH2TONc0kC65oAhrSSBNLudTuPHce/YBCsUCAEMwgJTybdpMQh9NkS68WxQtXxU6neoQ U7kEJGGFsc7/yXiQXuVvJUkK/Xs04X6j0l1f/6KLoNQ9ep/2In596B0BcvvaKv7gdDt1Trgg vlB+GpT+iFRLvhCBe5kAERREfRfmWJq1bHod/ulrp/VLGAaZlOBTgsCzufWF5SOLbZkmV2b5 xy2F/AU3oQUZncCvFMTWpBC+gO/o3kZCyyGCaQdQe4jS/FUJqR1suVwNMzcOJOP/LMQwujE/ Ch7XLM35VICo9qqhih4OvLHUAWzC5dNSipL+rSGHvWBdfXDhbezJIl6sp7/1rJfS8qPs In-Reply-To: <5a310122-bd7e-d10e-653e-bc7e09681478@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/13/26 2:25 PM, Mikulas Patocka wrote: > On Thu, 12 Mar 2026, Eric Biggers wrote: > >> On Wed, Mar 04, 2026 at 04:17:27AM -0800, Linlin Zhang wrote: >>> From: Eric Biggers >>> >>> Add a new device-mapper target "dm-inlinecrypt" that is similar to >>> dm-crypt but uses the blk-crypto API instead of the regular crypto API. >>> This allows it to take advantage of inline encryption hardware such as >>> that commonly built into UFS host controllers. ... >> I don't think it's plausible that this new patch was actually tested. >> The version I sent in 2024 was tested at the time >> (https://lore.kernel.org/r/20241016232748.134211-3-ebiggers@kernel.org/), >> but I see at least two things that would make this new patch not work. What a waste of time... thanks. > OK. I dropped it. Well, the inline crypt has some advantages to proprietary internal hw implementations (like self-encrypting drives) - it can be actually validated comparing to sw version. Anyway, Mikulas, if this dm-inlinecrypt returns one day, please be sure that we do not have security-related "regressions" like not supporting keyring. There is no need for dm-inlinecrypt to keep key inside the mapping table. The keyring code is in dm-crypt, it should be easy to adapt it here. Thanks, Milan