From: "T, Harini" <harini.t@amd.com>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>, jassisinghbrar@gmail.com
Cc: michal.simek@amd.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mailbox: zynqmp: Put the parent node after reading buffer resources
Date: Wed, 18 Nov 2026 19:29:47 +0530 [thread overview]
Message-ID: <7f62662d-937e-46ab-b607-7d70456f2b1c@amd.com> (raw)
In-Reply-To: <20261112071640.154439-1-zhujun2@cmss.chinamobile.com>
On 11/12/2026 12:46 PM, Zhu Jun wrote:
> versal_ipi_setup() obtains a reference to the parent node to look up
> the host message buffer resource, but never releases it. Each setup
> leaks the reference, including when a subsequent buffer mapping fails.
>
> The resource lookup copies the address and size into host_res. Drop
> the node reference immediately after that lookup.
>
> Fixes: 0ac39d85a741 ("mailbox: zynqmp: Enable Bufferless IPI usage on Versal-based SOC's")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
> drivers/mailbox/zynqmp-ipi-mailbox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 2b81bedf0653..0c175f0b048a 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -696,6 +696,7 @@ static int versal_ipi_setup(struct zynqmp_ipi_mbox *ipi_mbox,
> mdev = &ipi_mbox->dev;
>
> host_idx = zynqmp_ipi_mbox_get_buf_res(parent_node, "msg", &host_res);
> + of_node_put(parent_node);
> remote_idx = zynqmp_ipi_mbox_get_buf_res(node, "msg", &remote_res);
>
> /*
Reviewed-by: Harini T <harini.t@amd.com>
Thanks,
Harini T
prev parent reply other threads:[~2026-11-18 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 7:16 Zhu Jun
2026-11-18 13:59 ` T, Harini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f62662d-937e-46ab-b607-7d70456f2b1c@amd.com \
--to=harini.t@amd.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®