From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934055AbdAKK1N (ORCPT ); Wed, 11 Jan 2017 05:27:13 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:57723 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757764AbdAKK1I (ORCPT ); Wed, 11 Jan 2017 05:27:08 -0500 X-AuditID: b6c32a3c-f79826d000002380-3c-5876087a670f Subject: Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board To: Andrzej Hajda , krzk@kernel.org, robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, inki.dae@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, andi.shyti@samsung.com, Hyungwon Hwang , Hoegeun Kwon From: hoegeun kwon Message-id: <7f698df0-f581-7fea-ed2a-762d4a9fcd77@samsung.com> Date: Wed, 11 Jan 2017 19:27:10 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-version: 1.0 In-reply-to: <2f362dda-6c57-6aa4-5572-b27c34c4c78e@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNJsWRmVeSWpSXmKPExsWy7bCmrm4VR1mEwZXNbBa31p1jteg9d5LJ YvuRZ6wW1788Z7WYfwQoduXrezaL98u72CyWzuhjtZh0fwKLxY1fbawW/Y9fM1ucP7+B3eLy rjlsFjPO72Oy+L9nB7vFz13zWBwEPHbOusvusWlVJ5vH9m8PWD3udx9n8ujbsorR4/MmuQC2 qFSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKDDlRTK EnNKgUIBicXFSvp2NkX5pSWpChn5xSW2StGGhkZ6hgbmekZGRnomxrFWRqZAJQmpGef+9zAX nBasmPt0ElMD4wy+LkZODgkBE4mnO04zQdhiEhfurWcDsYUEdjBKLHwd2MXIBWS3M0ks+TOP Fabh6Ie17BCJ5YwSp/49YYZw7jJKXO/6yA5SJSyQLHG1vZcFJCEi0Mkoce3lY0YQh1lgB5NE y/GXYFVsAroSUxZ/A1vOK2AnMefPThYQm0VAVaJz2VJGEFtUIELi0LHbzBA1ghI/Jt8Dq+EU sJf4MKUf7FhmAUeJB4t2skLY8hKb17wFO0lC4Ce7xPc184CKOIAcWYlNB5ghfnCR2LhnNhuE LSzx6vgWdghbWmLVv1tMEL3djBLfm1ZADZrAKPGzYQNUt7HE/Qf3mCG28Um8+9rDCrGAV6Kj TQiixENi5uGLLBBhR4kdbbqQQD3MJDHjosUERvlZSN6ZheSFWUheWMDIvIpRLLWgODc9tdiw wEKvODG3uDQvXS85P3cTIzjhatnsYLx0zucQowAHoxIP74S3JRFCrIllxZW5hxglOJiVRHgV 2MsihHhTEiurUovy44tKc1KLDzGaAoN4IrOUaHI+MBvklcQbmpgZmhiZGBqaGxkYKYnzLmu0 jhASSE8sSc1OTS1ILYLpY+LglGpgrNyr/2faX88tHxIZZ/ctOv/D+Lnj330KN1KU3r4TZq1z Dmaf3uI7ge30+z3cm6aHcni7MFjePjdtir38VMttP66qHws6JbRjBvPULROWPjy25Hdz8VKF t2FK0c+bpCochFY6OTyc/imf02jjHPYKTzOFLiOz5pkLFbxvJL94fGPVe7ty8WazCiWW4oxE Qy3mouJEAJyNKdvOAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJIsWRmVeSWpSXmKPExsVy+t9jAd1KjrIIgxOnjS1urTvHatF77iST xfYjz1gtrn95zmox/whQ7MrX92wW75d3sVksndHHajHp/gQWixu/2lgt+h+/ZrY4f34Du8Xl XXPYLGac38dk8X/PDnaLn7vmsTgIeOycdZfdY9OqTjaP7d8esHrc7z7O5NG3ZRWjx+dNcgFs UW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZKEbq+IUFKCmWJOaVAnpEBGnBwDnAP VtK3S3DLOPe/h7ngtGDF3KeTmBoYZ/B1MXJySAiYSBz9sJYdwhaTuHBvPVsXIxeHkMBSRokf W7+zQjj3GSXezvvNBlIlLJAscXTdfBaQhIhAJ6NEx4+l7BBVh5kkJrb/B2thFtjBJLH3zxKw FjYBXYkpi78xgdi8AnYSc/7sZAGxWQRUJTqXLWXsYuTgEBWIkGg4nA5RIijxY/I9sBJOAXuJ D1P6wcYwC9hKLHi/jgXClpfYvOYt8wRGgVlIWmYhKZuFpGwBI/MqRonUguSC4qT0XMO81HK9 4sTc4tK8dL3k/NxNjOBofia1g/HgLvdDjAIcjEo8vA9elEQIsSaWFVfmHmKU4GBWEuFVYC+L EOJNSaysSi3Kjy8qzUktPsRoCvTHRGYp0eR8YKLJK4k3NDE3MTc2sDC3tDQxUhLnbZz9LFxI ID2xJDU7NbUgtQimj4mDU6qBkTdu31PxUobg6W1ODTb7ps92837E51fAXL/+4NZ9pyZ8qt70 +pX4XEaWhYV/NVYoh+XtL9x8aQ6H0/n185afmRO+0njuHNegz69Ya57f23MloXND5MdJef8j PKsfNfOeEblds3+yUfEWD8Y1CXtqnpssPBtfcvl096cDFp7pGzR8rRfbnL4bU6DEUpyRaKjF XFScCADqSWeX/AIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170111102705epcas1p11a9c1262d4dad16a38d0a6e9e4065f93 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzMo7IKs7JuQKS/sgqzsm5A=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTMy9Bc3Npc3RhbnQgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 X-RootMTR: 20170111063408epcas1p4b29b1308a0b8088afd46a475770d4b00 References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-4-git-send-email-hoegeun.kwon@samsung.com> <2f362dda-6c57-6aa4-5572-b27c34c4c78e@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2017 06:51 PM, hoegeun kwon wrote: > > > On 01/11/2017 04:46 PM, Andrzej Hajda wrote: >> On 11.01.2017 07:33, Hoegeun Kwon wrote: >>> From: Hyungwon Hwang >>> >>> This patch add the panel device tree node for S6E3HA2 display >>> controller to TM2 dts. >>> >>> Signed-off-by: Hyungwon Hwang >>> Signed-off-by: Andrzej Hajda >>> Signed-off-by: Chanwoo Choi >>> Signed-off-by: Hoegeun Kwon >>> Tested-by: Chanwoo Choi >>> --- >>> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> index ddba2f8..6d362f9 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >>> @@ -18,6 +18,18 @@ >>> compatible = "samsung,tm2", "samsung,exynos5433"; >>> }; >>> +&dsi { >>> + panel@0 { >>> + compatible = "samsung,s6e3ha2"; >>> + reg = <0>; >>> + vdd3-supply = <&ldo27_reg>; >>> + vci-supply = <&ldo28_reg>; >>> + reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>; >>> + enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>; >>> + te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>; >> The same here (as in 1st comment) , te-gpios should be dropper - decon >> uses hw-trigger. > > Hi Andrzej, > > Thanks for your quick review. > > Reasonable to remove te-gpios property, > The Tizen public already has [1] your patch applied and te-gpios removed. > So I will add [1] to the V9 patch. > > [1] > https://review.tizen.org/gerrit/gitweb?p=platform/kernel/linux-exynos.git;a=commitdiff;h=468769bf6abbaaed2547b8c43e989ab5dc787900 I'm sorry URL address is wrong. Correct address below: [1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/commit/?h=tizen&id=468769bf6abbaaed2547b8c43e989ab5dc787900 Regards, Hoegeun > > Best Regards, > Hoegeun > >> >> Regards >> Andrzej >>> + }; >>> +}; >>> + >>> &hsi2c_9 { >>> status = "okay"; >> >> >> > > >