From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02D2C281377 for ; Tue, 22 Apr 2025 13:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745328139; cv=none; b=sTnPBP7+ywb9cWg3B9TU4XdsxH6UTliRvXJ4/Puw7N2R9z5UdRjWPc550fu+gcGmuN/NTo5mwUCxVsc86nyehy5CqogaG1srU+J0fkODrm98/WjHRKs+CQtwChgmuUpEZxhr+AptRRvS1cPn55vuWuPb3tnO+Jz+pNWtD7f221A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745328139; c=relaxed/simple; bh=iBeERhynzVtABJ17zsJg2c4wme0BjEpBgTwXNfdYvBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s24ARNXSv0kZpIwZQQ383GKT6j1nYYdiZ7AwTQ/mwCj2jagje3AQs9uXu/FeUIldEpcn+1JKwwh8hRzYIgueU47ma7EQ+KPDbCglCQgavJ5zd14Ic2SO5C1DTBQYZhJV2TNodBj93MpmE9afzrZCRcbqo2buP0o7BFJFB0cEoPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=dkcpLLjr; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="dkcpLLjr" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ac2963dc379so762672366b.2 for ; Tue, 22 Apr 2025 06:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1745328135; x=1745932935; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N3XNp6FOG0YBB40BSQ5b9F0xQ6kk+DLGoBOj2lK3UkU=; b=dkcpLLjrEpCHq1nKnXuvvnE7Ty4INfDd501NyXXelhCX068hkJZUQFJ2WtGlJxJYwb 2UJj0GgcisWHxN74+x+RBnf7Lj9iYg5CVEMq7BgG7Hmja/RTtO79Y9yxRjiDqfgOHTXa Ise0dlanH071NWrvuKch+JiakrzjohIzbzBdjyxMxwERMGz+R0DO+zg3V74FjSX58qJs Hs5onzICDyTxD08TCTQycBc5Lxpnq/538QXDGfTYnb89zuSI6YnLHlhxQZKWLYHNVZgp AyxzcjIKOlBHAR4hQ9ZgdcaKXxb9E118KROawqpHJzJ7fTeDG3mdqWOzp+d3pm/WGuT5 1FgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745328135; x=1745932935; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N3XNp6FOG0YBB40BSQ5b9F0xQ6kk+DLGoBOj2lK3UkU=; b=v5LFJsKEiyygxqCM8x4WCIuwIIasKKE3R9M+JQKY7rwbh/xynxUs/ueKt9XFh+6dgZ hwAdH2SqGM2N4ryxnxkB08w/7Uiwf4XzD4BsmUXIlMpG8kfRZoOLivWib3k6WDjb/vjO 7D++nZSA1FShwgWR71H5W+Ee6UJ61OwiTijeNm3KCXZgzd48vrjlAP3xvv9pMur3qYnq JttB19lhwBpbbd7i4JijKG2O6nlHmALR3e7kKkpdaJZ1K4fRJyseJ0sedo8bKz0WmHF7 tuw1NSPzEJLlwK/uQBRWFu2P7JZ66rsoSk5M35eu9MDUBWfKZpB9nDARcKpJ226k818E KFkw== X-Forwarded-Encrypted: i=1; AJvYcCU9lMwGWqKM3Pzos/ueD2njaPBbzVoCbVP50zmt2sHwKTVnyhL7rS+fyL5ohNnuhi7mWJFfvoBHLVQkfz4=@vger.kernel.org X-Gm-Message-State: AOJu0YwuRFlTa7Bz1TbEHixbp0V/jjxWXmDPbpUYJfEYmAzJU0aNG6Id eixzLoQlCcs0b56cVwMXe5cHg/5qEi/NPR1IndOsgparV29+Ik34Bzclj4cW2sI= X-Gm-Gg: ASbGncvFgxaDRdD4LT7MChQZvOrsUwbPovB61W2fdQk8/OPHaRnUtUk8wIl8sTQZP3q AEQ/GOkqnjNedIHcOGzqL+MsN/C5l+YetDS2gvFuSY7VA8SRYGjrmiPahh0ExuMe/mFDkE3r2Zm k7EKf/A/c9fWljtsBJQMR4pCU/1NdTjf+eoN+aX8QaGY4Tep2sZeIQLI3Og2rGXDbz0LoeIQ5Cy 2mSEmhX/OsbpZrIonNPfKRB5hWFoEYPtYhB7YsKOGEbxPMQ4wxPAYIZ3/w7m4IIJUPlEKvyktKK I/3W+gMIsT0lMdO+RM//1kONQCc6TD2OjsLTYwN4nbY= X-Google-Smtp-Source: AGHT+IFaXpflFI86k8u3dSw6HVkF/uY8OBEaZ5S2zW87LgBRnFduZGRJWQUonbqQbt0m5a26poCJnA== X-Received: by 2002:a17:907:9727:b0:acb:5f9a:7303 with SMTP id a640c23a62f3a-acb74bcc517mr1311357066b.35.1745328135152; Tue, 22 Apr 2025 06:22:15 -0700 (PDT) Received: from [10.100.51.48] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb6ec0b6fbsm668648166b.19.2025.04.22.06.22.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Apr 2025 06:22:14 -0700 (PDT) Message-ID: <7f707d8e-f2e4-49cc-8d7e-e8c4c4193cec@suse.com> Date: Tue, 22 Apr 2025 15:22:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/3] rust: extend `module!` macro with integer parameter support To: Andreas Hindborg Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Luis Chamberlain , Danilo Krummrich , Trevor Gross , Adam Bratschi-Kaye , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Petr Pavlu , Sami Tolvanen , Daniel Gomez , Simona Vetter , Greg KH , Fiona Behrens , Daniel Almeida , linux-modules@vger.kernel.org References: <20250321-module-params-v3-v9-0-28b905f2e345@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250321-module-params-v3-v9-0-28b905f2e345@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/21/25 10:17, Andreas Hindborg wrote: > Extend the `module!` macro with support module parameters. Also add some string > to integer parsing functions and updates `BStr` with a method to strip a string > prefix. > > Based on code by Adam Bratschi-Kaye lifted from the original `rust` branch [1]. > > Link: https://github.com/Rust-for-Linux/linux/tree/bc22545f38d74473cfef3e9fd65432733435b79f [1] > Signed-off-by: Andreas Hindborg [...] > --- > Andreas Hindborg (3): > rust: str: add radix prefixed integer parsing functions > rust: add parameter support to the `module!` macro > modules: add rust modules files to MAINTAINERS > > MAINTAINERS | 2 + > rust/kernel/lib.rs | 1 + > rust/kernel/module_param.rs | 221 +++++++++++++++++++++++++++++++++++++++++++ > rust/kernel/str.rs | 170 +++++++++++++++++++++++++++++++++ > rust/macros/helpers.rs | 25 +++++ > rust/macros/lib.rs | 31 ++++++ > rust/macros/module.rs | 195 ++++++++++++++++++++++++++++++++++---- > samples/rust/rust_minimal.rs | 10 ++ > 8 files changed, 635 insertions(+), 20 deletions(-) I'd like to pick these remaining patches on modules-next around rc5/6, so they can sit on linux-next for a bit before going into 6.16-rc1. It is a new code with no users so I don't expect much fallout, but still. Could you please post an updated series that includes the cleanup from Miguel? -- Thanks, Petr