From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4428530E830 for ; Fri, 12 Sep 2025 18:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757702442; cv=none; b=hOe79qMq/qBjsCG8pegM9mNl9uXwjusyJRgc0qmQ8qyje+oTXf8BoF3wrK4raF8LDHw08I4P+NQQBabe25ee+bLh46Ku58sm+cN6nIRA2ItcG8+ULZ62jbiNnKEBuAdqfX9ppnjBQPQS92XxQfOehTBnm8ngnNTDWnbPWgl/X3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757702442; c=relaxed/simple; bh=k00K2WIE6Ewqt/eZ5d9m+rjyZ1/wA4exwontTQ1IGR4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pUiAevNhCCZ9wpv/pQU4wQubYHXLaO97MKVur8TO+SvK9k/B0byfpIXGs+mO8Qjf1c6/s+0yesN9cyBcjvtOdAhRZhuwldWSJJRtb8WqtC3Z0ox+qNhF5SufRFYw/Jz6mbcVFtigWwlMNj2Zm0U1qXI+Esx0d5YdrMS/08djWt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=Xo2q4+PC; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="Xo2q4+PC" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-61e73b1544fso897030eaf.0 for ; Fri, 12 Sep 2025 11:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1757702439; x=1758307239; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fr6WpPJO26szNguY0sxPUuMJDw0v1LfC514tjVSDNIA=; b=Xo2q4+PCeo9u4UTGCA/pyhbJ2Ss2d9msCPz/2nL2xbx41Yscvra8tzBC/hMA3bddBT PmnR09Yg7aqut0dIWwmPN193Cv3KWu+uNaIxWqtQZwS2/wNXDyqRnAAil0SzV3PGp7Ml pUsUTuzBeN5HPRUFXv06/quJcOZg2KJ73Xy6H5nbT6guCkUyFex7sRgQkQTXE77FvkRt rsxd0ewM6kjN/8VaeuLsW3njBby6Dp5W/iieMo3Jz2GEE1YXhTWv+KrGWLO8XeQ0trV1 JEhj4HA2ckJRuKDxHY7SGz93uNCjBOw0PCJzEl+cGcEZfAtUvZlQamDBy11YuAZTTkIJ mjLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757702439; x=1758307239; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fr6WpPJO26szNguY0sxPUuMJDw0v1LfC514tjVSDNIA=; b=iFswpIJKhoXZxqh1Ew5ixAlt5bqaFk5HMaKcBrDQiq//cDWT2VmkQKOEIAemN4cKGN rHC5M22kzfjtx0qLyfHMfSmEaxU6a7zv2q1hPkYjGG3kl9FlCa22g7YQrVF3eV9kOu20 mndSXqICo6UXkyq5sOl6Z7zoCLe+mEJ3Px04T6cK97QJlevdNgr5zLIDwVzG2i57npnY K2XOEfsJ8UbPkcd9hbu23qQdpX+4xmnc7kKPlsCVmhBkzBtiAw19KQHw+PeE0Gf6GkJR TDl3YwJ9tZADB2DAwG6EsPuZL306N8LxbgQeNAt3I9d4E+vIdYz3MEX+oSdl27WebCjS USOg== X-Forwarded-Encrypted: i=1; AJvYcCUF+M7MpbbLF7WTFyYWRDLKc7PbB+Z3cPMdwBgLv8Q9ul6ZgXGj6z2GeBmu8MCeLLc+ZhsKqKxDisxbC0U=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7QnLqegalB8arexxo2eoMldAzWDjA6PteSe1ff0vVve5iaSVa /Kq5s1C7/Cos0i+v12tleodUVtaaTmEDqldbB5yORd14uAwy1tQ2Ck5dpuhx9aB/qPw= X-Gm-Gg: ASbGncui0uPxDRnKSccskUXgwh1MMOKjkkvc9ONjEHdW2VlTLYZlEgKSiFCgu6yESvu QQ8GLMWGnKUAv/v6j9xVreJ8lIxE2nM1xFhGVuMaB/hvfa8H/jiU0cddmBvBXeGQbRiD8cnrHjG lDTmk/Wog1TiJrlfCvU/utnfiHwd2qgGc1LJk/DyffILeQB3x9zF4R8ixbQzq9sf8Yfcszs8htO UStkDwEL7xkAqbGRz+HY76RGl9JZA33dyTgcZLijCMAYKHQFvr+GGgtEVSz5njRExFqVFdrVhz6 BUxSyyHRl7Dqa/SmJQxvZ2Etj/+qgzOcnPtd4RFh/A3JBl8qwNgFszo9z3ZTMW9vQUOUewWQLx2 9th2gIOUFqomHX3/iAER7aJ0aSAp4HjsuEBlIcLhW1JWZ2vnHBoB34/p/t1gu8WEhobjvZ/Iyyq ytdBRLhSYPUA== X-Google-Smtp-Source: AGHT+IGYgWI504crkZYqNYG2WaIQBqGpslOWvuZ65zJIIsRR4sKsnCoCflMDuHLa29qJHSoMBvw4uw== X-Received: by 2002:a05:6808:2389:b0:43a:2e17:3b98 with SMTP id 5614622812f47-43b8d88e3b4mr2010278b6e.7.1757702439155; Fri, 12 Sep 2025 11:40:39 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:fdf1:f11e:e330:d3c1? ([2600:8803:e7e4:1d00:fdf1:f11e:e330:d3c1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-43b828d2eccsm916131b6e.6.2025.09.12.11.40.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Sep 2025 11:40:38 -0700 (PDT) Message-ID: <7f71c489-410b-4fdb-9d78-9f2835c32379@baylibre.com> Date: Fri, 12 Sep 2025 13:40:37 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] iio: buffer: iio_push_to_buffers_with_ts_unaligned() might_sleep() To: Andy Shevchenko Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Lezcano , Andy Shevchenko References: <20250912-iio-doc-push-to-buffers-context-v1-0-c4aad013d96e@baylibre.com> <20250912-iio-doc-push-to-buffers-context-v1-2-c4aad013d96e@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/12/25 1:10 PM, Andy Shevchenko wrote: > On Fri, Sep 12, 2025 at 11:05:53AM -0500, David Lechner wrote: >> Call might_sleep() in iio_push_to_buffers_with_ts_unaligned() since it >> can allocate memory, which may sleep. > > It can or does it always do? > If the first one is correct, better to use might_sleep_if(). > Just below this in the function is: if (iio_dev_opaque->bounce_buffer_size != indio_dev->scan_bytes) { void *bb; bb = devm_krealloc(&indio_dev->dev, iio_dev_opaque->bounce_buffer, indio_dev->scan_bytes, GFP_KERNEL); if (!bb) return -ENOMEM; iio_dev_opaque->bounce_buffer = bb; iio_dev_opaque->bounce_buffer_size = indio_dev->scan_bytes; } Would it make sense to move the might_sleep() inside of this if statement rather than repeat the condition in might_sleep_if()? devm_krealloc() is the only part of this function that might sleep.