From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7333009F1 for ; Thu, 27 Nov 2025 18:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764267823; cv=none; b=szkgURasxRX+bcjXT7P+sTn7uk+Z6Cv6jPRMtJM8JDoG8aN3+q58AzwCsZkwKkdNeNvyWXd/24ILsNmQMzoLso67o4w8Km7S1GoBQh7OegmC14fZs6IAMe8xpzG63aqmEnqEnZXACD4HbE0Oh3OiRIf7L0GCLClLj3QkTBNjCrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764267823; c=relaxed/simple; bh=pGvZ5SattYYHOiHhfNEXrMAp3ftWVa2ZtWqec5muQN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aoo1qSby50PzyKVqLOtaO7XNHlSY3B08wGvTfVLInUARlK/tl9ZJ4Tmh+2mq/YT/hf7xj08YU2iAtA7I88xCzWxt6dF5Nu8Lxb4B8PI14TJ2+Jpl4+awlFIDAf6rAyvTby8Oewwnnb1jabC8TTeSq+cSScCTg2HiVOwvnSQIXY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PXlJnZee; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dvsuagI3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PXlJnZee"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dvsuagI3" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AR9ULc5685782 for ; Thu, 27 Nov 2025 18:23:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IUchDNtUE84gJY1BIo7DyrQV1aOljy5HhZHPH/qoZ3s=; b=PXlJnZee5fix1eQK pWveOSQUVQ9grdsqlTkS+zIy108BabjuXjxPuOsqyiYBucii8BzrHecpPMnd4NAV HA86O6byF+UPp6aOC2fs9lZ645L31XPFcsiVeQd4mq5Jm7XXYF69pbdiRM35LBAK 68wF9DNvKx/5KTdT6L8KkzYh/f7fZQLRoKVI0qHl4QQ9d2iJ96u6j8mH9Hi76nWO LFDmAQOhY5O5AGhbcnqPC3Rjn0aGEWLwIUOtmo4KZ6EjCSL9OaPVhtKysOBT+nYY fUkfAQ0aqW2WGgXnO0u/ykh4eXil64dYmtLIC3Rq8m5TlDr1qSONFDrh21GP9hRG 1hQGMA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apm2rs9ga-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 27 Nov 2025 18:23:39 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ee0440a771so977111cf.0 for ; Thu, 27 Nov 2025 10:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764267818; x=1764872618; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IUchDNtUE84gJY1BIo7DyrQV1aOljy5HhZHPH/qoZ3s=; b=dvsuagI3vuPnHVUahwXkQQLIRKMAsQ8brhdflkTLxuRT43emA55l7pKWrCEYQ4cSEa NhbQkWQDQwkFzlST2GHATgzAH7SjiussP3S1rJEy/DJxLT+QzbRsdMit9MqEFCLKKbSg nAyxy9Dkq52IC8UgovtcaSI7AgscJJm679rwIuW2qU+b8nY7Z+Fnmmkp2ZQXznJlziOi HOUge5NvfGDt0cdnhLh2mbBJzSk5L/kcx0CszUnjYDZMgzJajapRhe9pQzn+u+xXXnPM +pYwAeRoqX/IVsdziPcAfR7FPCzKogxS68KBC6Bgdm4KgNxzTTVRlZtnadsusEZ3u4x5 mh7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764267818; x=1764872618; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IUchDNtUE84gJY1BIo7DyrQV1aOljy5HhZHPH/qoZ3s=; b=YswpQKild3vzcYLCXUAg986iwLxeU2LCRGqRcw7voiAJ8KqCKmT7qZY1PFUlcyYl5N 09xqXAKS+9+1kN/BeIbnPR5+7ncFPao+ASc4uxTScvU36nBH1piJ3CWemy3PrvkP4Ek1 Jj3Mn4sYDcGWMhjRQP7YfK5zhTQpVDar6PogFb2W/sLT+XQyeB3y2/aAqnI7iTKQ6pSI 8vaFXc0qJZa730ZlzS2242oQGXSIIZjZdEYsunLucTZ/bc8pk7QBkp9V2BgA2SLPoYel WrrmWTn0eITVIYKF9szV/m3MeeB/D2wNkmDL3epR7EgpRPeJ5ErDdDMxoJ5lUkjeE1o2 9WDg== X-Forwarded-Encrypted: i=1; AJvYcCXHbImudwE++7IrXTBmJCxdcHb5q7ep9QXIT3ZZu/QpfhEPO+aiZt3P0YBT0OL99nVF6OGiI2rri/JzhqY=@vger.kernel.org X-Gm-Message-State: AOJu0YzOksw31GmviqGEkjdC6SoAuzfsTGFRzOsY3uzFyG0Q9AsOmYu0 ww7rzb409ApgGPwd4Nrew746YUAbnBPsOq8PYsAu6EAj8hqI6kuP+Kmuzhaa1bg6CAmFuL33zz6 5UCWRQxwSW4XHqSH+UcvUxIpBGEiXSudizrJNc7Aw/LnHILBFSnQNZDGDHhaeFalAkAo= X-Gm-Gg: ASbGncsubz+U5RxvlcLKMmB7Bw2IOlGfZrAd7n8HFYlNI6cxhY+VOAP4SLc7Px+MSRU lPmpOGS7TT9X1UVZJ8SkavT7vqso4gWMY3XvMDRy+Sr7SiolMqHVUtSuOew4h7H8a7CKFgMpGLm HYw3uZpQ6LlDcxNH3Bd9sbG9nJeJr8jxMEPNs0cbcsK300p3+mfTCrzXFSvfSqcHO1kUDj1GWxP SNrx03EPb1lo5mg4KLEqqqrmJDW8xXFw0w3XOVq33qe6JiNC9XVboSMKNeoR2oSUJW/agEP3Ypp 1IN0Tu84Qk5vZA0BgR8qIlKB2mBPPUX/I0s4oifzmO1ZBJYOhk5SWc4VOo2IR8bx4jjA6RPG5D8 EVblPf4ushjPCxhNR69M868eZMSPGMdh/HiBPdInenS2YMjB1O6omeGka/hXRgEizb9Y= X-Received: by 2002:a05:622a:48c:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4ee5b786a91mr241586011cf.9.1764267818320; Thu, 27 Nov 2025 10:23:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFeMQ9EMbLd3D677mJIIOmwB+k9eDLur9GvtzjsK1+MSFnfAPwRig3yaBnk8ECV9phL4g1Bg== X-Received: by 2002:a05:622a:48c:b0:4ec:f9c2:c1ec with SMTP id d75a77b69052e-4ee5b786a91mr241585631cf.9.1764267817872; Thu, 27 Nov 2025 10:23:37 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64751035c3bsm2094550a12.19.2025.11.27.10.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 10:23:37 -0800 (PST) Message-ID: <7f723f9c-93f4-43b2-8421-7af5f697c752@oss.qualcomm.com> Date: Thu, 27 Nov 2025 19:23:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: Fix a7xx per pipe register programming To: Anna Maniscalco , Rob Clark , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20251127-gras_nc_mode_fix-v1-1-5c0cf616401f@gmail.com> <58570d98-f8f1-4e8c-8ae2-5f70a1ced67a@oss.qualcomm.com> <951138f1-d325-4764-a689-e1c3db12bb90@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <951138f1-d325-4764-a689-e1c3db12bb90@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI3MDEzOCBTYWx0ZWRfX99+6aU5qy5IN kl3wOJEOlnDQIw/MBUeGl2v6AyLKCOMN2x+yuyc3q/xLAmaQp9zswaWRg75pj/ozB+MWwC5VRvU D9H689YKjgfsKlcNi2w+zG0EI+LBplwamHrDzG+0H3kOaDZ5f3TTVsN/3GBj2YarZ6AE1/VLrsK FNLhJvnYKDx2Uo+SePQp7zRgP/1D/aWE60Q7WbUVBsazY2ZPH7roROui7fRPyIpkaM4TpiVC5Kd tSue3mdHRKyIt+2EBiOU3Tj7LG5nOx+Xyv4RExm2UJ1wQHiIrPiQfEW7YsMneQMAluUMUDuDtCw 1P0Mz4d787oIo0eVoNym/UfP+5UXxLk3FVncEclv8D3c34II7TaZQi/kuPjekXtKNJTg/5nEiXe RqatQAMDZRhM5I3sYB4j1vNplQ1nww== X-Proofpoint-ORIG-GUID: FX_oO47RTnzEl3aLprpjNkfzNxAgC3XI X-Authority-Analysis: v=2.4 cv=W941lBWk c=1 sm=1 tr=0 ts=6928972b cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=pGLkceISAAAA:8 a=6nOnMbRXApaOt5cKipAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: FX_oO47RTnzEl3aLprpjNkfzNxAgC3XI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511270138 On 11/27/25 7:14 PM, Anna Maniscalco wrote: > On 11/27/25 3:25 PM, Konrad Dybcio wrote: >> On 11/27/25 12:46 AM, Anna Maniscalco wrote: >>> GEN7_GRAS_NC_MODE_CNTL was only programmed for BR and not for BV pipe >>> but it needs to be programmed for both. >>> >>> Program both pipes in hw_init and introducea separate reglist for it in >>> order to add this register to the dynamic reglist which supports >>> restoring registers per pipe. >>> >>> Fixes: 91389b4e3263 ("drm/msm/a6xx: Add a pwrup_list field to a6xx_info") >>> Signed-off-by: Anna Maniscalco >>> --- >>>   drivers/gpu/drm/msm/adreno/a6xx_catalog.c |  9 ++- >>>   drivers/gpu/drm/msm/adreno/a6xx_gpu.c     | 91 +++++++++++++++++++++++++++++-- >>>   drivers/gpu/drm/msm/adreno/a6xx_gpu.h     |  1 + >>>   drivers/gpu/drm/msm/adreno/adreno_gpu.h   | 13 +++++ >>>   4 files changed, 109 insertions(+), 5 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>> index 29107b362346..c8d0b1d59b68 100644 >>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>> @@ -1376,7 +1376,6 @@ static const uint32_t a7xx_pwrup_reglist_regs[] = { >>>       REG_A6XX_UCHE_MODE_CNTL, >>>       REG_A6XX_RB_NC_MODE_CNTL, >>>       REG_A6XX_RB_CMP_DBG_ECO_CNTL, >>> -    REG_A7XX_GRAS_NC_MODE_CNTL, >>>       REG_A6XX_RB_CONTEXT_SWITCH_GMEM_SAVE_RESTORE_ENABLE, >>>       REG_A6XX_UCHE_GBIF_GX_CONFIG, >>>       REG_A6XX_UCHE_CLIENT_PF, >>> @@ -1448,6 +1447,12 @@ static const u32 a750_ifpc_reglist_regs[] = { >>>     DECLARE_ADRENO_REGLIST_LIST(a750_ifpc_reglist); >>>   +static const struct adreno_reglist_pipe a750_reglist_pipe_regs[] = { >>> +    { REG_A7XX_GRAS_NC_MODE_CNTL, 0, BIT(PIPE_BV) | BIT(PIPE_BR) }, >> At a glance at kgsl, all gen7 GPUs that support concurrent binning (i.e. >> not gen7_3_0/a710? and gen7_14_0/whatever that translates to) need this > > Right. > > I wonder if gen7_14_0 could be a702? No, a702 is a702 in kgsl Konrad > > If we do support one of those a7xx GPUs that don't have concurrent binning then I need to have a condition in hw_init for it when initializing REG_A7XX_GRAS_NC_MODE_CNTL > >> >> Konrad > > > Best regards,