mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikolay Borisov <nik.borisov@suse.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Daniel Sneddon <daniel.sneddon@linux.intel.com>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alexandre Chartre <alexandre.chartre@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sean Christopherson <seanjc@google.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	KP Singh <kpsingh@kernel.org>, Waiman Long <longman@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v2 1/3] x86/bugs: Only harden syscalls when needed
Date: Mon, 15 Apr 2024 18:27:09 +0300	[thread overview]
Message-ID: <7f7df1f6-345f-4062-aa00-40c260b14040@suse.com> (raw)
In-Reply-To: <CAHk-=wi0QrKuxQQmNsJhn5rE9Qe-Cz_9NsJOcOM1FK+knLeAFw@mail.gmail.com>



On 15.04.24 г. 18:16 ч., Linus Torvalds wrote:
> On Mon, 15 Apr 2024 at 00:37, Nikolay Borisov <nik.borisov@suse.com> wrote:
>>
>> To ask again, what do we gain by having this syscall hardening at the
>> same time as the always on BHB scrubbing sequence?
> 
> What happens the next time some indirect call problem comes up?

Same as with every issue - assess the problem and develop fixes. Let's 
be honest, the indirect branches in the syscall handler aren't the 
biggest problem, it's the stacked LSMs. And even if those get fixes 
chances are the security people will likely find some other avenue of 
attack, I think even now the attack is somewhat hard to pull off.


So in any case this could have been a completely independent patch of 
the BHI series.

> 
> If we had had *one* hardware bug in this area, that would be one
> thing. But this has been going on for a decade now.




> 
>                Linus

  reply	other threads:[~2024-04-15 15:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 18:10 [PATCH 0/3] x86/bugs: BHI fixes / improvements - round 2 Josh Poimboeuf
2024-04-12 18:10 ` [PATCH v2 1/3] x86/bugs: Only harden syscalls when needed Josh Poimboeuf
2024-04-12 22:42   ` Pawan Gupta
2024-04-12 22:58     ` Josh Poimboeuf
2024-04-15  7:32   ` Nikolay Borisov
2024-04-15 15:16     ` Linus Torvalds
2024-04-15 15:27       ` Nikolay Borisov [this message]
2024-04-15 15:47         ` Linus Torvalds
2024-04-12 18:10 ` [PATCH 2/3] x86/bugs: Fix BHI retpoline check Josh Poimboeuf
2024-04-12 23:18   ` Pawan Gupta
2024-04-14  9:19   ` [tip: x86/urgent] " tip-bot2 for Josh Poimboeuf
2024-04-12 18:10 ` [PATCH 3/3] x86/bugs: Remove support for Spectre v2 LFENCE "retpolines" Josh Poimboeuf
2024-04-12 18:20   ` Josh Poimboeuf
2024-04-12 20:49   ` Andrew Cooper
2024-04-15 23:44     ` Josh Poimboeuf
2024-04-13  4:21   ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f7df1f6-345f-4062-aa00-40c260b14040@suse.com \
    --to=nik.borisov@suse.com \
    --cc=alexandre.chartre@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jpoimboe@kernel.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®