From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10EF1273D8A for ; Tue, 5 Aug 2025 13:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754400022; cv=none; b=EE/2EA9hyEQnhAOxK4ijgTU+SuKUu3yyBdemW7+1BAG1I9Bw1gPLXgR7EBzqO+eTZszqTwFx7syEAj/KIQcgDEDPdEGbqXty4LLsWqteSs5Nuklbwjfnidf0UzCpF2FY4pqiEaLwrxtLorZD/c8cxiTI7Wsk5cfzZIQcKWuwtoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754400022; c=relaxed/simple; bh=tYJvxdCeY7jHdo9+2SPYOrrLtTf+3JxPLPhDqYP7Q6k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L922MFxT7YfoUzsOMGB5Qg4NCP/UdgYUUGJ4YrPhOK7UXikrRCNJHKSnGg9jrxYNuMAkTx8SWbEfbRuavLBNiED3951ImHLwNYJ3we5pwYNKtVpXvhzQZaBtZRjWov90wt+dzAGEEjp0Hfeg0//f67LU0dp1dwBgVJKrFNCrDFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Oyu9WqdI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Oyu9WqdI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754400020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7mkNf0QI+/l3vgY9WFXkpDJsfJ5ONkpFseS6VcEocjA=; b=Oyu9WqdIzbg8Gv0RO7AaxK71sFBcvTbEzR0HDB3XUjco1IP4r0rXx94Ot7c+mdIk/4qhfx sGmZ0pVG+gG3cR7L57IBEZwoO5dYjqBicP5gccTiCAX+G9VaVpS6uHKeCiple6hK5Pa66Y eJ6/kWmIHXYkOX0w5Sgc50PxLWz3d6M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-uYMP2Am-PlOoiB6GlDPKAQ-1; Tue, 05 Aug 2025 09:20:18 -0400 X-MC-Unique: uYMP2Am-PlOoiB6GlDPKAQ-1 X-Mimecast-MFC-AGG-ID: uYMP2Am-PlOoiB6GlDPKAQ_1754400018 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-459db47f138so5803465e9.1 for ; Tue, 05 Aug 2025 06:20:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754400017; x=1755004817; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7mkNf0QI+/l3vgY9WFXkpDJsfJ5ONkpFseS6VcEocjA=; b=KBYN6rcejtKTN48u+ycW39HRVmgRCYc2cDaF9ABknnlybWhvomZS3LkMBy3Duq6lJj NXm3UzVy2OFtbXnzmF1KrOYAVlclVPBlIdUPEw2fHddFEvLGvAtYA1LY+Betp4kl5aEz wJFdXeSFsRNCQH8bAnDIou6znDBqK6v8YS0wCZPmtpl9w5K59//bcRiWF1C2zMmAKn36 RYUQLqyn/XG10fWgC/faqThmyf6dqvRGrleULt//Xir6+eFKaXvL1PZEi9ln9new6N9B jQLGuZUEZmC5oZfQaZ555vFQYq5WaTmdWDezc4bu7Pzl2EmUyJ4fuOWPKGIVfxjlJ3pl vpZA== X-Forwarded-Encrypted: i=1; AJvYcCWwkiTzSGROTmGVdnvkw6OmPVi9YZppstHjVfa2qlhOqVZBw6E8SWO+93por+nP6R0CVYsJw0rVqssGZys=@vger.kernel.org X-Gm-Message-State: AOJu0YwAPlQ6FY6/YjI821JPv4CFmcJW5g9XV4FiCg5O2e2AuGEU1cQ2 1aZ0/e/GZSz0UWNFK1ZyWdsj9f8WE/dQ4ydrgm62XLd1Q9/7OeMl2bI/1eV5JUPD8B2vX43Uf/5 WYanAha0flYcHEQt7q/a1+pD7tDgoNj1eQKlJHw18L+2KxqoAvlsbr19T8raQq584QQ== X-Gm-Gg: ASbGncsCTv/gaLbct8+u+PAV4E8UU1+4Qhc+mEylyc5x00MYHBxFrcBLJO6qut4MDSH 70RWsbN9pvRNQWJLpJOP0AHRgOENlRFhKlYe8zj3L4G5yu37LdeKVFLurFbB2JXjR8ZXSUkN20Q L5dxmiKpwF+ONK2COcSxyw9Zq26VM8K6LB7muCPf7aHeLa1t5yhp9fzMI6ExyDjPuYLeTsIln9z rvxwuhAPrAwcvWY3X76akesfPjzXDK0cwggmcgBW24K6br9UWseJX0/zCAg9fIRBh1ktQo+zMVr X4i6T7r+2Aw/IFOmL8TlxrSW1k7rGdZNCVz6uFAA8296p1fIfWoOyv3JHIZF7DkYS5W2ZW8= X-Received: by 2002:a05:600c:1c83:b0:459:e025:8c5b with SMTP id 5b1f17b1804b1-459e0258db5mr42603265e9.30.1754400017481; Tue, 05 Aug 2025 06:20:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVgPpUrWhDk4+rzhzUgTeLAtVV6f5qNYycM6PgZU7uhhuYDXzpHLYFGlAp6Ltq2vL8/bKyTQ== X-Received: by 2002:a05:600c:1c83:b0:459:e025:8c5b with SMTP id 5b1f17b1804b1-459e0258db5mr42602945e9.30.1754400016964; Tue, 05 Aug 2025 06:20:16 -0700 (PDT) Received: from [192.168.3.141] (p57a1a26f.dip0.t-ipconnect.de. [87.161.162.111]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4589536b3b4sm247994685e9.3.2025.08.05.06.20.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 06:20:16 -0700 (PDT) Message-ID: <7f891077-39a2-4c0a-87ec-8ef1a244f7ad@redhat.com> Date: Tue, 5 Aug 2025 15:20:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [GIT PULL] VFIO updates for v6.17-rc1 To: Linus Torvalds Cc: Alex Williamson , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lizhe.67@bytedance.com" , Jason Gunthorpe References: <20250804162201.66d196ad.alex.williamson@redhat.com> <20250804185306.6b048e7c.alex.williamson@redhat.com> <0a2e8593-47c6-4a17-b7b0-d4cb718b8f88@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05.08.25 15:00, Linus Torvalds wrote: > On Tue, 5 Aug 2025 at 10:47, David Hildenbrand wrote: >> >> The concern is rather false positives, meaning, you want consecutive >> PFNs (just like within a folio), but -- because the stars aligned -- >> you get consecutive "struct page" that do not translate to consecutive PFNs. > > So I don't think that can happen with a valid 'struct page', because > if the 'struct page's are in different sections, they will have been > allocated separately too. I think you can end up with two memory sections not being consecutive, but the struct pages being consecutive. I assume the easiest way to achieve that is having a large-enough memory hole (PCI hole?) that spans more than section, and memblock just giving you the next PFN range to use as "struct page". It's one allocation per memory section, see sparse_init_nid()->__populate_section_memmap(prn, PAGES_PER_SECTION) -> memmap_alloc()->memblock_alloc(). With memory hotplug, there might be other weird ways to achieve it I suspect. > > So you can't have two consecutive 'struct page' things without them > being consecutive pages. > > But by all means, if you want to make sure, just compare the page > sections. But converting them to a PFN and then converting back is > just crazy. > > IOW, the logic would literally be something like (this assumes there > is always at least *one* page): > > struct page *page = *pages++; > int section = page_to_section(page); > > for (size_t nr = 1; nr < nr_pages; nr++) { > if (*pages++ != ++page) > break; > if (page_to_section(page) != section) > break; > } > return nr; I think that would work, and we could limit the section check to the problematic case only (sparsemem without VMEMMAP). > > and yes, I think we only define page_to_section() for > SECTION_IN_PAGE_FLAGS, but we should fix that and just have a > > #define page_to_section(pg) 0 Probably yes, have to think about that. > > for the other cases, and the compiler will happily optimize away the > "oh, it's always zero" case. > > So something like that should actually generate reasonable code. It > *really* shouldn't try to generate a pfn (or, like that horror that I > didn't pull did, then go *back* from pfn to page) > > That 'nth_page()' thing is just crazy garbage. Yes, it's unfortunate garbage we have to use even in folio_page(). > > And even when fixed to not be garbage, I'm not convinced this needs to > be in . Yeah, let's move it to mm/util.c if you agree. -- Cheers, David / dhildenb