From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FB652BEC50 for ; Fri, 11 Apr 2025 23:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744415014; cv=none; b=oJPxnAqsAF5MpwrJM1NnYRYTaJ6buc5nQoR3K/ANEmKntTWi/sr1oVn+FUlESpDLvF3nLsLYqmYsnYjE2AlcXLzux3SlHxP31dXr9s55YJkc07HGuS73ki/GCbThgeH6RJOmHajDbf1arSlHUDIp4G15qgwbPBprMaSBNToRks0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744415014; c=relaxed/simple; bh=RcYfp/RjV5F1dKaHB49S7m3vw72njaVwN3ugq7P95S4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gfi1kgJqV/IoG32Wx/ciQKJ8s3EvwFdAdWsp0r06lad5ADdbJJ55rA4VP/bHm/GAY/Fg+lXA7LVq4n/q7j3xDv4Z4bTcMk1m6eSyHgrZb9NQSLvDh8HMiWYsmISpg72ulGS//802xqx0GPVxA7dKSaEr2FIyveAwof1sxwbqf3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XQ3dwEZX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XQ3dwEZX" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53BGAKSF000641 for ; Fri, 11 Apr 2025 23:43:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5kuwO957i06jlGl35YGVg3kdzK0saemUuXwQScoMGh0=; b=XQ3dwEZX9tsZtwYx /NE4ChGMLeguTVuiUE5GTgb82bXZruH6tgXuUkNKhN7YkOFrqSq34aIAV5aSfa7m xIjah+eQ3uKG2OYh5FeHXz/L3geQhOqT4Vhvu0Ih/q8kCwwN36KprfI+nt92VU5p D1WPQ8LoPZwasbs2uCg1ZXvOcf2czFwOVXTH1CHa/Vl3J4WOhAgrrWHMNDG9cFAQ 0Jehvvro6M1twbc6KduVg3RyAqp828vM0OUsIJPkvkVLkpKTHPIlp8nSIb8l363F N4iMRcDnnWEHpnn9tKEaC1TJhr+768RLaZ92pEosQJY7JYwbdE4fB/4S3uQ7tMl0 /s5hBQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twd33vnj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 11 Apr 2025 23:43:30 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c54734292aso62686585a.2 for ; Fri, 11 Apr 2025 16:43:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744415009; x=1745019809; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5kuwO957i06jlGl35YGVg3kdzK0saemUuXwQScoMGh0=; b=CenQ9CxGsjvpv7yI102NqB6926l6XYAbItlyzdeJw33ibP0dcWoEa/MeWkXY/c2KWY cVxnoyQ1XgTzzyTRAh0py/xUuLriVh5pcfoiK3gR3EXFKZRLxz/2TeF0ldQxCmqbJbkF ixKxg2EKY2z6i/cgEV/OoCS91I8DL1B8qI2CxUYd1g8Gp/REAutpaIDeBxckneyB4L3Y ym8r8HGlrhxS/zE38VJMUxPnyhJI89fSIMmGtucoVRAoFBwB+Dk5cj2FBA799sylrJlD +S9C/bNmjzqg7g93gc36PGsx15bODFWvX/xD+E+JClWm7zAGKHEP685BaRpJTVftw13U prrA== X-Forwarded-Encrypted: i=1; AJvYcCVD544+GsWEoJXoKd2Gi6NkSvyW9zszr9j7f/r8aamv3HbPqOhFnIwsE8xUnvK9OuCG4xpu1RAtbJOHk4M=@vger.kernel.org X-Gm-Message-State: AOJu0YxefgzBrFmKocduC0Cs4on4YuAWKi4nP+SJs7DZJxNs734uAMsl FXwRj8W4bfbz2EowSp3FknBwIrfrhRFLJN7obDDsU09cCSQEHw0ItxA/BkwcgbVCUbWgPI7ZSMY +Sl3s2XUEgTcSP6C/pbQwq0MMkgC3ZPmYTgjoesz2DV+xUvdgicS1WdzJ95d18DI= X-Gm-Gg: ASbGncu4KXmxGFwACkPS5jTz3mlkyDH2vMRfKsXktxVddqW1GGT3kFxutCYSNTyvkt/ YeyWK4LGhX+Sq1tJ7eIhSUpX0jmQ1zZuj2nlHvWzdwbBBMOsCnrzJanfWavM8AglNfK2e7CFpbe vGnHPnSmlu3X3XY5wmhkwfkAo1PZnims5TmBPTccWVxan5q/b10FZCYTungm6iiT+3Wc5F+yTRs SZxtVds+Bf/MpsOvQHufPPB6VNao0zYTV2RoSkwm36aEdyhcsIPspPnXTgwjCK0vNiRf9C6vgn+ b5ZMSBW/n9DRKgu3bdwlgvociA3yCHNuxn0mH+A1Ri6zMH1UKIkuuiAj79jCMFb5Lg== X-Received: by 2002:a05:6214:f0b:b0:6d8:a091:4f52 with SMTP id 6a1803df08f44-6f230ed2d8emr20608346d6.7.1744415009365; Fri, 11 Apr 2025 16:43:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjBNP6sTL79kHO3BeKhFTVOdbgi543Y7RfDMhY1m1LwH1hR6cEmGuWH0TjpSSwXUHB3XNjhA== X-Received: by 2002:a05:6214:f0b:b0:6d8:a091:4f52 with SMTP id 6a1803df08f44-6f230ed2d8emr20608246d6.7.1744415009028; Fri, 11 Apr 2025 16:43:29 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb3fcdsm519045966b.107.2025.04.11.16.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 16:43:28 -0700 (PDT) Message-ID: <7f893243-572b-4e23-8f2b-ae364d154107@oss.qualcomm.com> Date: Sat, 12 Apr 2025 01:43:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: Enable TSENS support for QCS615 SoC To: Gaurav Kohli , amitk@kernel.org, rafael@kernel.org, daniel.lezcano@linaro.org, rui.zhang@intel.com, lukasz.luba@arm.com, robh@kernel.org, krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, quic_manafm@quicinc.com References: <76e0ce0e312f691abae7ce0fd422f73306166926.1744292503.git.quic_gkohli@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <76e0ce0e312f691abae7ce0fd422f73306166926.1744292503.git.quic_gkohli@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: AXIDAOCXSWZMnJr3blSnQbGJIQzGNQ66 X-Proofpoint-GUID: AXIDAOCXSWZMnJr3blSnQbGJIQzGNQ66 X-Authority-Analysis: v=2.4 cv=NaLm13D4 c=1 sm=1 tr=0 ts=67f9a922 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=b6z04DhpLtwLpLbA0DcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-11_09,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 impostorscore=0 priorityscore=1501 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=796 clxscore=1015 phishscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504110155 On 4/10/25 4:00 PM, Gaurav Kohli wrote: > Add TSENS and thermal devicetree node for QCS615 SoC. > > Signed-off-by: Gaurav Kohli > --- subject: "arm64: dts: qcom: qcs615: .."> arch/arm64/boot/dts/qcom/qcs615.dtsi | 281 +++++++++++++++++++++++++++ > 1 file changed, 281 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi > index edfb796d8dd3..f0d8aed7da29 100644 > --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi > @@ -3668,6 +3668,17 @@ usb_2_dwc3: usb@a800000 { > maximum-speed = "high-speed"; > }; > }; > + > + tsens0: tsens@c222000 { > + compatible = "qcom,qcs615-tsens", "qcom,tsens-v2"; > + reg = <0x0 0xc263000 0x0 0x1ff>, > + <0x0 0xc222000 0x0 0x8>; Pad the address part to 8 hex digits with leading zeroes> + interrupts = , &pdc 26 > + ; &pdc 28 Please align the + #qcom,sensors = <16>; > + interrupt-names = "uplow", "critical"; it would make sense for interrupt-names to come right under interrupts > + #thermal-sensor-cells = <1>; > + }; > }; > > arch_timer: timer { > @@ -3677,4 +3688,274 @@ arch_timer: timer { > , > ; > }; > + > + thermal-zones { > + aoss-thermal { > + thermal-sensors = <&tsens0 0>; > + > + trips { > + > + trip-point0 { > + temperature = <110000>; > + hysteresis = <5000>; > + type = "passive"; > + }; > + }; > + }; > + > + cpuss-0-thermal { > + thermal-sensors = <&tsens0 1>; > + > + trips { > + > + trip-point0 { > + temperature = <115000>; > + hysteresis = <5000>; > + type = "passive"; > + }; > + > + trip-point1 { > + temperature = <118000>; > + hysteresis = <5000>; > + type = "passive"; > + }; Please drop the passive trip point for the *CPU* tzones, see commit 06eadce936971dd11279e53b6dfb151804137836 ("arm64: dts: qcom: x1e80100: Drop unused passive thermal trip points for CPU") and add a single critical point instead, see commit 03f2b8eed73418269a158ccebad5d8d8f2f6daa1 ("arm64: dts: qcom: x1e80100: Apply consistent critical thermal shutdown") Konrad