From: Nikolay Borisov <nik.borisov@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Yazen.Ghannam@amd.com, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RAS/AMD/ATL: Remove bitwise_xor_bits
Date: Thu, 20 Nov 2025 17:45:10 +0200 [thread overview]
Message-ID: <7f942b9f-ce85-4e02-9317-3aef1dccd1c9@suse.com> (raw)
In-Reply-To: <20251120154153.GBaR82wW8qjDQA8eoV@fat_crate.local>
On 11/20/25 17:41, Borislav Petkov wrote:
> On Tue, Nov 18, 2025 at 02:36:08PM +0200, Nikolay Borisov wrote:
>> Fair point, but bitwise xor is the lowest possible operation, I guess we
>> care about the higher-level effect, which is calculating parity.
>
> ... in a function which "Calculate hash for each Bank bit."?
>
> I don't think it matters either way. This is converting the DRAM addressing
> scheme into normalized addresses so as long as it is clear what happens
> there...
>
So are you saying the patch should be dropped altogether or that the
changelog should be reworded? The way I see it, the parity for the
given bank's col/row are calculated and this then is used into
calculating the hash.
next prev parent reply other threads:[~2025-11-20 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 11:11 Nikolay Borisov
2025-11-18 12:33 ` Borislav Petkov
2025-11-18 12:36 ` Nikolay Borisov
2025-11-20 15:41 ` Borislav Petkov
2025-11-20 15:45 ` Nikolay Borisov [this message]
2025-11-20 15:57 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f942b9f-ce85-4e02-9317-3aef1dccd1c9@suse.com \
--to=nik.borisov@suse.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®