From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20DE91E885A for ; Mon, 5 Jan 2026 22:24:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767651896; cv=none; b=VnBzjIWw4J2+V1odHBRFy7JkAtk9yc6GHassk83OGrLMTW/g/ErFQjV3fz0WHMuTPml+EVpGM6503LahmKWU+JueyqCqb7UbgGWnS9h+xq3BjCkY+kyHpEy96f/5w/Gg8aa5fNE3Iy+x0cJs5Jk2nHYdiYVMB+uqn73gCUgIB1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767651896; c=relaxed/simple; bh=4GujXFcPY78Soe5fJ5zpAxshw/1UlVOk9zQiTnAySak=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=koC96WQLY/SUFkcQtZZ6qpXbqgutgd0NazEJ56mhcCuvEeAidXEfN1q+WLQJxOlk2wpkwJJ0RAMK/ECoGbI2QYy20R5GtqmGCsmKY1X/AOnxrwauSMbc6hBt82XPoMid/07XJ196S9svHepR9Z0TuKyfc0z54RE0RmCDcTdKop8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OLYfXn1w; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iGZE8w74; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OLYfXn1w"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iGZE8w74" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767651894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UIu36dvOmGSWGl/xVA3p8ygE7dV+HFTFGY8xQr3jAbk=; b=OLYfXn1wKltSxz97KBeZIaXkqe3zKkZMOOogh2Y1d77+GDMcewGNDo/gZVBzIfuKxSB06w x9L9c7yI8izwt+VbQ0FvlED8a6Ja9GP0gHXKBTsR+7Z20HAvmElS6X/eNesbZJG59Z4jvz G8p5Vz9o15EwrgE2uoniKzQnIALgNWc= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-OGwv7SQBOvmuTkTVvRjdUA-1; Mon, 05 Jan 2026 17:24:53 -0500 X-MC-Unique: OGwv7SQBOvmuTkTVvRjdUA-1 X-Mimecast-MFC-AGG-ID: OGwv7SQBOvmuTkTVvRjdUA_1767651892 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4eff973c491so8579621cf.1 for ; Mon, 05 Jan 2026 14:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767651892; x=1768256692; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=UIu36dvOmGSWGl/xVA3p8ygE7dV+HFTFGY8xQr3jAbk=; b=iGZE8w7471qtJS6Dr67JwcDKXIwNJyH+kshUD/o3O4u+kcvuIDdSMf/eqOROSVm/KP l1hXnLIjSah7gQSqKLrNIzkTjFoBnSlpRu6T3gnJ01wuxaZsf03HpNg5KlCkPrtYoNHN rdNb0g08YNQw0I91u0qsMwHhdS/z+EVELCb4239P3EjdTWpWKaAwDcmmuRVxE+mKeMcV jA1E99K+kwvl9ghmqQ7xDataOkJ6jUnayxbuHg9oh8dD7vSpxEK3In539EcTwHTdvq2w DDTo83c9wZG2m163xWSPMn+7DVS9jBKQLwu3h9tHqAtZibpRWxiujw/n5YMWTJNHyjtt J8Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767651892; x=1768256692; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UIu36dvOmGSWGl/xVA3p8ygE7dV+HFTFGY8xQr3jAbk=; b=QzQoAiIU5nty8do8Aqa+iJ6ZmBShvE8gijaLovhh98CSP85txEJN3AsdsKnL/btdzw TUYB5bpxz73nbCMLi2/SfNePqJYDdAipOFl63l/oNMuAYZy9rMngbvnmPdks9xK/Dwdf AKTnWK5te0N+0LMEzAhs06d7bfBJEYGNkcnXrktNnp37wWaOpd9JUWIbaGTPa8UBsZpS 0RHn7SF3HwZaPCFt1MJMFBIKUQREK6asCcvQS37BOGJrO34FxV5y4fsoQsKlIGKE1BLW DAskMQvSSgj6ldlLWVD4Vl5IetsQXj8Zdyke7LrzTYfkMwb2VVqGgYQHeUZbqviSTtdq UEMA== X-Forwarded-Encrypted: i=1; AJvYcCU3IuzxRgB/PUpj1knhbiEp3nXO9/P3bHveFeQ92pzgFNRxBzrwq5upoRNmbBKmpFwLt/r8wpcS0tbazUs=@vger.kernel.org X-Gm-Message-State: AOJu0YxY6Kb/IsXUw7b1Sgi1i1Jlh4Je3p4gs/CDHLzYxiKrB7uU6XlZ E/8Q0aJuwTjqdPpt3yUKGNznLEIo/CieuZYaUyTcaa60mMwBm2jIC35qQEurpaNPHjA4tXEM2ZE vOlE3Txqgno8K08yvh2X3wDKiq3tSldk4hbog+AvYlyr/m9vMdk1OwGevwYXVS/JzZw== X-Gm-Gg: AY/fxX6VcpRn9N+sExGhQUgU2akkZzVQG4Xjor3MR9juTgbxhYxxGfEsZ7tyAmsFAy3 Uppjxcd6JhrtCvewgMldlqBtNYeCKWkzpkc6pWvWtaY16hNYYrBmDLIdKd7vhWtLC7IA8PYzXDn NctYxjCotsHQNmkUFDs2oTY7vepF9TQTx6/TmIo/sl9RHBGU4uKlQ5ZTCFMjCVVt+wpgxUJnbz4 +7vektYv4qvFuOriPo7QvPxghOAj5R/4mmwZq0Nvl+lEvt+x4MZR62i90yoMBr0NhWqE++Rvvon nsviDWnq8z75n+5cHGpVwKt/LrqRfRSsvtj4/GrwG9pX/xlzHkAua2mrtDcKXheuEXjDD8sM7d2 S9Q6I1oGu1yWah9eNhr7kGLW+n9euwMFiBEWz8Y92Fw== X-Received: by 2002:a05:622a:3c8:b0:4f1:caed:da6b with SMTP id d75a77b69052e-4ffa76d8404mr15124121cf.35.1767651892405; Mon, 05 Jan 2026 14:24:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IExNh0xTTv6L2+E9HZQoqXbrAGQ+sIzOchE6ENYBi29Y5oaqVBf9GDoOpp1unnFpjh+Y6BDeA== X-Received: by 2002:a05:622a:3c8:b0:4f1:caed:da6b with SMTP id d75a77b69052e-4ffa76d8404mr15123831cf.35.1767651892036; Mon, 05 Jan 2026 14:24:52 -0800 (PST) Received: from crwood-thinkpadp16vgen1.minnmso.csb ([2601:447:cc81:56d0:ab94:b2cb:29a6:7ac0]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8907726041fsm2305706d6.45.2026.01.05.14.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 14:24:51 -0800 (PST) Message-ID: <7f953b7e2a9d30e0f22c30c5c4e10828018bc40c.camel@redhat.com> Subject: Re: [PATCH v1 1/4] tools/rtla: Consolidate nr_cpus usage across all tools From: Crystal Wood To: Tomas Glozar , Costa Shulyupin Cc: Steven Rostedt , Wander Lairson Costa , Ivan Pravdin , John Kacur , Tiezhu Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Date: Mon, 05 Jan 2026 16:24:50 -0600 In-Reply-To: References: <20251205151924.2250142-1-costa.shul@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-12-17 at 10:06 +0100, Tomas Glozar wrote: > =C3=BAt 16. 12. 2025 v 15:41 odes=C3=ADlatel Tomas Glozar napsal: > > Since commit 2f3172f9dd58c ("tools/rtla: Consolidate code between > > osnoise/timerlat and hist/top") that was merged into 6.18, common.h > > includes timerlat_u.h. Your change thus causes a double include of > > timerlat_u.h, leading to a build error: > >=20 > > In file included from src/timerlat_u.c:20: > > src/timerlat_u.h:6:8: error: redefinition of =E2=80=98struct timerlat_u= _params=E2=80=99 > > 6 | struct timerlat_u_params { > > | ^~~~~~~~~~~~~~~~~ > > In file included from src/common.h:5, > > from src/timerlat_u.c:19: > > src/timerlat_u.h:6:8: note: originally defined here > > 6 | struct timerlat_u_params { > > | ^~~~~~~~~~~~~~~~~ > >=20 > > Please rebase your patchset and fix this so that timerlat_u.h is only > > included once. > >=20 >=20 > Correction: the base of the patchset has nothing to do with this. It > is the C standard, from C23 (default in GCC 15), redefinition of > structs is allowed [1], so this error doesn't exist. In earlier > standards, this is not allowed. >=20 > [1] https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2863.pdf Regardless of how permissive the language might be getting in this case, we should have #pragma once on all of the headers to avoid this sort of problem. -Crystal