From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Frank.Li@oss.nxp.com
Cc: Mark Brown <broonie@kernel.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Radu Pirea <radu_nicolae.pirea@upb.ro>,
CL Wang <cl634@andestech.com>,
Ryan Wanner <ryan.wanner@microchip.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Vladimir Oltean <olteanv@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Han Xu <han.xu@nxp.com>,
Haibo Chen <haibo.chen@nxp.com>,
Linus Walleij <linusw@kernel.org>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Heiko Stuebner <heiko@sntech.de>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Andi Shyti <andi.shyti@kernel.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Yixun Lan <dlan@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Alain Volmat <alain.volmat@foss.st.com>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sowjanya Komatineni <skomatineni@nvidia.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
"open list:SPI SUBSYSTEM" <linux-spi@vger.kernel.org>,
"moderated list:ARM/Microchip (AT91) SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"open list:FREESCALE DSPI DRIVER" <imx@lists.linux.dev>,
"open list:ARM/QUALCOMM MAILING LIST"
<linux-arm-msm@vger.kernel.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>,
"open list:RENESAS RZ/V2H(P) RSPI DRIVER"
<linux-renesas-soc@vger.kernel.org>,
"open list:SAMSUNG SPI DRIVERS"
<linux-samsung-soc@vger.kernel.org>,
"open list:RISC-V SPACEMIT SoC Support"
<linux-riscv@lists.infradead.org>,
"open list:RISC-V SPACEMIT SoC Support"
<spacemit@lists.linux.dev>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
"open list:ARM/Allwinner sunXi SoC support"
<linux-sunxi@lists.linux.dev>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback()
Date: Wed, 4 Nov 2026 18:02:04 +0100 [thread overview]
Message-ID: <7f96599b-681d-4963-bdda-1274371ac84f@kernel.org> (raw)
In-Reply-To: <autj6pr_bPaul3w0@ashevche-desk.local>
On 04/11/2026 17:57, Andy Shevchenko wrote:
> On Wed, Nov 04, 2026 at 10:22:45AM -0500, Frank.Li@oss.nxp.com wrote:
>>
>> Replace open-coded assignments to callback and callback_param fields
>> of struct dma_async_tx_descriptor with calls to the
>> dmaengine_desc_set_callback() helper across SPI bus drivers.
>>
>> No functional change intended. Prepare make to struct
>> dma_async_tx_descriptor private to the DMA engine.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> # dw, pxa2xx, topcliff-pch
>
> (Note, you forgot to add the list of the drivers to the Rb trailers of other reviewers)
These should be acks. RB creates false impression entire commit was
reviewed. Our docs also clearly state entire commit:
"Reviewed-by:, instead, indicates that the patch has been reviewed and
found acceptable according to the Reviewer's Statemen"
(not patch or part of patch)
"By offering my Reviewed-by: tag, I state that
I have carried out a technical review of this patch to
"
(not patch or part of patch)
When you accept only part of this code, you basically Ack. I really
dislike these half-done reviews, which later appear in logs and tell you
nothing. You could have clear security bug here, but 10 review tags. How
useful tags...
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-04 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:22 Frank.Li
2026-11-04 16:57 ` Andy Shevchenko
2026-11-04 17:02 ` Krzysztof Kozlowski [this message]
2026-11-04 17:08 ` Krzysztof Kozlowski
2026-11-04 17:23 ` Andy Shevchenko
2026-11-04 17:27 ` Krzysztof Kozlowski
2026-11-04 20:41 ` Andy Shevchenko
2026-11-04 22:54 ` Krzysztof Kozlowski
2026-11-04 17:25 ` Krzysztof Kozlowski
2026-11-04 20:44 ` Andy Shevchenko
2026-11-04 23:02 ` Krzysztof Kozlowski
2026-11-04 18:18 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f96599b-681d-4963-bdda-1274371ac84f@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=cl634@andestech.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=daniel@zonque.org \
--cc=dlan@kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=haibo.chen@nxp.com \
--cc=han.xu@nxp.com \
--cc=haojian.zhuang@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=ldewangan@nvidia.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=nicolas.ferre@microchip.com \
--cc=olteanv@gmail.com \
--cc=peter.griffin@linaro.org \
--cc=radu_nicolae.pirea@upb.ro \
--cc=rjui@broadcom.com \
--cc=robert.jarzmik@free.fr \
--cc=ryan.wanner@microchip.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=skomatineni@nvidia.com \
--cc=spacemit@lists.linux.dev \
--cc=thierry.reding@kernel.org \
--cc=treding@nvidia.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=tudor.ambarus@linaro.org \
--cc=wens@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®