mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Assad" <massad@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: trivial@kernel.org, hc@mivu.no, torvalds@osdl.org, dtor@mail.ru
Subject: [PATCH] itmtouch: fix inverted flag to indicate touch location correctly
Date: Thu, 5 Oct 2006 10:36:49 +1000	[thread overview]
Message-ID: <7f9863480610041736k2fe84c6bqd1d9740868dedf7d@mail.gmail.com> (raw)

From: Mark Assad <massad@gmail.com>

There is a bug in the current version of the itmtouch USB touchscreen
driver. The if statment that checks if pressure is being applied to
the touch screen is now missing a ! (not), so events are no longer
being reported correctly.

The origonal source code for this line was as follows:
#define UCP(x) ((unsigned char*)(x))
#define UCOM(x,y,z) ((UCP((x)->transfer_buffer)[y]) & (z))
if (!UCOM(urb, 7, 0x20)) {

And was cleaned to:
 unsigned char *data = urb->transfer_buffer;
....
 if (data[7] & 0x20) {

(note the lack of ! )

This has been tested on an LG L1510BF and an LG1510SF touch screen.

Patched applied from: linux-2.6.18

Signed-off-by: Mark Assad <massad@gmail.com>

---

--- linux-2.6.18/drivers/usb/input/itmtouch.c   2006-09-20
13:42:06.000000000 +1000
+++ linux/drivers/usb/input/itmtouch.c  2006-10-05 09:49:56.000000000 +1000
@@ -36,7 +36,11 @@
  *
  * 1.2.1  09/03/2005 (HCE) hc@mivu.no
  *   Code cleanup and adjusting syntax to start matching kernel standards
- *
+ *
+ * 1.2.2  10/05/2006 (MJA) massad@gmail.com
+ *   Flag for detecting if the screen was being touch was incorrectly
+ *   inverted, so no touch events were being detected.
+ *
  *****************************************************************************/

 #include <linux/kernel.h>
@@ -53,7 +57,7 @@
 #define USB_PRODUCT_ID_TOUCHPANEL      0xf9e9

 #define DRIVER_AUTHOR "Hans-Christian Egtvedt <hc@mivu.no>"
-#define DRIVER_VERSION "v1.2.1"
+#define DRIVER_VERSION "v1.2.2"
 #define DRIVER_DESC "USB ITM Inc Touch Panel Driver"
 #define DRIVER_LICENSE "GPL"

@@ -108,7 +112,7 @@ static void itmtouch_irq(struct urb *urb
        input_regs(dev, regs);

        /* if pressure has been released, then don't report X/Y */
-       if (data[7] & 0x20) {
+       if (!(data[7] & 0x20)) {
                input_report_abs(dev, ABS_X, (data[0] & 0x1F) << 7 |
(data[3] & 0x7F));
                input_report_abs(dev, ABS_Y, (data[1] & 0x1F) << 7 |
(data[4] & 0x7F));
        }

             reply	other threads:[~2006-10-05  0:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-05  0:36 Mark Assad [this message]
2006-10-05  2:14 ` Linus Torvalds
2006-10-05  3:41   ` Randy Dunlap
2006-10-10 21:36     ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f9863480610041736k2fe84c6bqd1d9740868dedf7d@mail.gmail.com \
    --to=massad@gmail.com \
    --cc=dtor@mail.ru \
    --cc=hc@mivu.no \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®