From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA541C32792 for ; Mon, 22 Aug 2022 19:21:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237993AbiHVTVZ (ORCPT ); Mon, 22 Aug 2022 15:21:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238626AbiHVTUw (ORCPT ); Mon, 22 Aug 2022 15:20:52 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DB7750183; Mon, 22 Aug 2022 12:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=+7qd52N+R+Sb4ct0/RwuDfez59xnxOcYNoEXOOggkG8=; t=1661195987; x=1662405587; b=gHAICJVkWzz3irH3yLRMXjJmfIFhT4+odxyb/DZjOTqgtq/ roLjB41mFKJYuzUEFosFe5AQVJpEa5cfGGa48OFl+DpWypq6DmUrCX3omFQG0jyaceMG8ZwIPtZlk cByPuFcJazv89Nliz8RrVT701jAI8Cbjm67G2j2P+kLYkYwPEItsO46lWr3HX6pUl4j8r9Brp0rSr VcQhWTZJ8SXRApPkENOzHoZW7UpJBXl2bR9BILFAyuGGZzLllv6Nz9lnTB1PcjbkDyAPZvwO1YVum uLMLRq2zRMtPF2jZOsPJzCaWPf1Hp75Ub/kRuXwCo2Xjt7FqdqLh02N4ukx90/pg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oQCxX-00Edep-2e; Mon, 22 Aug 2022 21:19:39 +0200 Message-ID: <7f9a39d1d1557afa09aa8b657a40f0c03e621cfa.camel@sipsolutions.net> Subject: Re: Aw: Re: Re: help for driver porting - missing member preset_chandef in struct wireless_dev From: Johannes Berg To: Frank Wunderlich Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Mon, 22 Aug 2022 21:19:38 +0200 In-Reply-To: References: <51a1b56a4d9ed825cb47cf364c5bd72f3338a1a6.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-08-22 at 18:59 +0200, Frank Wunderlich wrote: > > Gesendet: Montag, 22. August 2022 um 18:43 Uhr > > Von: "Johannes Berg" >=20 > > On Mon, 2022-08-22 at 18:42 +0200, Frank Wunderlich wrote: >=20 > > > thanks for response, commented out the use of the member and the > > > wdev > > > assignment as it was then unused > > > can you tell me which api-call this should be? > > > i just want to make sure this is really done as i up-ported the > > > driver > > > from 4.9, so if the api-call was introduced later it is maybe > > > missing. > >=20 > > No sorry, I don't know how the driver was/is using it, so I can't > > tell > > you how to replace it. >=20 > can you give me possible calls (if there are multiple candidates) > which may set the channel (without mesh) > for me to check or maybe implement? Well it seems to access it inside the start_ap callback, so it should just check the configuration instea