From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61571C3527D for ; Thu, 14 Apr 2022 14:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345546AbiDNOuT (ORCPT ); Thu, 14 Apr 2022 10:50:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345199AbiDNNpY (ORCPT ); Thu, 14 Apr 2022 09:45:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 22EAB5FD5 for ; Thu, 14 Apr 2022 06:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649943779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cEwU1k8RkWbHuBpGrcJSmZWxIQf9wx4CSSVAzVNcIcQ=; b=ZLcgSWeM8QtZkU9ae04DMJ2myjV4G3DNBxL5Lhd0cQjwBAmwozJq0ZlXRqlCFxX1gf/Lt6 0ghdps+DuqWQNsLL+cAJL5I2LMn99cpcB3IhC0e/Dsn71A2jT2GVjb79HxnOxaoDtm7Vl6 9kwGcoAyKlA16hDjNrQQtU7mXAag/ko= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-511-wUZU7hvyOgy4Bc7zOMyeAA-1; Thu, 14 Apr 2022 09:42:58 -0400 X-MC-Unique: wUZU7hvyOgy4Bc7zOMyeAA-1 Received: by mail-wm1-f70.google.com with SMTP id 6-20020a1c0206000000b0038ff4f1014fso1109215wmc.7 for ; Thu, 14 Apr 2022 06:42:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=cEwU1k8RkWbHuBpGrcJSmZWxIQf9wx4CSSVAzVNcIcQ=; b=i8MgHJlfEbqk4nSa8RKCBTp7wtJIotZ2nwAyU/KyKGV7RhJCPIJjzwvc3aPg1wSCBX Md7sEVr9WtAaD2hrgz8VtgXL7HfozStGjhKfRF5LWLB807HikP8pW6j/6kG47J2/FHdZ ly9lF62ZZSRT4mc3NOcipUrJWvZ6xCScGRJ7V3WXyrElQv+NytjjYeKpLGHf+5OnLV4V MzuBQwIoqWnth/o0PpsmIUoerhWbBm462lR1IYarUvYID0I8wp3KZolQ9PyVfQzGnaFZ rCulVNEcyR3WJXyipOXelSmtnI1Ilmp5yWmw6WV3O/pS/HjRQ0xOjTJPipbrt1zyKJEC KkRA== X-Gm-Message-State: AOAM530YMeSYM1Xk9KSdVzU87j7O2B0uTT+ic6i4/VQElF4Q42K03dRP 39XasilFc2MPgB0ByPES4sUoFdjfz55m75+0XM/N01QIF1Z4WcvJ1MGObLVPE+mNV0eyLkQa0SI Hy2rBkwHTvn5m1m6+wZXQzkbi X-Received: by 2002:adf:f783:0:b0:207:a8ce:c155 with SMTP id q3-20020adff783000000b00207a8cec155mr2222983wrp.258.1649943776972; Thu, 14 Apr 2022 06:42:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPeHlNz+XH8pGgX+QQTKvuDAR0AtbdicT3vCkba0paOH9TIMgYj+vx/KybA6X1K9UK6B5gJA== X-Received: by 2002:adf:f783:0:b0:207:a8ce:c155 with SMTP id q3-20020adff783000000b00207a8cec155mr2222971wrp.258.1649943776771; Thu, 14 Apr 2022 06:42:56 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-96-237.dyn.eolo.it. [146.241.96.237]) by smtp.gmail.com with ESMTPSA id e14-20020a5d6d0e000000b002078ea4f6bdsm2166780wrq.75.2022.04.14.06.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 06:42:56 -0700 (PDT) Message-ID: <7f9ae4f7c484d16e8f9a923f2facee95a720a62b.camel@redhat.com> Subject: Re: [net-next PATCH v2 1/4] drivers: net: dsa: qca8k: drop MTU tracking from qca8k_priv From: Paolo Abeni To: Vladimir Oltean Cc: Ansuel Smith , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 14 Apr 2022 15:42:55 +0200 In-Reply-To: <20220412173019.4189-2-ansuelsmth@gmail.com> References: <20220412173019.4189-1-ansuelsmth@gmail.com> <20220412173019.4189-2-ansuelsmth@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-04-12 at 19:30 +0200, Ansuel Smith wrote: > DSA set the CPU port based on the largest MTU of all the slave ports. > Based on this we can drop the MTU array from qca8k_priv and set the > port_change_mtu logic on DSA changing MTU of the CPU port as the switch > have a global MTU settingfor each port. > > Signed-off-by: Ansuel Smith @Vladimir: it looks like this addresses your concern on the previous iteration, could you please have a look? Thanks! Paolo