From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DAAEC4167B for ; Mon, 4 Dec 2023 14:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345601AbjLDOnn (ORCPT ); Mon, 4 Dec 2023 09:43:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233602AbjLDOnl (ORCPT ); Mon, 4 Dec 2023 09:43:41 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E112B3; Mon, 4 Dec 2023 06:43:47 -0800 (PST) Received: from kwepemm000007.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SkRB11PnYz14L99; Mon, 4 Dec 2023 22:38:49 +0800 (CST) Received: from [10.67.120.192] (10.67.120.192) by kwepemm000007.china.huawei.com (7.193.23.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 4 Dec 2023 22:43:45 +0800 Message-ID: <7f9fffe3-2fb8-41a2-9eb0-4adf91566a21@huawei.com> Date: Mon, 4 Dec 2023 22:43:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: , , , , , Subject: Re: [PATCH V2 net 2/2] net: hns: fix fake link up on xge port To: Wojciech Drewek , , , , , , References: <20231204011051.4055031-1-shaojijie@huawei.com> <20231204011051.4055031-3-shaojijie@huawei.com> From: Jijie Shao In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.192] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm000007.china.huawei.com (7.193.23.189) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 2023/12/4 18:19, Wojciech Drewek wrote: > > On 04.12.2023 02:10, Jijie Shao wrote: >> >> +static void hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv, >> + u32 *link_status) >> +{ > It would be cleaner to return the link status than using output arg IMO > Yes, it's a good suggestion, and this is modified in v3