mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhao Gongyi" <zhaogongyi@bytedance.com>
To: "Oleg Nesterov" <oleg@redhat.com>
Cc: <catalin.marinas@arm.com>, <will@kernel.org>,
	<mark.rutland@arm.com>,  <ruanjinjie@huawei.com>,
	<linux-arm-kernel@lists.infradead.org>,
	 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] arm64: ptrace: don't warn on missing siginfo in a group-stop
Date: Mon, 9 Nov 2026 12:10:11 +0800	[thread overview]
Message-ID: <7fb3d264-ada7-4dfd-be21-05ce370686a0@bytedance.com> (raw)
In-Reply-To: <avDGjYYR6Tj1sVgP@redhat.com>

Hi Oleg,

Thanks for the review and Acked-by.

On 11/9/26 2:59 AM, Oleg Nesterov wrote:
> 
> ----------------------------------------------------------------------------
> But can't resist... The old comment was obviously wrong, the new one doesn't
> look clear to me. It correctly explains why info can be NULL, but not why we
> should not update orig_x0 in this case. May be it should just say that exit-stop
> always comes with info != NULL?
> 

You're right: the comment explains why info can be NULL, but not why we
return. The early return is intentional: it keeps orig_x0 unchanged
during a non-seized group-stop. I'll wait for Catalin and Will's 
thoughts on the wording.

Thanks,
Gongyi

      reply	other threads:[~2026-11-09  4:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 11:30 Zhao Gongyi
2026-11-08 18:59 ` Oleg Nesterov
2026-11-09  4:10   ` Zhao Gongyi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fb3d264-ada7-4dfd-be21-05ce370686a0@bytedance.com \
    --to=zhaogongyi@bytedance.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=oleg@redhat.com \
    --cc=ruanjinjie@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®