From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34997C433FE for ; Wed, 26 Oct 2022 12:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233692AbiJZMsR (ORCPT ); Wed, 26 Oct 2022 08:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230090AbiJZMsM (ORCPT ); Wed, 26 Oct 2022 08:48:12 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF5F7F037B for ; Wed, 26 Oct 2022 05:48:09 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id v1so26118235wrt.11 for ; Wed, 26 Oct 2022 05:48:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=sE+Z+aKLJBtR9+dUAYPrvxdETqNrnLtSJWEUx86MZUY=; b=LgFZ+HsJWkjGEKA11bTVdRFztvzXwO9fKzUQAqIlxHUGul209ZoEGwdHDD1HUDsubN mxURJ6DB6lufQtk/JQuM4mQkBkRLVSihiMssJVyBnADDKCR8VS2mqsDJFRl8yO+n+SFa 4ruiHOfTIYKd3p3YbDfB3sj38wIoG4URoTTBTdoD8iWbwpMkR//mHaqIDzGG2Y0pbaEP CpdOBioxo0xDqR3VzspalN+DtOlnFzeIKzXsznYgdmBfSFf+TaAPX9vuPCPGnhVJofQj BO0iqSH7FTp1lZsWOh290I3LKbKc2GnRkGH+lAb7iNTToqdAOOrL3Nu/jOy6axNEXX2I BXBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sE+Z+aKLJBtR9+dUAYPrvxdETqNrnLtSJWEUx86MZUY=; b=iUPhWvJ2ZAa5/e/M5qy09Klzz2GdDA2KenW2hJGST7zw991PStAaO9P/N10N8+oLBI gllz2F7AtZYuArOUuGbwkRm06/GSiVPImqsM4eZbuYu4FWBP6p6ZXcRI54+z6kWQXe0i 4dV3ISnR2aSwoRBxPytYi2VObtWEVcofo9xgbFEit3/3n3VbsFsaPNhMy2oq5u6MYUu1 Q57J+Y9XMygpFxbah61cfoWcCTN3/aHjqNLY95AbesaRvWIgfxSNUbZXEAMjnCNq/yX0 pui5oOeHc/InsN9rQaia0/ngs8RSU56HstbTDjkNA737Y0eVvmV6jQQ4j6R5pfBOq2XJ //VQ== X-Gm-Message-State: ACrzQf1xl8fPW3KCOsizb209vjzowKY3ev3fGn6Tu/5WxwtmII3CMcdp lxcDJYDtge7nNTW20xomPb/+H4OvSRkTuMeO X-Google-Smtp-Source: AMsMyM6G0WR4Rb+GNc4kV+pKzodpC/zISi+uYoMUyMA4pSMIWBEbJUwfnw3+ujlVLTZAFzYSTCzM2A== X-Received: by 2002:adf:e94b:0:b0:236:64a5:4038 with SMTP id m11-20020adfe94b000000b0023664a54038mr14561473wrn.321.1666788488542; Wed, 26 Oct 2022 05:48:08 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:ce41:a140:b67e:6c4b? ([2a01:e0a:982:cbb0:ce41:a140:b67e:6c4b]) by smtp.gmail.com with ESMTPSA id n2-20020adfe342000000b0023691d62cffsm62991wrj.70.2022.10.26.05.48.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Oct 2022 05:48:08 -0700 (PDT) Message-ID: <7fb8e635-ef61-0773-eadc-7a5723740df6@linaro.org> Date: Wed, 26 Oct 2022 14:48:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] spi: meson-spicc: move wait completion in driver to take bursts delay in account Content-Language: en-US To: Mark Brown Cc: Jerome Brunet , Martin Blumenstingl , Kevin Hilman , linux-arm-kernel@lists.infradead.org, Da Xue , linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org References: <20221026-spicc-burst-delay-v1-0-1be5ffb7051a@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 26/10/2022 14:39, Mark Brown wrote: > On Wed, Oct 26, 2022 at 09:58:28AM +0200, Neil Armstrong wrote: > >> - spi_finalize_current_transfer(spicc->master); >> + complete(&spicc->done); > > No, you need to call spi_finalize_current_transfer() - you need to block > inside the transfer function if you want to open code this stuff. It's the case, I added a wait_for_completion_timeout() + return 0 in meson_spicc_transfer_one. Neil