From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Sung-Chi, Li" <lschyi@chromium.org>,
Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] platform/chrome: cros_ec_charge_state: add new driver to control charge
Date: Thu, 21 Nov 2024 15:11:30 +0100 [thread overview]
Message-ID: <7fc1bbbc-3cba-45bd-a5b6-0029cb5bb8fd@t-8ch.de> (raw)
In-Reply-To: <1e8bf721-f930-4365-be48-a8c5964c1457@kernel.org>
On 2024-11-21 15:00:13+0100, Krzysztof Kozlowski wrote:
> On 21/11/2024 14:47, Thomas Weißschuh wrote:
> >
> >> +
> >> + return 0;
> >> +}
> >> +
> >> +static const struct platform_device_id cros_ec_charge_state_id[] = {
> >> + { DRV_NAME, 0 },
> >> + {}
> >> +};
> >
> > Reference this in the platform_driver below.
>
> And missing module device table... This wasn't ever tested as module.
It has one in the general MODULE_*() macro soup at the end of the file.
But yes, it should be moved where it can be found, right after
cros_ec_charge_state_id.
next prev parent reply other threads:[~2024-11-21 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 9:33 [PATCH 0/3] Introduce new driver cros-ec-charge-state Sung-Chi, Li
2024-11-18 9:33 ` [PATCH 1/3] platform/chrome: cros_ec_charge_state: add new driver to control charge Sung-Chi, Li
2024-11-20 16:08 ` Tzung-Bi Shih
2024-11-21 13:05 ` kernel test robot
2024-11-21 13:47 ` Thomas Weißschuh
2024-11-21 14:00 ` Krzysztof Kozlowski
2024-11-21 14:11 ` Thomas Weißschuh [this message]
2024-11-22 1:53 ` Sung-Chi, Li
2024-11-18 9:33 ` [PATCH 2/3] dt-bindings: chrome: add new binding google,cros-ec-chrage-state Sung-Chi, Li
2024-11-18 10:22 ` Rob Herring (Arm)
2024-11-18 20:25 ` Rob Herring
2024-11-19 2:23 ` Sung-Chi, Li
2024-11-20 16:35 ` Krzysztof Kozlowski
2024-11-20 16:37 ` Krzysztof Kozlowski
2024-11-18 9:33 ` [PATCH 3/3] mfd: cros_ec: Add charge state control cell Sung-Chi, Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fc1bbbc-3cba-45bd-a5b6-0029cb5bb8fd@t-8ch.de \
--to=thomas@t-8ch.de \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=groeck@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lschyi@chromium.org \
--cc=robh@kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®