From: Adrian Hunter <adrian.hunter@intel.com>
To: "Michael K. Johnson" <johnsonm@danlj.org>
Cc: Ben Chuang <benchuanggli@gmail.com>,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, ben.chuang@genesyslogic.com.tw
Subject: Re: [PATCH V6 5/5] mmc: host: sdhci-pci: Add Genesys Logic GL975x support
Date: Thu, 29 Aug 2019 16:21:11 +0300 [thread overview]
Message-ID: <7fcd0fd5-97cb-1dab-7477-666838478541@intel.com> (raw)
In-Reply-To: <20190828134714.GA30547@people.danlj.org>
On 28/08/19 4:47 PM, Michael K. Johnson wrote:
> On Wed, Aug 28, 2019 at 04:13:03PM +0300, Adrian Hunter wrote:
>> On 27/08/19 3:33 AM, Ben Chuang wrote:
>> Looks good, one minor comment
> ...
>>> +#ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS
>>
>> Arguably CONFIG_MMC_SDHCI_IO_ACCESSORS needs to be removed altogether. i.e.
>> making the accessors always available. So for now, I'd prefer to select
>> MMC_SDHCI_IO_ACCESSORS:
>>
>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> index 14d89a108edd..c3bd967d8a1a 100644
>> --- a/drivers/mmc/host/Kconfig
>> +++ b/drivers/mmc/host/Kconfig
>> @@ -94,6 +94,7 @@ config MMC_SDHCI_PCI
>> depends on MMC_SDHCI && PCI
>> select MMC_CQHCI
>> select IOSF_MBI if X86
>> + select MMC_SDHCI_IO_ACCESSORS
>> help
>> This selects the PCI Secure Digital Host Controller Interface.
>> Most controllers found today are PCI devices.
>
> Unless I'm missing something, this seems like a separate patch;
> are you asking for it first, as a predecessor to the GLI patch?
>
No, it is fine with this patch.
next prev parent reply other threads:[~2019-08-29 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 0:33 Ben Chuang
2019-08-28 13:13 ` Adrian Hunter
2019-08-28 13:47 ` Michael K. Johnson
2019-08-29 13:21 ` Adrian Hunter [this message]
2019-08-30 1:15 ` Ben Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fcd0fd5-97cb-1dab-7477-666838478541@intel.com \
--to=adrian.hunter@intel.com \
--cc=ben.chuang@genesyslogic.com.tw \
--cc=benchuanggli@gmail.com \
--cc=johnsonm@danlj.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®