mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Kalle Valo" <kvalo@kernel.org>,
	hust-os-kernel-patches@googlegroups.com,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ath9k: clean up function ath9k_hif_usb_resume
Date: Tue, 5 Sep 2023 14:19:17 +0300	[thread overview]
Message-ID: <7fd16cae-483c-4145-ae59-ee1775005fa8@kadam.mountain> (raw)
In-Reply-To: <20230905013556.2595854-1-dzm91@hust.edu.cn>

On Tue, Sep 05, 2023 at 09:35:56AM +0800, Dongliang Mu wrote:
> In ath9k_hif_usb_resume, the error handling code calls
> ath9k_hif_usb_dealloc_urbs twice in different paths.
> 
> To unify the error handling code, we move the else branch before
> the if branch and drop one level of indentation of the if branch.
> 
> In addition, move the ret variable at the end of variable declarations
> to be reverse x-mas tree order.
> 
> Note that this patch does not incur any functionability change.
> 
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
>  drivers/net/wireless/ath/ath9k/hif_usb.c | 34 ++++++++++++------------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> v1->v2: move the else branch on top of if branch;
>         move ret variable at the end of variable declarations;

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter


  reply	other threads:[~2023-09-05 16:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05  1:35 Dongliang Mu
2023-09-05 11:19 ` Dan Carpenter [this message]
2023-09-05 11:54 ` Toke Høiland-Jørgensen
2023-09-05 17:33   ` Toke Høiland-Jørgensen
2023-09-05 17:33 ` Toke Høiland-Jørgensen
2023-09-21  8:04 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fd16cae-483c-4145-ae59-ee1775005fa8@kadam.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=dzm91@hust.edu.cn \
    --cc=hust-os-kernel-patches@googlegroups.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®